Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18;
Message-ID: <7b292868-f875-f225-ab56-b6f140a6373a@redhat.com>
Date:   Mon, 17 Jan 2022 14:16:46 +0800
MIME-Version: 1.0
User-Agent: Mozilla/5.0 (Macintosh; Intel Mac OS X 10.15; rv:91.0)
 Gecko/20100101 Thunderbird/91.5.0
Subject: Re: [PATCH] virtio: unexport virtio_finalize_features
Content-Language: en-US
To:     "Michael S. Tsirkin" <mst@redhat.com>, linux-kernel@vger.kernel.org
Cc:     virtualization@lists.linux-foundation.org
References: <20220114195710.149933-1-mst@redhat.com>
From:   Jason Wang <jasowang@redhat.com>
In-Reply-To: <20220114195710.149933-1-mst@redhat.com>
Content-Type: text/plain; charset=UTF-8; format=flowed
Content-Transfer-Encoding: 8bit
Precedence: bulk


在 2022/1/15 上午3:57, Michael S. Tsirkin 写道:
> virtio_finalize_features is only used internally within virtio.
> No reason to export it.
>
> Signed-off-by: Michael S. Tsirkin <mst@redhat.com>


Acked-by: Jason Wang <jasowang@redhat.com>


> ---
>   drivers/virtio/virtio.c | 3 +--
>   include/linux/virtio.h  | 1 -
>   2 files changed, 1 insertion(+), 3 deletions(-)
>
> diff --git a/drivers/virtio/virtio.c b/drivers/virtio/virtio.c
> index 00ac9db792a4..d891b0a354b0 100644
> --- a/drivers/virtio/virtio.c
> +++ b/drivers/virtio/virtio.c
> @@ -166,7 +166,7 @@ void virtio_add_status(struct virtio_device *dev, unsigned int status)
>   }
>   EXPORT_SYMBOL_GPL(virtio_add_status);
>   
> -int virtio_finalize_features(struct virtio_device *dev)
> +static int virtio_finalize_features(struct virtio_device *dev)
>   {
>   	int ret = dev->config->finalize_features(dev);
>   	unsigned status;
> @@ -202,7 +202,6 @@ int virtio_finalize_features(struct virtio_device *dev)
>   	}
>   	return 0;
>   }
> -EXPORT_SYMBOL_GPL(virtio_finalize_features);
>   
>   void virtio_reset_device(struct virtio_device *dev)
>   {
> diff --git a/include/linux/virtio.h b/include/linux/virtio.h
> index 72292a62cd90..5464f398912a 100644
> --- a/include/linux/virtio.h
> +++ b/include/linux/virtio.h
> @@ -133,7 +133,6 @@ bool is_virtio_device(struct device *dev);
>   void virtio_break_device(struct virtio_device *dev);
>   
>   void virtio_config_changed(struct virtio_device *dev);
> -int virtio_finalize_features(struct virtio_device *dev);
>   #ifdef CONFIG_PM_SLEEP
>   int virtio_device_freeze(struct virtio_device *dev);
>   int virtio_device_restore(struct virtio_device *dev);