Received: by 2002:a05:6a10:af89:0:0:0:0 with SMTP id iu9csp2823647pxb; Mon, 17 Jan 2022 06:31:42 -0800 (PST) X-Google-Smtp-Source: ABdhPJwOjwospVOlU8SliaoPU8tqs5QGL4Hbpr+t67k4xGu2OY6gPtdQEibTD5QGRa+MRCieJkOR X-Received: by 2002:a05:6a00:b92:b0:4c1:e908:7485 with SMTP id g18-20020a056a000b9200b004c1e9087485mr20032181pfj.63.1642429901844; Mon, 17 Jan 2022 06:31:41 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1642429901; cv=none; d=google.com; s=arc-20160816; b=yP0Vq1FED0LhqEyIVg5Dic2oXs81zMnzecW9GcynMqdz3QGRIBJzDbIMCM7DfNb6mh pSL9Wc5qF4W10XSkjgWXEPvnIkjjfmzW4I3VgrNyfjDVPB9UKFJQ+GYSAGl1TGtN+DOT 0e5tzgJc2olrS+bQVAl7qzjvmGeteQh91Xnqrd/dP/P8J12Y3TnX4RVC7UwHeNTYzMz/ UdWd+d/9gW1pf+/ODHw20muOMPKOmcuXeLg0wEosayI7u07mNFTsAdFwkVREy7hhbQIB THpQkW07julIc2T+Ma5pv/wt4lk2WIG9w+uR9nWiwAsRL+RHyQIba79TjVE/7Oou4WzT iXow== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:content-transfer-encoding:mime-version :references:in-reply-to:message-id:date:subject:cc:to:from; bh=8vO0d5O2aopYk0XSR8kNKqYBit6ZuwqR3828CpOOHWw=; b=MdRvvqb8M9DVlvTMZtLwmG+eLNFW+ObKCM4zAXtltdU7v8la0yiTK6dvQXJ4uxPWD+ TzW60Ugfe7JxAqGZ+HibqygYwFKwgjadxIwfu3X2VuMv6CuSbfn6ZLjk+oHBF5z+EFXq bJik9gI2bIf8hjpoy8BADwpQ+O2wpTS66LwYuZlVwZTiwhz0FtZAqF1+SglCNtMc7JnU SQjDYh29MFsJW+j9X5Qy6ibj95eMAevUIJ0xhA6CONiuxKNZyilqge+TcxgLi6gJi/wY rZ2c6mNhHrWkEP6M8EcFeCtfm5yt0wKhGImdAh9ogcH0Hbs2iz816KEXQUmOZXWkZqJT Uhnw== ARC-Authentication-Results: i=1; mx.google.com; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=fail (p=NONE sp=NONE dis=NONE) header.from=alibaba.com Return-Path: Received: from vger.kernel.org (vger.kernel.org. [23.128.96.18]) by mx.google.com with ESMTP id 27si13680221pjd.93.2022.01.17.06.31.28; Mon, 17 Jan 2022 06:31:40 -0800 (PST) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18; Authentication-Results: mx.google.com; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=fail (p=NONE sp=NONE dis=NONE) header.from=alibaba.com Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S234632AbiAQGXs (ORCPT + 99 others); Mon, 17 Jan 2022 01:23:48 -0500 Received: from out30-44.freemail.mail.aliyun.com ([115.124.30.44]:35915 "EHLO out30-44.freemail.mail.aliyun.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S234410AbiAQGXs (ORCPT ); Mon, 17 Jan 2022 01:23:48 -0500 X-Alimail-AntiSpam: AC=PASS;BC=-1|-1;BR=01201311R581e4;CH=green;DM=||false|;DS=||;FP=0|-1|-1|-1|0|-1|-1|-1;HT=e01e01424;MF=yinan@linux.alibaba.com;NM=1;PH=DS;RN=4;SR=0;TI=SMTPD_---0V2-m4ej_1642400624; Received: from localhost.localdomain(mailfrom:yinan@linux.alibaba.com fp:SMTPD_---0V2-m4ej_1642400624) by smtp.aliyun-inc.com(127.0.0.1); Mon, 17 Jan 2022 14:23:45 +0800 From: Yinan Liu To: rostedt@goodmis.org, nathan@kernel.org Cc: mingo@kernel.org, linux-kernel@vger.kernel.org Subject: [PATCH 0/1] fix initialization problems Date: Mon, 17 Jan 2022 14:23:43 +0800 Message-Id: <20220117062344.15633-1-yinan@linux.alibaba.com> X-Mailer: git-send-email 2.30.1 (Apple Git-130) In-Reply-To: <20220115225920.0e5939aa@gandalf.local.home> References: <20220115225920.0e5939aa@gandalf.local.home> MIME-Version: 1.0 Content-Transfer-Encoding: 8bit Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Hi,steven and Nathan Thanks to Nathan, I realize that there are some problems with initialization. Initialization of pthreads and mstructs may fail or be skipped, in which case it is possible to use uninitialized values in "out" logic. I'm not sure if such an error would happen, but it's certainly safe to initialize it. I use mcount_sort_pthread as a global variable, which is consistent with orc_sort_pthread. And initialize the mstruct in function do_sort. Yinan Liu (1): script/sorttable: fix some initialization problems scripts/sorttable.h | 5 +++-- 1 file changed, 3 insertions(+), 2 deletions(-) -- 2.19.1.6.gb485710b