Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18;
Date:   Mon, 17 Jan 2022 12:11:44 +0530
From:   Viresh Kumar <viresh.kumar@linaro.org>
To:     =?utf-8?B?TsOtY29sYXMgRi4gUi4gQS4=?= Prado 
        <nfraprado@collabora.com>
Cc:     Shuah Khan <shuah@kernel.org>,
        "Rafael J. Wysocki" <rafael@kernel.org>, linux-pm@vger.kernel.org,
        linux-kselftest@vger.kernel.org, linux-kernel@vger.kernel.org,
        kernel@collabora.com
Subject: Re: [PATCH] selftests: cpufreq: Write test output to stdout as well
Message-ID: <20220117064144.bovae2r4wnln7g7k@vireshk-i7>
References: <20220114232126.92043-1-nfraprado@collabora.com>
MIME-Version: 1.0
Content-Type: text/plain; charset=iso-8859-1
Content-Disposition: inline
Content-Transfer-Encoding: 8bit
In-Reply-To: <20220114232126.92043-1-nfraprado@collabora.com>
User-Agent: NeoMutt/20180716-391-311a52
Precedence: bulk

On 14-01-22, 18:21, N?colas F. R. A. Prado wrote:
> Use 'tee' to send the test output to stdout in addition to the current
> output file. This makes the output easier to handle in automated test
> systems and is superior to only later dumping the output file contents
> to stdout, since this way the test output can be interleaved with other
> log messages, like from the kernel, so that chronology is preserved,
> making it easier to detect issues.
> 
> Signed-off-by: N?colas F. R. A. Prado <nfraprado@collabora.com>
> ---
>  tools/testing/selftests/cpufreq/main.sh | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/tools/testing/selftests/cpufreq/main.sh b/tools/testing/selftests/cpufreq/main.sh
> index 31f8c9a76c5f..60ce18ed0666 100755
> --- a/tools/testing/selftests/cpufreq/main.sh
> +++ b/tools/testing/selftests/cpufreq/main.sh
> @@ -194,5 +194,5 @@ prerequisite
>  
>  # Run requested functions
>  clear_dumps $OUTFILE
> -do_test >> $OUTFILE.txt
> +do_test | tee -a $OUTFILE.txt
>  dmesg_dumps $OUTFILE

Acked-by: Viresh Kumar <viresh.kumar@linaro.org>

-- 
viresh