Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18;
Message-ID: <cf821d43-6f9c-f05e-c479-7970aeda9986@wolfvision.net>
Date:   Mon, 17 Jan 2022 07:54:23 +0100
User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:91.0) Gecko/20100101
 Thunderbird/91.4.1
Subject: Re: [PATCH v1 1/3] dts64: rk3568: drop pclk_xpcs from gmac0
Content-Language: en-US
To:     Frank Wunderlich <linux@fw-web.de>,
        linux-rockchip@lists.infradead.org
Cc:     Rob Herring <robh+dt@kernel.org>, Heiko Stuebner <heiko@sntech.de>,
        Peter Geis <pgwipeout@gmail.com>,
        Johan Jonker <jbx6244@gmail.com>, devicetree@vger.kernel.org,
        linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org
References: <20220116124911.65203-1-linux@fw-web.de>
 <20220116124911.65203-2-linux@fw-web.de>
From:   Michael Riesch <michael.riesch@wolfvision.net>
In-Reply-To: <20220116124911.65203-2-linux@fw-web.de>
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: 7bit
MIME-Version: 1.0
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?NHpaU0lIbXhobXRVaUVUdTBhV0ovKy81dWFDTFJoaVYraWhzNUR2U2x5Q0xM?=
 =?utf-8?B?cm9TTHRaUmFyNU5ObkErUzNmUkVwRHFVWW5WTkpwQjZ1STdCT1ltNitFQ0x6?=
 =?utf-8?B?OUJHMmlHbTB1dm01M3VzOURkMlZCMkE3a05mOUhhTHFIV3N2UjJxbmdtQk9l?=
 =?utf-8?B?NnY0bExid0t4WWIybWdwTmVlcXZaTlNibkxBb3VKOW0xVGtUS2VWOXFmNmZL?=
 =?utf-8?B?SFdvWTZWWHRHSkZnaUlFYUV4SzNwVlJpZDZXOXN3MlhlS1VuTkcvZk0xa3Iz?=
 =?utf-8?B?UUlYb0hqQjI5Z2ZCb3BMVWdkMnZsTHFlbGl3RnByMk9kUlh1MnpEY1ZFTjVW?=
 =?utf-8?B?aVRZZU5ZckFSRUVmT3pkYnl1bUJmL0tialFPVW9JZXJUMnBOeWJBSG1BSDBX?=
 =?utf-8?B?S3Z4b1pUdVF0emNpQUgzeVFiRFJiWTlxSnVSR2Y5TkJaUHh0MmthZW9VM0xl?=
 =?utf-8?B?Z1JkMUg1Z3R1bHdBclA3aU5pOFJQVkJHNjZPYStqV2FhZzR5Rzd4ekNzTUZG?=
 =?utf-8?B?T1lEUExUclBUOFpnVG5RblVyYy9UVjhsTWdrVEcwWG5Ka3pnMWVPandMeElp?=
 =?utf-8?B?L09CQTZWdk90WTAydTJla0lLOHBUM2ZCS1lOcXhMTitmWU9tZWxaSGhyNUUx?=
 =?utf-8?B?Zjl1NnRTclBFVnFMWG1UN0dZZUsyZzVIb3VSVFNaMnBReC92bkh6bWx3bnpF?=
 =?utf-8?B?TWlVM1c1cGpCR2VZenFaVzAwR2pBd0E4SklzTVUvdTNpbHhZUnlTZzBST3h1?=
 =?utf-8?B?dkpPMTBmbUp6bXNBR2JiVGZLVGN5dFZzYXd5SGI2d1lVYTJvdjJ2Q1dIQk15?=
 =?utf-8?B?dDR2b21QSG1sdXBPeWl5QXFETWorZVRxQ2wvWDU0VXZJTlRTUUk5UkY3dEhk?=
 =?utf-8?B?dllxNlRaUkw4dUxZRC9ucGY3ZGlNcGRBR09xd3NMT2tZVTU3REp6T1QxTWw3?=
 =?utf-8?B?QUNtSTV1Nml5d3pzMXJyZmFrbkVrTHV0cmVqTTRsSDdJSWt3RTFHYUY3bk9w?=
 =?utf-8?B?ajYwMzluZ1E2d21FSGJrMy9HakJjWkZnT3hkR2hxZDNOQXlBL0ptSm56VjdY?=
 =?utf-8?B?dTRDNVgvQmluek5qWFFabHh5ajN1SnpROU9TblAyQ2hSN2o3LzdYVlZtMTRE?=
 =?utf-8?B?Nzk4TWQ0cXhDZXhzaU1EY3RpbnBjVnpwQXlZTnVQbFUxOG1ING01ZnlpdUVu?=
 =?utf-8?B?VWY5ZjRUMXB0amlNbzJweHlIcjRKa3Y1N3hwSElEdXNHU1hYRTlNVkxIVjJV?=
 =?utf-8?B?VG1NRndSelNrRWtNRjhKWWhvTHdiL2JoRE41d3RQTHNIN0pNZ0JBYTNQRUdD?=
 =?utf-8?B?b1RpNUJnRjRJY3JkalU1bXRxT01WNHFuR0ZZNGtYcUY4ZkYrSUJOWnhiRXI4?=
 =?utf-8?B?eTl2RzhFVmhQVkhMb0tqZXJhYXBHMVgrKzV2ZGZMOUtMdHE0eURISlBKRjNX?=
 =?utf-8?B?UFV3NXlWZTdVaDlXOXF2NmZFaGVKUkNCLzBNb0M4ZWZaR3Z5M2tudklJaFFD?=
 =?utf-8?B?V2tZSm1rZ1FWc3JHYkg2MVZRMkZ4d0F0WHE3RGVRWVd5eUUwTVlYM093bElW?=
 =?utf-8?B?cVJSUXFycXE1L3J3bmNoWDRkejVCTWRFQUd3TENuTVNjNzh1S0RyVUJkc256?=
 =?utf-8?B?TnFpOFN3blpKNDdMMkVtL3E1NUs4Tng3SVVEcUgzV1BRWWIwUmxRdVFuYTBo?=
 =?utf-8?B?SGh2RUlDWlpLbXZlT0lEcE11Nnpiamt0bUlLcXRPQTcyejIxYjF5cmtheW1n?=
 =?utf-8?B?K1JORXNYVDRIZnpMS0RWcklEU0RTRmtjc1d0TGRZWnAyRldybzU5eUZIb1RD?=
 =?utf-8?B?czdQYkZtNVM3US9vMXdSNUtJSG43eWwvdkZmS2lGMnA4NmpiazRtbWs1Vnl3?=
 =?utf-8?B?RHgxa3lEODhNL3RMTGQ3UDBGWTM3OHRkSkJMTUxyWmdGQkVqanprSEs1ZjFx?=
 =?utf-8?B?MnBlRUFOZ3VXdHhhZWJHUUt6TUJaSmQzbEpCT2Q5YjBadk9VS3FrZ3lmSzFh?=
 =?utf-8?B?SDIrTXRyT01zZkU1MmlqRGZrd2VDUmJpU0Y4WVl1VDUwU21TM3o5VmtUaWo3?=
 =?utf-8?B?SWwrRGlRaEd2OThNdndsWk50cXNwZExUc1AySEh3WjBBcmxhU1ZJM0xNRmFV?=
 =?utf-8?B?OHhDSDM5U0o1d1UvZzNTK3Q2MVpxQVdyd3ZkZitnNTlTVUVocnUzSVFpZGpx?=
 =?utf-8?B?RDhYS01Ja2NUSkI2NDJVeTh3S3U0MURNenJjaXJ6K25iZllxZ1FuZEdrZ2ZC?=
 =?utf-8?B?SEk5WEpURDNWMkJMRzBCdzRiN096aGF1Wjl1bE1FcWMrWVRGS2c2SXZZWlk2?=
 =?utf-8?B?eVIvTWhROG5VVzlxYW5sWnZFQTA2aXd3ZTV5c0NQaG11OFU5RjZtM094K080?=
 =?utf-8?Q?cKiVZ94EpBrKCULY=3D?=
X-OriginatorOrg: wolfvision.net
X-MS-Exchange-CrossTenant-Network-Message-Id: aa1b3caf-cb42-43cc-dbca-08d9d986330f
X-MS-Exchange-CrossTenant-AuthSource: HE1PR0802MB2426.eurprd08.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 17 Jan 2022 06:54:25.7345
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: e94ec9da-9183-471e-83b3-51baa8eb804f
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: Xbd/aPXQSBOX0rM2GeajilQC0KGCJXqsoxV4ZOPiA4MzzTW2VvwF1FUVOKxkcfdKuwAM9Bwog+yplqCtxW0XskadxaxCckNRxZM4+sMACOA=
X-MS-Exchange-Transport-CrossTenantHeadersStamped: HE1PR08MB2907
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

Hello Frank,

On 1/16/22 13:49, Frank Wunderlich wrote:
> From: Frank Wunderlich <frank-w@public-files.de>
> 
> pclk_xpcs is not supported and breaks dtbs_check, so remove it
> 
> following warnings occour, and many more
> 
> rk3568-evb1-v10.dt.yaml: ethernet@fe2a0000: clocks:
>     [[15, 386], [15, 389], [15, 389], [15, 184], [15, 180], [15, 181],
>     [15, 389], [15, 185], [15, 172]] is too long
> 	From schema: Documentation/devicetree/bindings/net/snps,dwmac.yaml
> rk3568-evb1-v10.dt.yaml: ethernet@fe2a0000: clock-names:
>     ['stmmaceth', 'mac_clk_rx', 'mac_clk_tx', 'clk_mac_refout', 'aclk_mac',
>     'pclk_mac', 'clk_mac_speed', 'ptp_ref', 'pclk_xpcs'] is too long
> 	From schema: Documentation/devicetree/bindings/net/snps,dwmac.yaml
> 
> after removing the clock the other warnings are also gone.
> 
> Co-developed-by: Peter Geis <pgwipeout@gmail.com>
> Signed-off-by: Peter Geis <pgwipeout@gmail.com>
> Signed-off-by: Frank Wunderlich <frank-w@public-files.de>
> ---
>  arch/arm64/boot/dts/rockchip/rk3568.dtsi | 6 ++----
>  1 file changed, 2 insertions(+), 4 deletions(-)
> 
> diff --git a/arch/arm64/boot/dts/rockchip/rk3568.dtsi b/arch/arm64/boot/dts/rockchip/rk3568.dtsi
> index 2fd313a295f8..d91df1cde736 100644
> --- a/arch/arm64/boot/dts/rockchip/rk3568.dtsi
> +++ b/arch/arm64/boot/dts/rockchip/rk3568.dtsi
> @@ -32,13 +32,11 @@ gmac0: ethernet@fe2a0000 {
>  		clocks = <&cru SCLK_GMAC0>, <&cru SCLK_GMAC0_RX_TX>,
>  			 <&cru SCLK_GMAC0_RX_TX>, <&cru CLK_MAC0_REFOUT>,
>  			 <&cru ACLK_GMAC0>, <&cru PCLK_GMAC0>,
> -			 <&cru SCLK_GMAC0_RX_TX>, <&cru CLK_GMAC0_PTP_REF>,
> -			 <&cru PCLK_XPCS>;
> +			 <&cru SCLK_GMAC0_RX_TX>, <&cru CLK_GMAC0_PTP_REF>;
>  		clock-names = "stmmaceth", "mac_clk_rx",
>  			      "mac_clk_tx", "clk_mac_refout",
>  			      "aclk_mac", "pclk_mac",
> -			      "clk_mac_speed", "ptp_ref",
> -			      "pclk_xpcs";
> +			      "clk_mac_speed", "ptp_ref";
>  		resets = <&cru SRST_A_GMAC0>;
>  		reset-names = "stmmaceth";
>  		rockchip,grf = <&grf>;

This has been on my TODO list for a while, but I never found the time to
submit this cleanup. As far as I am concerned:

Acked-by: Michael Riesch <michael.riesch@wolfvision.net>

Thanks and best regards,
Michael