Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18;
From:   Oleksandr Natalenko <oleksandr@natalenko.name>
To:     Eugene Shalygin <eugene.shalygin@gmail.com>
Cc:     andy.shevchenko@gmail.com, pauk.denis@gmail.com,
        Jean Delvare <jdelvare@suse.com>,
        Guenter Roeck <linux@roeck-us.net>,
        linux-kernel@vger.kernel.org, linux-hwmon@vger.kernel.org
Subject: Re: [ASUS EC Sensors V6 v6 0/3]
Date:   Mon, 17 Jan 2022 08:21:55 +0100
Message-ID: <2613447.mvXUDI8C0e@natalenko.name>
In-Reply-To: <20220116201843.2301438-1-eugene.shalygin@gmail.com>
References: <20220116201843.2301438-1-eugene.shalygin@gmail.com>
MIME-Version: 1.0
Content-Transfer-Encoding: quoted-printable
Content-Type: text/plain; charset="UTF-8"
Precedence: bulk

Hello.

On ned=C4=9Ble 16. ledna 2022 21:18:38 CET Eugene Shalygin wrote:
> This patchset replaces the HWMON asus_wmi_ec_sensors driver with
> an implementation that does not use WMI but queries the embedded
> controller directly.
>=20
> That provides two enhancements: sensor reading became quicker (on some
> systems or kernel configuration it took almost a full second to read
> all the sensors, that transfers less than 15 bytes of data), the driver
> became more fexible. The driver now relies on ACPI mutex to lock access
> to the EC, in the same way as the WMI DSDT code does.
>=20
> Changes in v6:
>  - Fixed hwmon device name replacing dashes with underscores.
>  - Removed module verion.
>  - Fixed condition for asus_wmi_ec_Sensors in KBuild.

=46or the series:

Tested-by: Oleksandr Natalenko <oleksandr@natalenko.name>

> Changes in v5:
>  - Place the sensors bitset directly into the driver_data field of the
>          dmi_system_id struct.
>  - Replace doc comments with regular ones.
>=20
> Changes in v4:
>  - Deprecate the wmi driver rather than removing it.
>=20
> Changes in v3:
>  - Remove BIOS version checks and BIOS version dependent mutex path.
>=20
> Changes in v2:
>  - Replace sensor flags enum with bitset
>  - Replace module init/probe functions with module_platform_driver_probe
>    and ask the platform drivers framework to load the driver when ACPI
>    EC is found (ACPI ID "PNP0C09").
>  - Extend board data with BIOS version attribute for the mutex path to be
>    BIOS version dependent.
>  - Add module parameter to override the mutex path.
>=20
> Eugene Shalygin (3):
>   hwmon: (asus-ec-sensors) add driver for ASUS EC
>   hwmon: (asus-ec-sensors) update documentation
>   hwmon: deprecate asis_wmi_ec_sensors driver
>=20
>  Documentation/hwmon/asus_ec_sensors.rst     |  51 ++
>  Documentation/hwmon/asus_wmi_ec_sensors.rst |  38 --
>  MAINTAINERS                                 |   6 +
>  drivers/hwmon/Kconfig                       |  16 +-
>  drivers/hwmon/Makefile                      |   1 +
>  drivers/hwmon/asus-ec-sensors.c             | 690 ++++++++++++++++++++
>  6 files changed, 763 insertions(+), 39 deletions(-)
>  create mode 100644 Documentation/hwmon/asus_ec_sensors.rst
>  delete mode 100644 Documentation/hwmon/asus_wmi_ec_sensors.rst
>  create mode 100644 drivers/hwmon/asus-ec-sensors.c

Thanks.

=2D-=20
Oleksandr Natalenko (post-factum)