Received: by 2002:a05:6a10:af89:0:0:0:0 with SMTP id iu9csp2901888pxb; Mon, 17 Jan 2022 07:58:36 -0800 (PST) X-Google-Smtp-Source: ABdhPJxtfqP84T14YPeCQENjz1v4RvQ0XuocfM5DriBp/rMaSwtI+EQvTytB8S3L3405Xc0amPii X-Received: by 2002:a17:90b:4b8c:: with SMTP id lr12mr19620146pjb.32.1642435116795; Mon, 17 Jan 2022 07:58:36 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1642435116; cv=none; d=google.com; s=arc-20160816; b=fg84ZnLOY2+e+UUzj1Hnp8/0M1mHwRHvUvTtfZgSsqj/JmS8qdMfje/WLX1xT1iaLE E1kWPWLjCcvngS9BPyHfXz5TeUZIZBxCPU62jC1rTpm//MAueHBxPqoQ4SYkemaL+r5Y PmS9XVIIOrBPGX8KUBApUNH0pGOaExd6YQrDY3ofKkKtZfzsrH++h7Oqv0zc3sUryg7c ah8+RA7QdV2iv0Un8d/d+2w+LG4VJEeh+Skws3H9r8yO2rIH7CEl2+pmucT+F8PJ4uqX LBsTH/CsqkJapood2jmT0PbqLe4ci5mM4zcHaU94tkDa4UQH3bIrlK/f8G8REzYS30fU SGng== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:cc:to:subject:message-id:date:from:in-reply-to :references:mime-version:dkim-signature; bh=Pk9g25WRpFPs48r7zm5sUpEVslQaRknFfz4t/FLVEiU=; b=UMozyjquwsnBbLoP5F3tJ2pVN4B1OZen/I1LkgCnrQLJQkdtAQbs91hYDLyrQSCCXt GshW22SdxAWtWmfgPxkNGygF3wFHhkQai+NP47acAMJKHmtae0N9BBfe/PvlWS0eDYTt 7/vbqpijlBVKdLYWBxgtRSqLIIIr2K9pJbpXTSpAF7Cs6vJv2MA0zFcBHFpUCft/92bT DSFLOGWfTu7FoxFWc+iZ0PVGmvC8lUTIHGqNwZGXUdSEMuZ+W4IlqV7AKm2CCYLdazwz idnFT340UIAbJ6r6SqyTp30hEH3YqjB3gQ4tQRiEW4wYHd+FxVszyZZecOsQeSTvpO+V aIRA== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@gmail.com header.s=20210112 header.b=RaGTC0aQ; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=QUARANTINE dis=NONE) header.from=gmail.com Return-Path: Received: from vger.kernel.org (vger.kernel.org. [23.128.96.18]) by mx.google.com with ESMTP id p23si15090983plr.268.2022.01.17.07.58.25; Mon, 17 Jan 2022 07:58:36 -0800 (PST) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18; Authentication-Results: mx.google.com; dkim=pass header.i=@gmail.com header.s=20210112 header.b=RaGTC0aQ; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=QUARANTINE dis=NONE) header.from=gmail.com Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S237318AbiAQHeb (ORCPT + 99 others); Mon, 17 Jan 2022 02:34:31 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:55686 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S232208AbiAQHea (ORCPT ); Mon, 17 Jan 2022 02:34:30 -0500 Received: from mail-pj1-x1035.google.com (mail-pj1-x1035.google.com [IPv6:2607:f8b0:4864:20::1035]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 837D9C061574; Sun, 16 Jan 2022 23:34:30 -0800 (PST) Received: by mail-pj1-x1035.google.com with SMTP id o3so19874208pjs.1; Sun, 16 Jan 2022 23:34:30 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=Pk9g25WRpFPs48r7zm5sUpEVslQaRknFfz4t/FLVEiU=; b=RaGTC0aQ3uz4reKKahJfMLLELsVCu2ayEhM/j6nlOodNLeNB5a/XNVlAD4+KhlbcO+ M0Dvs0si/7pissOORAeiEKmGPo+QNS2bv8c4B4LMGewDMU1Db4ZhbWwLbe+MNvGVRp+g CIdvcXmNpbgDbHEr1iAAj1mMgpny9mz7LgSqHbAsLdg3uUKO0SybWgGAJLQwFKy5H2yh VKgPrGLZcIaQSLqhvM4XEzVoGBBUsdmxikuzDJu37j0rvK3oN7JaU/hU8GxRDPO7vdGN 9Padw/MmOeWK/BmCpkcDEEHj/6TEPfxtPLvVigtj9iSwE9WVKxozKmwkewr+BdS8b07L 1A/Q== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=Pk9g25WRpFPs48r7zm5sUpEVslQaRknFfz4t/FLVEiU=; b=IMP/D6TRpvf4V2HvVyQbXxnwz/3GOkd4I9DY4gY/0gZ05lT1fzDfwIL2TVCBYLRXNU EyM47QAGlT/DZ3+WKvkXAQemPaDJEUM0PdlgaBZAuQzGZsXv8XlK+3bYc5jvNFOOh5GT yUXOopxuDHhQXDGGDV3wSVoNVO/4IZrKchAhI8w+P7YqjNolBJUV+yfqQfJ7wsUB3164 MVSXvHWsbpPAj7qqK707Yfwnpr7OThUYTI4k1O4//Bb7LPmdzQ+FQIEFxnkF0U4fDdGA 9zW0nwsMrbMcyIZtQ5tB+ocR1xrxlayePzV4+7TyqxDUCr+DS1Ds9z0zuTCU9k60RR05 sRPw== X-Gm-Message-State: AOAM530g9lWnUGzeTN+s4G0jssfi2D++8xhjVeQNaZ8MMt8LYP+MYLW1 gRRsu2LcurmD4Ajd1Z1XGEJSDJ47KJgtdoiEXbE= X-Received: by 2002:a17:902:bcc1:b0:149:a13f:af62 with SMTP id o1-20020a170902bcc100b00149a13faf62mr21072936pls.147.1642404869850; Sun, 16 Jan 2022 23:34:29 -0800 (PST) MIME-Version: 1.0 References: <20211222132332.7817-1-vimal.agrawal@sophos.com> In-Reply-To: From: Vimal Agrawal Date: Mon, 17 Jan 2022 13:04:18 +0530 Message-ID: Subject: Re: [PATCH v2] kernel/module.c: heuristic enhancement when INSTALL_MOD_STRIP= "--strip-unneeded" is used To: Luis Chamberlain Cc: Christoph Hellwig , Vimal Agrawal , Masahiro Yamada , Michal Marek , Nick Desaulniers , Jan Beulich , Jeff Mahoney , Sam Ravnborg , linux-kbuild@vger.kernel.org, jeyu@kernel.org, linux-kernel@vger.kernel.org Content-Type: text/plain; charset="UTF-8" Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Hi Luis, On Thu, Jan 13, 2022 at 8:53 PM Luis Chamberlain wrote: > > You mean it is safe for that case too? If so can you add this to the > commit log as well? > yes. updated in the commit log. > Can you also use the modules-next tree? I'll still have to test this. > > [0] https://git.kernel.org/pub/scm/linux/kernel/git/mcgrof/linux.git/ branch modules-next > I am not sure of modules-next but I created the patch (v3) on latest linux-next (next-20220116). Hope it suffices. Sent patch v3 already. Vimal