Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18;
MIME-Version: 1.0
References: <20220113082918.2279347-1-hsinyi@chromium.org>
In-Reply-To: <20220113082918.2279347-1-hsinyi@chromium.org>
From:   Robert Foss <robert.foss@linaro.org>
Date:   Mon, 17 Jan 2022 10:39:48 +0100
Message-ID: <CAG3jFytu8VpopWYHvGiSYRW2bcX-wHSoYgQ42u84WBQKGrnfZQ@mail.gmail.com>
Subject: Re: [PATCH v3 1/3] drm/bridge: anx7625: Convert to use devm_kzalloc
To:     Hsin-Yi Wang <hsinyi@chromium.org>
Cc:     Rob Herring <robh+dt@kernel.org>, Xin Ji <xji@analogixsemi.com>,
        David Airlie <airlied@linux.ie>,
        Daniel Vetter <daniel@ffwll.ch>,
        Laurent Pinchart <laurent.pinchart@ideasonboard.com>,
        dri-devel@lists.freedesktop.org, devicetree@vger.kernel.org,
        linux-kernel@vger.kernel.org, Andrzej Hajda <a.hajda@samsung.com>,
        Neil Armstrong <narmstrong@baylibre.com>,
        Jonas Karlman <jonas@kwiboo.se>,
        Jernej Skrabec <jernej.skrabec@gmail.com>,
        Sam Ravnborg <sam@ravnborg.org>,
        Maxime Ripard <maxime@cerno.tech>
Content-Type: text/plain; charset="UTF-8"
Precedence: bulk

Hey Hsin-Yi,


On Thu, 13 Jan 2022 at 09:29, Hsin-Yi Wang <hsinyi@chromium.org> wrote:
>
> Use devm_kzalloc instead of kzalloc and drop kfree(). Let the memory
> handled by driver detach.
>
> Signed-off-by: Hsin-Yi Wang <hsinyi@chromium.org>
> Reviewed-by: Xin Ji <xji@analogixsemi.com>
> ---
> v2->v3: remove kfree() in anx7625_i2c_remove().
> ---
>  drivers/gpu/drm/bridge/analogix/anx7625.c | 10 +++-------
>  1 file changed, 3 insertions(+), 7 deletions(-)
>
> diff --git a/drivers/gpu/drm/bridge/analogix/anx7625.c b/drivers/gpu/drm/bridge/analogix/anx7625.c
> index 0b858c78abe8b6..d3661c78770a8f 100644
> --- a/drivers/gpu/drm/bridge/analogix/anx7625.c
> +++ b/drivers/gpu/drm/bridge/analogix/anx7625.c
> @@ -2515,7 +2515,7 @@ static int anx7625_i2c_probe(struct i2c_client *client,
>                 return -ENODEV;
>         }
>
> -       platform = kzalloc(sizeof(*platform), GFP_KERNEL);
> +       platform = devm_kzalloc(dev, sizeof(*platform), GFP_KERNEL);
>         if (!platform) {
>                 DRM_DEV_ERROR(dev, "fail to allocate driver data\n");
>                 return -ENOMEM;
> @@ -2527,7 +2527,7 @@ static int anx7625_i2c_probe(struct i2c_client *client,
>         if (ret) {
>                 if (ret != -EPROBE_DEFER)
>                         DRM_DEV_ERROR(dev, "fail to parse DT : %d\n", ret);
> -               goto free_platform;
> +               return ret;
>         }
>
>         platform->client = client;
> @@ -2552,7 +2552,7 @@ static int anx7625_i2c_probe(struct i2c_client *client,
>         if (!platform->hdcp_workqueue) {
>                 dev_err(dev, "fail to create work queue\n");
>                 ret = -ENOMEM;
> -               goto free_platform;
> +               return ret;
>         }
>
>         platform->pdata.intp_irq = client->irq;
> @@ -2637,9 +2637,6 @@ static int anx7625_i2c_probe(struct i2c_client *client,
>         if (platform->hdcp_workqueue)
>                 destroy_workqueue(platform->hdcp_workqueue);
>
> -free_platform:
> -       kfree(platform);
> -
>         return ret;
>  }
>
> @@ -2666,7 +2663,6 @@ static int anx7625_i2c_remove(struct i2c_client *client)
>         if (platform->pdata.audio_en)
>                 anx7625_unregister_audio(platform);
>
> -       kfree(platform);
>         return 0;
>  }
>

I just had a look at applying this series, but it fails to apply on
drm-misc-next today.

Could you send a v4 that applies cleanly, and I'll try to be quick
about applying it.


Rob.