Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18;
From:   "Alim Akhtar" <alim.akhtar@samsung.com>
To:     "'Jonathan Cameron'" <Jonathan.Cameron@Huawei.com>,
        "'Krzysztof Kozlowski'" <krzysztof.kozlowski@canonical.com>
Cc:     <linux-arm-kernel@lists.infradead.org>,
        <linux-kernel@vger.kernel.org>, <soc@kernel.org>,
        <linux-clk@vger.kernel.org>, <devicetree@vger.kernel.org>,
        <olof@lixom.net>, <linus.walleij@linaro.org>,
        <catalin.marinas@arm.com>, <robh+dt@kernel.org>,
        <s.nawrocki@samsung.com>, <linux-samsung-soc@vger.kernel.org>,
        <pankaj.dubey@samsung.com>, <linux-fsd@tesla.com>,
        "'Tamseel Shams'" <m.shams@samsung.com>
In-Reply-To: <20220117094728.000051b8@Huawei.com>
Subject: RE: [PATCH 20/23] dt-bindings: iio: adc: exynos-adc: Add ADC-V3
 variant
Date:   Mon, 17 Jan 2022 18:12:52 +0530
Message-ID: <00b301d80b9f$c06304d0$41290e70$@samsung.com>
MIME-Version: 1.0
Content-Transfer-Encoding: 7bit
Thread-Index: AQKuNmZ/+9PJHbdzezyQqzGEXzr0sgIwyL4qAholePgCN4X3HAEeB8w4qn3OlMA=
Content-Language: en-us
Content-Type: text/plain; charset="utf-8"
CMS-TYPE: 105P
DLP-Filter: Pass
References: <20220113121143.22280-1-alim.akhtar@samsung.com>
        <CGME20220113122447epcas5p266d44c8df143229d22dfa700c285a786@epcas5p2.samsung.com>
        <20220113121143.22280-21-alim.akhtar@samsung.com>
        <75ae8b8c-e416-5007-b995-f1317ef207d4@canonical.com>
        <20220117094728.000051b8@Huawei.com>
Precedence: bulk


>-----Original Message-----
>From: Jonathan Cameron [mailto:Jonathan.Cameron@Huawei.com]
>Sent: Monday, January 17, 2022 3:17 PM
>To: Krzysztof Kozlowski <krzysztof.kozlowski@canonical.com>
>Cc: Alim Akhtar <alim.akhtar@samsung.com>; linux-arm-
>kernel@lists.infradead.org; linux-kernel@vger.kernel.org; soc@kernel.org;
>linux-clk@vger.kernel.org; devicetree@vger.kernel.org; olof@lixom.net;
>linus.walleij@linaro.org; catalin.marinas@arm.com; robh+dt@kernel.org;
>s.nawrocki@samsung.com; linux-samsung-soc@vger.kernel.org;
>pankaj.dubey@samsung.com; linux-fsd@tesla.com; Tamseel Shams
><m.shams@samsung.com>
>Subject: Re: [PATCH 20/23] dt-bindings: iio: adc: exynos-adc: Add ADC-V3
>variant
>
>On Thu, 13 Jan 2022 14:32:12 +0100
>Krzysztof Kozlowski <krzysztof.kozlowski@canonical.com> wrote:
>
>> On 13/01/2022 13:11, Alim Akhtar wrote:
>> > This patch adds a new compatible string for exynos's ADC-V3 variant.
>> >
>> > Cc: linux-fsd@tesla.com
>> > Signed-off-by: Tamseel Shams <m.shams@samsung.com>
>> > Signed-off-by: Alim Akhtar <alim.akhtar@samsung.com>
>
>Please cc linux-iio@vger.kernel.org for next version...
>
Noted, will separate out these patches from the original series and send.
Thanks

>> > ---
>> >  .../devicetree/bindings/iio/adc/samsung,exynos-adc.yaml          | 1 +
>> >  1 file changed, 1 insertion(+)
>> >
>> > diff --git
>> > a/Documentation/devicetree/bindings/iio/adc/samsung,exynos-adc.yaml
>> > b/Documentation/devicetree/bindings/iio/adc/samsung,exynos-adc.yaml
>> > index 81c87295912c..9303053759ca 100644
>> > ---
>> > a/Documentation/devicetree/bindings/iio/adc/samsung,exynos-adc.yaml
>> > +++ b/Documentation/devicetree/bindings/iio/adc/samsung,exynos-
>adc.y
>> > +++ aml
>> > @@ -14,6 +14,7 @@ properties:
>> >      enum:
>> >        - samsung,exynos-adc-v1                 # Exynos5250
>> >        - samsung,exynos-adc-v2
>> > +      - samsung,exynos-adc-v3
>>
>> Please use SoC-specific compatible. IP block versions are tricky because:
>> 1. Documentation/datasheet mentioning which SoC has which block
>> version are not public.
>> 2. Neither are public the datasheets for ADC blocks.
>> 3. The versioning of IP blocks can be inaccurate.
>>
>>
>> Best regards,
>> Krzysztof
>>
>> _______________________________________________
>> linux-arm-kernel mailing list
>> linux-arm-kernel@lists.infradead.org
>> https://protect2.fireeye.com/v1/url?k=9dd88c77-fca326ff-9dd90738-74fe4
>> 860018a-343cb1b0388f1560&q=1&e=61045889-dd66-417f-b142-
>9e85b39f1676&u=
>> http%3A%2F%2Flists.infradead.org%2Fmailman%2Flistinfo%2Flinux-arm-
>kern
>> el