Received: by 2002:a05:6a10:af89:0:0:0:0 with SMTP id iu9csp3354914pxb; Mon, 17 Jan 2022 18:25:31 -0800 (PST) X-Google-Smtp-Source: ABdhPJw5pqBe3k6Y/rtCn/87YxGgY++PP4rTsemRr+n80YZMLS5ucKLcZNBWBO1uIX7Ukyr0oU0l X-Received: by 2002:a17:90a:1f82:: with SMTP id x2mr1853089pja.87.1642472731566; Mon, 17 Jan 2022 18:25:31 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1642472731; cv=none; d=google.com; s=arc-20160816; b=e3EnllbuFrigeEDxACUQkHqcIrZlHXfVamEYYiUiU81aWO1c6Zsaw843vONckPggFn w5IjhWa0VI7mkIKKcJqiThKMn3CwVV3Go6jSZfukEMjA98zzKaO4TCEmmXmqwsOojiXr B1hD8SRXDVvskRIgkFLKQ3EfnzEqYSF518ydVqBydYlqod6IaRafYWZEiwX+NRCQVke9 qhjQ0RqhUsx1+MdkubDqYBJ2F7Ji60B7w3FuLCSLfaQh7SRSNWEY13pz8IhrzWD1xeCz 6OMGtvxpWFbFNEOjibnjQCxn9h/blLlDl/TORVJBjiLmIJn288JOZAy9YRyqOmpcc4h3 +6cA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:cc:to:subject:message-id:date:from:in-reply-to :references:mime-version:dkim-signature; bh=JIRLlbVVis5u8s0hBrGhQwKFxQSA77iBfFr7Eu67/zE=; b=elkYchKfH8IvPfNA7YFLxKMMZ+h0b9S80McElbHTQLeCUxyUx6Bw4+dlQeZYn5M31G lPa4cqTpGSGVpClviWS1rOCQufZAtoUq0vob0tZXVJkOnFbpYJ5bRipi17D59Oy1cwvm 68BLL+FKmfkgLzhFLJKtlgll9UsvDLXNfH18IQbki4o24ZwvDgBIjakctWElwTgcOnJS qssbijA41N2frq9oAZlqjAbivLvBNkAnTIVuLUdXO5EnwEb2Mgoaqs9UscKuNM/wntgo 4Tc4m7DfOweGwHPmi4poMwdj+SIrijPbUkPv8U6LM6gsoEwkFRFnwj5SAE4UwDEhEwPr eQuw== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@zx2c4.com header.s=20210105 header.b=jxTyPJoA; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=zx2c4.com Return-Path: Received: from vger.kernel.org (vger.kernel.org. [23.128.96.18]) by mx.google.com with ESMTP id z188si13651493pfb.269.2022.01.17.18.25.19; Mon, 17 Jan 2022 18:25:31 -0800 (PST) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18; Authentication-Results: mx.google.com; dkim=pass header.i=@zx2c4.com header.s=20210105 header.b=jxTyPJoA; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=zx2c4.com Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S230055AbiAQMrw (ORCPT + 99 others); Mon, 17 Jan 2022 07:47:52 -0500 Received: from dfw.source.kernel.org ([139.178.84.217]:58220 "EHLO dfw.source.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229983AbiAQMrv (ORCPT ); Mon, 17 Jan 2022 07:47:51 -0500 Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by dfw.source.kernel.org (Postfix) with ESMTPS id 62710611C6 for ; Mon, 17 Jan 2022 12:47:51 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id 87EFEC36AE7 for ; Mon, 17 Jan 2022 12:47:50 +0000 (UTC) Authentication-Results: smtp.kernel.org; dkim=pass (1024-bit key) header.d=zx2c4.com header.i=@zx2c4.com header.b="jxTyPJoA" DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=zx2c4.com; s=20210105; t=1642423669; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=JIRLlbVVis5u8s0hBrGhQwKFxQSA77iBfFr7Eu67/zE=; b=jxTyPJoApAb2wwdAMvRX38gK84AlsV4jgRx/9OXkT9ZaX0m2ju3hFF5YFDxe3ozFnwHXUh HYByp7NB5AJGyRdlQiUJYZmwZzotilS17Cs7Yl0Ccez+4JLJ4evbSf3rEDPBPgWps/cUw9 MzDJ9nh5lDFtoev3nZeybWCD3bkwuSo= Received: by mail.zx2c4.com (ZX2C4 Mail Server) with ESMTPSA id 24ce9c37 (TLSv1.3:AEAD-AES256-GCM-SHA384:256:NO) for ; Mon, 17 Jan 2022 12:47:48 +0000 (UTC) Received: by mail-yb1-f182.google.com with SMTP id m1so26783866ybo.5 for ; Mon, 17 Jan 2022 04:47:48 -0800 (PST) X-Gm-Message-State: AOAM531GiyYkh8QnHKhersTot6hnZMOTgyAynLlaeWNNcUBAHPW9Sz2m uoCTqFwZQyrcRePJXtz+OY8J4x5KtRhp/kePWBQ= X-Received: by 2002:a25:e0d7:: with SMTP id x206mr9952050ybg.115.1642423667658; Mon, 17 Jan 2022 04:47:47 -0800 (PST) MIME-Version: 1.0 References: <3cbaf145ee577f017cf7aea953c9dd1eb88ed4b4.camel@perches.com> In-Reply-To: From: "Jason A. Donenfeld" Date: Mon, 17 Jan 2022 13:47:37 +0100 X-Gmail-Original-Message-ID: Message-ID: Subject: Re: list iterator spacing: clang-format vs checkpatch To: Miguel Ojeda Cc: Joe Perches , Andrew Lunn , LKML Content-Type: text/plain; charset="UTF-8" Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Hey again, Four years later I went through basically the same motions: "oh hey I should clean this up", "I'll start with clang format", "oh cool it adds spaces before the iterator paren so it looks like a normal for loop to me", "that seems so reasonable; I love clang format", "oh no checkpatch.pl complains; I hope it's wrong", "I wonder if anybody has thought about this before", "oh, look, I asked about this already in 2018." So, here we are again. I'm wondering: - Can we switch to spaces before iterator parens? - If not, is clang-format ever going to be fixed to quit adding them? Regards, Jason