Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18;
From:   Vladimir Oltean <vladimir.oltean@nxp.com>
To:     Horatiu Vultur <horatiu.vultur@microchip.com>
CC:     "netdev@vger.kernel.org" <netdev@vger.kernel.org>,
        "linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
        Claudiu Manoil <claudiu.manoil@nxp.com>,
        "alexandre.belloni@bootlin.com" <alexandre.belloni@bootlin.com>,
        "UNGLinuxDriver@microchip.com" <UNGLinuxDriver@microchip.com>,
        "davem@davemloft.net" <davem@davemloft.net>,
        "kuba@kernel.org" <kuba@kernel.org>
Subject: Re: [PATCH net] net: ocelot: Fix the call to
 switchdev_bridge_port_offload
Thread-Topic: [PATCH net] net: ocelot: Fix the call to
 switchdev_bridge_port_offload
Thread-Index: AQHYC6D0ZcgPGGB5b02M9wrfL+TskaxnLSsA
Date:   Mon, 17 Jan 2022 13:00:35 +0000
Message-ID: <20220117130034.jzm72mj42354y6fe@skbuf>
References: <20220117125300.2399394-1-horatiu.vultur@microchip.com>
In-Reply-To: <20220117125300.2399394-1-horatiu.vultur@microchip.com>
Accept-Language: en-US
Content-Language: en-US
x-ms-exchange-antispam-messagedata-chunkcount: 1
x-ms-exchange-antispam-messagedata-0: =?us-ascii?Q?ebrCjUSqqPbjfhnp+tir7mdgG5C9ReePlg+mlu74Br3qoxgeTo2P5v29TDMe?=
 =?us-ascii?Q?tJTevws0kDVWN6oI+HkICGsJYV/OwxIEzS3YHzVUsUvrg13Ygk/alITO1Vwt?=
 =?us-ascii?Q?pmnC99gPRCl6MdKV1BsysECybWRFkA7Nwxlji/IpdoI7WjB2E6V8KWjWhvAa?=
 =?us-ascii?Q?x4vDQadMU67vH550+1VJzWtKQ3i4tsLrbWR8t0lg1NgzdCjHzmkPpylNgB1O?=
 =?us-ascii?Q?TfiKGq7GAoa+cHKyNJORr8yZq6/xxH8mkTm4GJ/TcQJqGwR4JWYHnPAtNGxC?=
 =?us-ascii?Q?jOL2/XRM0HhBVb6ITRlLeaMKd7lPAWBQFDWnSug6LSWW1AXzOJq+OX95DFu/?=
 =?us-ascii?Q?DzFLES4tIB0DPKy6kgAoLZYzpKQ2ua14K04uNGeg+QyBuMpH1OvdbOjtd0bE?=
 =?us-ascii?Q?nNxlPikjN4LyZE66mQhWRMOkgtH5pvmmSu8kIMieUz+D1TctvA9NNc5Fir1/?=
 =?us-ascii?Q?T9ZZpNcz1iHsyCw8hcXqcsWiFQOAFM6UN/e/FefVlYvlDIjSCpOvrd1KFuOZ?=
 =?us-ascii?Q?wxh2y3MlJ4Fq9HCibegoAfmpB1NaAvp+1NSsxIc8PrxSdX7PFBFOk8mEwYC3?=
 =?us-ascii?Q?cEfOIgc76AyGjGEbWF85OUT4ZU3e0p3YNmLzeE/wjRNZ6EUAXHSXQtp52xAS?=
 =?us-ascii?Q?/okf0c1a9zcZRP6Bmlq4qcC/5RH8DuMAjdZ7Unjdxg5BTsCwCYwERcdFECr/?=
 =?us-ascii?Q?04kRo50a+IFQemcJd7if+6FUk4dOoi2yQDUgM6l2wuhhLz0bk8AcwjgATVRI?=
 =?us-ascii?Q?VISy8MQMsw44c5/WfUdGeAjTbnIsQan6lN1zVzaVFlM24N8YXj1B5CBgCiGD?=
 =?us-ascii?Q?tuan0p+KfEiIqyjrXc4/3+sr3EaUxd1B9CxH7BVtpxgt7g/pbSPnImFd70//?=
 =?us-ascii?Q?fEZ3sSrPOzg06zPUhMELflq4izeGo4guqn26mQybCerSDsbl3lTnbz0MD2jg?=
 =?us-ascii?Q?cX6c7dQeg41AhTdcT7SHeKheOVPpYy2c4btJ6OPacK5Fkh3VaKZufXOp9AaL?=
 =?us-ascii?Q?Dq+7UNQ9LeMo5UnyQxm/7SYiegs7SO2Iph92E9E0TDVlzdc0jFHI7Q9Xa11k?=
 =?us-ascii?Q?W//TT4ysRUwphjmo4JXOW38vrl9CgvgvdZ4Sa8vuP0IO5LU4Fz/Flum6JXpQ?=
 =?us-ascii?Q?jALUWCJjE6Noz26H4GD2fCIefdxoknK2tj2baSF9i/WNTYi3opFPdrDRJa78?=
 =?us-ascii?Q?j/NCVyzpEb53+zPQKpwL6UUN/EqBtw28Hw+zXjuv3JCDcE7Twx7tByEfq1nQ?=
 =?us-ascii?Q?Wkz+atXb/j5EjS6brMQ0/hlW/G+RDs0s8n1zlwjTifvD34olDQju/5TvhDW+?=
 =?us-ascii?Q?//CKAR+5JGat4gWl5M5U8WOlpFFpDiI4eYFTZO2KTc9uI68liAXLELRSIK1V?=
 =?us-ascii?Q?43VpanLnforjVypMXRWDNaSbgAzkKdwHUaUFqJiHxVAUU27HNZOUO8Clrah4?=
 =?us-ascii?Q?YKFOXsZEkUnjjN5ZILuXdFZySE80mkSQ6K1gAhYLtKwIWYhoq9TJ2rGlYNbr?=
 =?us-ascii?Q?xNPSrAC7GhCNS1XBenuDNzhGkC3/wWrwRaKu20BG/iZqlYIO3J3SYpgpX1Ey?=
 =?us-ascii?Q?QxwdpQFCl5QTuTppImm9pDbloVIHnlUUjCbkuJ5YyyBKRLPYDUjDKAJKv1Od?=
 =?us-ascii?Q?POQzkOL2PayOU5MFs0HTIN4=3D?=
Content-Type: text/plain; charset="us-ascii"
Content-ID: <F22B98968113FE47B2A9F9A52AD6AADC@eurprd04.prod.outlook.com>
Content-Transfer-Encoding: quoted-printable
MIME-Version: 1.0
X-OriginatorOrg: nxp.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-AuthSource: VI1PR04MB5136.eurprd04.prod.outlook.com
X-MS-Exchange-CrossTenant-Network-Message-Id: 4474083a-428b-4dc7-1941-08d9d9b95a32
X-MS-Exchange-CrossTenant-originalarrivaltime: 17 Jan 2022 13:00:35.3639
 (UTC)
X-MS-Exchange-CrossTenant-fromentityheader: Hosted
X-MS-Exchange-CrossTenant-id: 686ea1d3-bc2b-4c6f-a92c-d99c5c301635
X-MS-Exchange-CrossTenant-mailboxtype: HOSTED
X-MS-Exchange-CrossTenant-userprincipalname: jdnX1t1MIPXRli7UEuKUTZJYslwRRWfJC6nTVkgZTC0eSOqw3TCaLg5iUGchOsqqSKyd0TDl3DwRLOmbAy575g==
X-MS-Exchange-Transport-CrossTenantHeadersStamped: VI1PR0402MB3407
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

On Mon, Jan 17, 2022 at 01:53:00PM +0100, Horatiu Vultur wrote:
> In the blamed commit, the call to the function
> switchdev_bridge_port_offload was passing the wrong argument for
> atomic_nb. It was ocelot_netdevice_nb instead of ocelot_swtchdev_nb.
> This patch fixes this issue.
>=20
> Fixes: 4e51bf44a03af6 ("net: bridge: move the switchdev object replay hel=
pers to "push" mode")
> Signed-off-by: Horatiu Vultur <horatiu.vultur@microchip.com>
> ---
>  drivers/net/ethernet/mscc/ocelot_net.c | 6 +++---
>  1 file changed, 3 insertions(+), 3 deletions(-)
>=20
> diff --git a/drivers/net/ethernet/mscc/ocelot_net.c b/drivers/net/etherne=
t/mscc/ocelot_net.c
> index 8115c3db252e..e271b6225b72 100644
> --- a/drivers/net/ethernet/mscc/ocelot_net.c
> +++ b/drivers/net/ethernet/mscc/ocelot_net.c
> @@ -1187,7 +1187,7 @@ static int ocelot_netdevice_bridge_join(struct net_=
device *dev,
>  	ocelot_port_bridge_join(ocelot, port, bridge);
> =20
>  	err =3D switchdev_bridge_port_offload(brport_dev, dev, priv,
> -					    &ocelot_netdevice_nb,
> +					    &ocelot_switchdev_nb,
>  					    &ocelot_switchdev_blocking_nb,
>  					    false, extack);
>  	if (err)
> @@ -1201,7 +1201,7 @@ static int ocelot_netdevice_bridge_join(struct net_=
device *dev,
> =20
>  err_switchdev_sync:
>  	switchdev_bridge_port_unoffload(brport_dev, priv,
> -					&ocelot_netdevice_nb,
> +					&ocelot_switchdev_nb,
>  					&ocelot_switchdev_blocking_nb);
>  err_switchdev_offload:
>  	ocelot_port_bridge_leave(ocelot, port, bridge);
> @@ -1214,7 +1214,7 @@ static void ocelot_netdevice_pre_bridge_leave(struc=
t net_device *dev,
>  	struct ocelot_port_private *priv =3D netdev_priv(dev);
> =20
>  	switchdev_bridge_port_unoffload(brport_dev, priv,
> -					&ocelot_netdevice_nb,
> +					&ocelot_switchdev_nb,
>  					&ocelot_switchdev_blocking_nb);
>  }
> =20
> --=20
> 2.33.0
>

Oh my... I remember noticing this issue when preparing those patches,
and also noticed that ocelot doesn't implement SWITCHDEV_FDB_{ADD,DEL}_TO_D=
EVICE
anyway. So I wanted to pass NULL anyway. I don't know what happened,
I must have made the fixup on a branch which wasn't the branch that I poste=
d.
Anyway.

Reviewed-by: Vladimir Oltean <vladimir.oltean@nxp.com>=