Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18;
MIME-Version: 1.0
References: <20220114064821.20200-1-linmq006@gmail.com>
In-Reply-To: <20220114064821.20200-1-linmq006@gmail.com>
From:   Bartosz Golaszewski <brgl@bgdev.pl>
Date:   Mon, 17 Jan 2022 14:19:07 +0100
Message-ID: <CAMRc=Mcfoi+yRK7-AZehEPtT68_GPMmn1J7Kt4TzTTAMvL_u7Q@mail.gmail.com>
Subject: Re: [PATCH] gpio: mpc8xxx: Fix IRQ check in mpc8xxx_probe
To:     Miaoqian Lin <linmq006@gmail.com>
Cc:     Linus Walleij <linus.walleij@linaro.org>,
        Ran Wang <ran.wang_1@nxp.com>,
        Andy Shevchenko <andy.shevchenko@gmail.com>,
        "open list:GPIO SUBSYSTEM" <linux-gpio@vger.kernel.org>,
        Linux Kernel Mailing List <linux-kernel@vger.kernel.org>
Content-Type: text/plain; charset="UTF-8"
Precedence: bulk

On Fri, Jan 14, 2022 at 7:48 AM Miaoqian Lin <linmq006@gmail.com> wrote:
>
> platform_get_irq() returns negative error number instead 0 on failure.
> And the doc of platform_get_irq() provides a usage example:
>
>     int irq = platform_get_irq(pdev, 0);
>     if (irq < 0)
>         return irq;
>
> Fix the check of return value to catch errors correctly.
>
> Fixes: 76c47d1449fc ("gpio: mpc8xxx: Add ACPI support")
> Signed-off-by: Miaoqian Lin <linmq006@gmail.com>
> ---
>  drivers/gpio/gpio-mpc8xxx.c | 4 ++--
>  1 file changed, 2 insertions(+), 2 deletions(-)
>
> diff --git a/drivers/gpio/gpio-mpc8xxx.c b/drivers/gpio/gpio-mpc8xxx.c
> index 70d6ae20b1da..01634c8d27b3 100644
> --- a/drivers/gpio/gpio-mpc8xxx.c
> +++ b/drivers/gpio/gpio-mpc8xxx.c
> @@ -388,8 +388,8 @@ static int mpc8xxx_probe(struct platform_device *pdev)
>         }
>
>         mpc8xxx_gc->irqn = platform_get_irq(pdev, 0);
> -       if (!mpc8xxx_gc->irqn)
> -               return 0;
> +       if (mpc8xxx_gc->irqn < 0)
> +               return mpc8xxx_gc->irqn;
>
>         mpc8xxx_gc->irq = irq_domain_create_linear(fwnode,
>                                                    MPC8XXX_GPIO_PINS,
> --
> 2.17.1
>

Queued for fixes, thanks!

Bart