Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18;
From:   "Alim Akhtar" <alim.akhtar@samsung.com>
To:     "'Krzysztof Kozlowski'" <krzysztof.kozlowski@canonical.com>,
        <linux-arm-kernel@lists.infradead.org>,
        <linux-kernel@vger.kernel.org>
Cc:     <soc@kernel.org>, <linux-clk@vger.kernel.org>,
        <devicetree@vger.kernel.org>, <olof@lixom.net>,
        <linus.walleij@linaro.org>, <catalin.marinas@arm.com>,
        <robh+dt@kernel.org>, <s.nawrocki@samsung.com>,
        <linux-samsung-soc@vger.kernel.org>, <pankaj.dubey@samsung.com>,
        <linux-fsd@tesla.com>,
        "'Shashank Prashar'" <s.prashar@samsung.com>,
        "'Aswani Reddy'" <aswani.reddy@samsung.com>
In-Reply-To: <2927c34e-3259-4e9a-a657-aeeebf9089d2@canonical.com>
Subject: RE: [PATCH 15/23] arm64: dts: fsd: Add initial pinctrl support
Date:   Mon, 17 Jan 2022 19:14:53 +0530
Message-ID: <00ca01d80ba8$6b9b9800$42d2c800$@samsung.com>
MIME-Version: 1.0
Content-Transfer-Encoding: quoted-printable
Thread-Index: AQKuNmZ/+9PJHbdzezyQqzGEXzr0sgJL1gp6AanHgoQCI2LlgqqKGQKQ
Content-Language: en-us
Content-Type: text/plain; charset="utf-8"
CMS-TYPE: 105P
DLP-Filter: Pass
References: <20220113121143.22280-1-alim.akhtar@samsung.com>
        <CGME20220113122417epcas5p47398a5190cdf4c574c6f1762918b549f@epcas5p4.samsung.com>
        <20220113121143.22280-16-alim.akhtar@samsung.com>
        <2927c34e-3259-4e9a-a657-aeeebf9089d2@canonical.com>
Precedence: bulk

Hi Krzysztof

>-----Original Message-----
>From: Krzysztof Kozlowski =5Bmailto:krzysztof.kozlowski=40canonical.com=5D
>Sent: Thursday, January 13, 2022 6:50 PM
>To: Alim Akhtar <alim.akhtar=40samsung.com>; linux-arm-
>kernel=40lists.infradead.org; linux-kernel=40vger.kernel.org
>Cc: soc=40kernel.org; linux-clk=40vger.kernel.org; devicetree=40vger.kerne=
l.org;
>olof=40lixom.net; linus.walleij=40linaro.org; catalin.marinas=40arm.com;
>robh+dt=40kernel.org; s.nawrocki=40samsung.com; linux-samsung-
>soc=40vger.kernel.org; pankaj.dubey=40samsung.com; linux-fsd=40tesla.com;
>Shashank Prashar <s.prashar=40samsung.com>; Aswani Reddy
><aswani.reddy=40samsung.com>
>Subject: Re: =5BPATCH 15/23=5D arm64: dts: fsd: Add initial pinctrl suppor=
t
>
>On 13/01/2022 13:11, Alim Akhtar wrote:
>> Add initial pin configuration nodes for FSD SoC.
>>
>> Cc: linux-fsd=40tesla.com
>> Signed-off-by: Shashank Prashar <s.prashar=40samsung.com>
>> Signed-off-by: Aswani Reddy <aswani.reddy=40samsung.com>
>> Signed-off-by: Alim Akhtar <alim.akhtar=40samsung.com>
>> ---
>>  arch/arm64/boot/dts/tesla/fsd-pinctrl.dtsi =7C 338
>+++++++++++++++++++++
>>  arch/arm64/boot/dts/tesla/fsd.dtsi         =7C  22 ++
>>  2 files changed, 360 insertions(+)
>>  create mode 100644 arch/arm64/boot/dts/tesla/fsd-pinctrl.dtsi
>>
>> diff --git a/arch/arm64/boot/dts/tesla/fsd-pinctrl.dtsi
>> b/arch/arm64/boot/dts/tesla/fsd-pinctrl.dtsi
>> new file mode 100644
>> index 000000000000..ec8d944af636
>> --- /dev/null
>> +++ b/arch/arm64/boot/dts/tesla/fsd-pinctrl.dtsi
>> =40=40 -0,0 +1,338 =40=40
>> +// SPDX-License-Identifier: GPL-2.0
>> +/*
>> + * Tesla Full Self-Driving SoC device tree source
>> + *
>> + * Copyright (c) 2017-2021 Samsung Electronics Co., Ltd.
>> + *		https://www.samsung.com
>> + * Copyright (c) 2017-2021 Tesla, Inc.
>> + *		https://www.tesla.com
>> + */
>> +
>> +=23include <dt-bindings/pinctrl/samsung.h>
>> +
>> +&pinctrl_fsys0 =7B
>> +
>
>No need for empty line.
>
Noted

>> +	gpf0: gpf0 =7B
>
>FYI:
>It's ok now, but the nodes will have to be renamed to =22xxx-gpio-bank=22 =
later.
>
Have rebased my v2 on your pinmux schema update, so these and below comment=
s are addressed.
Thanks

>> +		gpio-controller;
>> +		=23gpio-cells =3D <2>;
>> +
>> +		interrupt-controller;
>> +		=23interrupt-cells =3D <2>;
>> +	=7D;
>> +
>> +	gpf1: gpf1 =7B
>> +		gpio-controller;
>> +		=23gpio-cells =3D <2>;
>> +
>> +		interrupt-controller;
>> +		=23interrupt-cells =3D <2>;
>> +	=7D;
>> +
>> +	gpf6: gpf6 =7B
>> +		gpio-controller;
>> +		=23gpio-cells =3D <2>;
>> +
>> +		interrupt-controller;
>> +		=23interrupt-cells =3D <2>;
>> +	=7D;
>> +
>> +	gpf4: gpf4 =7B
>> +		gpio-controller;
>> +		=23gpio-cells =3D <2>;
>> +
>> +		interrupt-controller;
>> +		=23interrupt-cells =3D <2>;
>> +	=7D;
>> +
>> +	gpf5: gpf5 =7B
>> +		gpio-controller;
>> +		=23gpio-cells =3D <2>;
>> +
>> +		interrupt-controller;
>> +		=23interrupt-cells =3D <2>;
>> +	=7D;
>> +=7D;
>> +
>> +&pinctrl_peric =7B
>> +
>
>No need for empty line.
>
>> +	gpc8: gpc8 =7B
>> +		gpio-controller;
>> +		=23gpio-cells =3D <2>;
>> +
>> +		interrupt-controller;
>> +		=23interrupt-cells =3D <2>;
>> +	=7D;
>> +
>> +	gpf2: gpf2 =7B
>> +		gpio-controller;
>> +		=23gpio-cells =3D <2>;
>> +
>> +		interrupt-controller;
>> +		=23interrupt-cells =3D <2>;
>> +	=7D;
>> +
>> +	gpf3: gpf3 =7B
>> +		gpio-controller;
>> +		=23gpio-cells =3D <2>;
>> +
>> +		interrupt-controller;
>> +		=23interrupt-cells =3D <2>;
>> +	=7D;
>> +
>> +	gpd0: gpd0 =7B
>> +		gpio-controller;
>> +		=23gpio-cells =3D <2>;
>> +
>> +		interrupt-controller;
>> +		=23interrupt-cells =3D <2>;
>> +	=7D;
>> +
>> +	gpb0: gpb0 =7B
>> +		gpio-controller;
>> +		=23gpio-cells =3D <2>;
>> +
>> +		interrupt-controller;
>> +		=23interrupt-cells =3D <2>;
>> +	=7D;
>> +
>> +	gpb1: gpb1 =7B
>> +		gpio-controller;
>> +		=23gpio-cells =3D <2>;
>> +
>> +		interrupt-controller;
>> +		=23interrupt-cells =3D <2>;
>> +	=7D;
>> +
>> +	gpb4: gpb4 =7B
>> +		gpio-controller;
>> +		=23gpio-cells =3D <2>;
>> +
>> +		interrupt-controller;
>> +		=23interrupt-cells =3D <2>;
>> +	=7D;
>> +
>> +	gpb5: gpb5 =7B
>> +		gpio-controller;
>> +		=23gpio-cells =3D <2>;
>> +
>> +		interrupt-controller;
>> +		=23interrupt-cells =3D <2>;
>> +	=7D;
>> +
>> +	gpb6: gpb6 =7B
>> +		gpio-controller;
>> +		=23gpio-cells =3D <2>;
>> +
>> +		interrupt-controller;
>> +		=23interrupt-cells =3D <2>;
>> +	=7D;
>> +
>> +	gpb7: gpb7 =7B
>> +		gpio-controller;
>> +		=23gpio-cells =3D <2>;
>> +
>> +		interrupt-controller;
>> +		=23interrupt-cells =3D <2>;
>> +	=7D;
>> +
>> +	gpd1: gpd1 =7B
>> +		gpio-controller;
>> +		=23gpio-cells =3D <2>;
>> +
>> +		interrupt-controller;
>> +		=23interrupt-cells =3D <2>;
>> +	=7D;
>> +
>> +	gpd2: gpd2 =7B
>> +		gpio-controller;
>> +		=23gpio-cells =3D <2>;
>> +
>> +		interrupt-controller;
>> +		=23interrupt-cells =3D <2>;
>> +	=7D;
>> +
>> +	gpd3: gpd3 =7B
>> +		gpio-controller;
>> +		=23gpio-cells =3D <2>;
>> +
>> +		interrupt-controller;
>> +		=23interrupt-cells =3D <2>;
>> +	=7D;
>> +
>> +	gpg0: gpg0 =7B
>> +		gpio-controller;
>> +		=23gpio-cells =3D <2>;
>> +
>> +		interrupt-controller;
>> +		=23interrupt-cells =3D <2>;
>> +	=7D;
>> +
>> +	gpg1: gpg1 =7B
>> +		gpio-controller;
>> +		=23gpio-cells =3D <2>;
>> +
>> +		interrupt-controller;
>> +		=23interrupt-cells =3D <2>;
>> +	=7D;
>> +
>> +	gpg2: gpg2 =7B
>> +		gpio-controller;
>> +		=23gpio-cells =3D <2>;
>> +
>> +		interrupt-controller;
>> +		=23interrupt-cells =3D <2>;
>> +	=7D;
>> +
>> +	gpg3: gpg3 =7B
>> +		gpio-controller;
>> +		=23gpio-cells =3D <2>;
>> +
>> +		interrupt-controller;
>> +		=23interrupt-cells =3D <2>;
>> +	=7D;
>> +
>> +	gpg4: gpg4 =7B
>> +		gpio-controller;
>> +		=23gpio-cells =3D <2>;
>> +
>> +		interrupt-controller;
>> +		=23interrupt-cells =3D <2>;
>> +	=7D;
>> +
>> +	gpg5: gpg5 =7B
>> +		gpio-controller;
>> +		=23gpio-cells =3D <2>;
>> +
>> +		interrupt-controller;
>> +		=23interrupt-cells =3D <2>;
>> +	=7D;
>> +
>> +	gpg6: gpg6 =7B
>> +		gpio-controller;
>> +		=23gpio-cells =3D <2>;
>> +
>> +		interrupt-controller;
>> +		=23interrupt-cells =3D <2>;
>> +	=7D;
>> +
>> +	gpg7: gpg7 =7B
>> +		gpio-controller;
>> +		=23gpio-cells =3D <2>;
>> +
>> +		interrupt-controller;
>> +		=23interrupt-cells =3D <2>;
>> +	=7D;
>> +
>> +	pwm0_out: pwm0-out =7B
>
>All pin configuretion node names with =22-pins=22 suffix. Upcoming dtschem=
a will
>require this.
>
>> +		samsung,pins =3D =22gpb6-1=22;
>> +		samsung,pin-function =3D <EXYNOS_PIN_FUNC_2>;
>> +		samsung,pin-pud =3D <EXYNOS_PIN_PULL_UP>;
>> +		samsung,pin-drv =3D <EXYNOS4_PIN_DRV_LV2>;
>> +	=7D;
>> +
>> +	pwm1_out: pwm1-out =7B
>> +		samsung,pins =3D =22gpb6-5=22;
>> +		samsung,pin-function =3D <EXYNOS_PIN_FUNC_2>;
>> +		samsung,pin-pud =3D <EXYNOS_PIN_PULL_UP>;
>> +		samsung,pin-drv =3D <EXYNOS4_PIN_DRV_LV2>;
>> +	=7D;
>> +
>> +	hs_i2c0_bus: hs-i2c0-bus =7B
>> +		samsung,pins =3D =22gpb0-0=22, =22gpb0-1=22;
>> +		samsung,pin-function =3D <EXYNOS_PIN_FUNC_2>;
>> +		samsung,pin-pud =3D <EXYNOS_PIN_PULL_UP>;
>> +		samsung,pin-drv =3D <EXYNOS4_PIN_DRV_LV1>;
>> +	=7D;
>> +
>> +	hs_i2c1_bus: hs-i2c1-bus =7B
>> +		samsung,pins =3D =22gpb0-2=22, =22gpb0-3=22;
>> +		samsung,pin-function =3D <EXYNOS_PIN_FUNC_2>;
>> +		samsung,pin-pud =3D <EXYNOS_PIN_PULL_UP>;
>> +		samsung,pin-drv =3D <EXYNOS4_PIN_DRV_LV1>;
>> +	=7D;
>> +
>> +	hs_i2c2_bus: hs-i2c2-bus =7B
>> +		samsung,pins =3D =22gpb0-4=22, =22gpb0-5=22;
>> +		samsung,pin-function =3D <EXYNOS_PIN_FUNC_2>;
>> +		samsung,pin-pud =3D <EXYNOS_PIN_PULL_UP>;
>> +		samsung,pin-drv =3D <EXYNOS4_PIN_DRV_LV1>;
>> +	=7D;
>> +
>> +	hs_i2c3_bus: hs-i2c3-bus =7B
>> +		samsung,pins =3D =22gpb0-6=22, =22gpb0-7=22;
>> +		samsung,pin-function =3D <EXYNOS_PIN_FUNC_2>;
>> +		samsung,pin-pud =3D <EXYNOS_PIN_PULL_UP>;
>> +		samsung,pin-drv =3D <EXYNOS4_PIN_DRV_LV1>;
>> +	=7D;
>> +
>> +	hs_i2c4_bus: hs-i2c4-bus =7B
>> +		samsung,pins =3D =22gpb1-0=22, =22gpb1-1=22;
>> +		samsung,pin-function =3D <EXYNOS_PIN_FUNC_2>;
>> +		samsung,pin-pud =3D <EXYNOS_PIN_PULL_UP>;
>> +		samsung,pin-drv =3D <EXYNOS4_PIN_DRV_LV1>;
>> +	=7D;
>> +
>> +	hs_i2c5_bus: hs-i2c5-bus =7B
>> +		samsung,pins =3D =22gpb1-2=22, =22gpb1-3=22;
>> +		samsung,pin-function =3D <EXYNOS_PIN_FUNC_2>;
>> +		samsung,pin-pud =3D <EXYNOS_PIN_PULL_UP>;
>> +		samsung,pin-drv =3D <EXYNOS4_PIN_DRV_LV1>;
>> +	=7D;
>> +
>> +	hs_i2c6_bus: hs-i2c6-bus =7B
>> +		samsung,pins =3D =22gpb1-4=22, =22gpb1-5=22;
>> +		samsung,pin-function =3D <EXYNOS_PIN_FUNC_2>;
>> +		samsung,pin-pud =3D <EXYNOS_PIN_PULL_UP>;
>> +		samsung,pin-drv =3D <EXYNOS4_PIN_DRV_LV1>;
>> +	=7D;
>> +
>> +	hs_i2c7_bus: hs-i2c7-bus =7B
>> +		samsung,pins =3D =22gpb1-6=22, =22gpb1-7=22;
>> +		samsung,pin-function =3D <EXYNOS_PIN_FUNC_2>;
>> +		samsung,pin-pud =3D <EXYNOS_PIN_PULL_UP>;
>> +		samsung,pin-drv =3D <EXYNOS4_PIN_DRV_LV1>;
>> +	=7D;
>> +
>> +	uart0_data: uart0-data =7B
>> +		samsung,pins =3D =22gpb7-0=22, =22gpb7-1=22;
>> +		samsung,pin-function =3D <EXYNOS_PIN_FUNC_2>;
>> +		samsung,pin-pud =3D <EXYNOS_PIN_PULL_NONE>;
>> +		samsung,pin-drv =3D <EXYNOS4_PIN_DRV_LV1>;
>> +	=7D;
>> +
>> +	uart1_data: uart1-data =7B
>> +		samsung,pins =3D =22gpb7-4=22, =22gpb7-5=22;
>> +		samsung,pin-function =3D <EXYNOS_PIN_FUNC_2>;
>> +		samsung,pin-pud =3D <EXYNOS_PIN_PULL_NONE>;
>> +		samsung,pin-drv =3D <EXYNOS4_PIN_DRV_LV1>;
>> +	=7D;
>> +
>> +	spi0_bus: spi0-bus =7B
>> +		samsung,pins =3D =22gpb4-0=22, =22gpb4-2=22, =22gpb4-3=22;
>> +		samsung,pin-function =3D <EXYNOS_PIN_FUNC_2>;
>> +		samsung,pin-pud =3D <EXYNOS_PIN_PULL_UP>;
>> +		samsung,pin-drv =3D <EXYNOS4_PIN_DRV_LV1>;
>> +	=7D;
>> +
>> +	spi1_bus: spi1-bus =7B
>> +		samsung,pins =3D =22gpb4-4=22, =22gpb4-6=22, =22gpb4-7=22;
>> +		samsung,pin-function =3D <EXYNOS_PIN_FUNC_2>;
>> +		samsung,pin-pud =3D <EXYNOS_PIN_PULL_UP>;
>> +		samsung,pin-drv =3D <EXYNOS4_PIN_DRV_LV1>;
>> +	=7D;
>> +
>> +	spi2_bus: spi2-bus =7B
>> +		samsung,pins =3D =22gpb5-0=22, =22gpb5-2=22, =22gpb5-3=22;
>> +		samsung,pin-function =3D <EXYNOS_PIN_FUNC_2>;
>> +		samsung,pin-pud =3D <EXYNOS_PIN_PULL_UP>;
>> +		samsung,pin-drv =3D <EXYNOS4_PIN_DRV_LV1>;
>> +	=7D;
>> +=7D;
>> +
>> +&pinctrl_pmu =7B
>> +
>
>No need for empty line.
>
>> +	gpq0: gpq0 =7B
>> +		gpio-controller;
>> +		=23gpio-cells =3D <2>;
>> +	=7D;
>
>
>
>
>Best regards,
>Krzysztof