Received: by 2002:a05:6a10:af89:0:0:0:0 with SMTP id iu9csp3358952pxb; Mon, 17 Jan 2022 18:32:19 -0800 (PST) X-Google-Smtp-Source: ABdhPJyi2eCSYvN87TvMyNo3f38XaGKsiY4woNovtlmtPZ0E/NDoYZNQSA+Pht4FPew5u7sRuzfh X-Received: by 2002:a65:610b:: with SMTP id z11mr11068072pgu.205.1642473139078; Mon, 17 Jan 2022 18:32:19 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1642473139; cv=none; d=google.com; s=arc-20160816; b=cUD5ew3w/WZ+vHp2chAVWdfDBH1FMl/jBcuZgLHp/Xget2+sdUWcz0sdz2QEBE7PtI dgfVFTDMKKP9lkkDsfkGiNrkb7WXhgCi189rErDHEfadJ8G56aQ6KEEjQp76NNXUCtls WOgO1U3hwbnMxUytlnCONumics2fM8I0p5uN/gcGXE+2LFmdSt1YA0Vecj4anozdkxD3 ETDvWQXCY/8HuPZg+IV9ldoHIHKFzi3QLx+BUFnXGE4Ic602LATVWMFQ8xhWzWv36mOr Z4eiOSReNuD0ElScFrfCCbL1SpEfmhkzW48gQqefY/nBg8lhiiEXAslF7lhHMZQ/2a3d zYbQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:content-transfer-encoding:content-language :in-reply-to:mime-version:user-agent:date:message-id:organization :from:references:to:subject:dkim-signature; bh=1qCDtK0pn2oxt/dygNI3dBfTIc8Ow2NP2GJorgRm9sA=; b=RuyFl8yXgNmBQS9V5cVTtq/Zq1Lj0cRYLHb9X3RZMHAxF+TDB1gonAGZyldVZHreBR eSYN17Y3jFc50Mezo3BvkauwggapR/am6YdnKd3QSPaqsMrqWs9GbGbR0AiVdA5SJhUO utRgfUPcpEvT4lu7vseSP4tE8Qyl9ILIs37n2Ggsy8NIFqyiMRj4WAly4ra5EoW4lR9m RWDR7bKtU6sCpsbI4KrOBW6n3ubZHFS2QQkJEmEVSbf2PYS3lYTGBGnt9fUafAhPbyKc Nfdr0Yr2+IuMpWVJGf5IuFPXKRqxCAmscyAcdIHyjtxj7ca5kwU9DaHA36dhvRoETC4h UrQA== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@baylibre-com.20210112.gappssmtp.com header.s=20210112 header.b=tC0xSuKF; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [23.128.96.18]) by mx.google.com with ESMTP id mh17si1628042pjb.31.2022.01.17.18.32.07; Mon, 17 Jan 2022 18:32:19 -0800 (PST) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18; Authentication-Results: mx.google.com; dkim=pass header.i=@baylibre-com.20210112.gappssmtp.com header.s=20210112 header.b=tC0xSuKF; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S239606AbiAQOav (ORCPT + 99 others); Mon, 17 Jan 2022 09:30:51 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:38396 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S234449AbiAQOan (ORCPT ); Mon, 17 Jan 2022 09:30:43 -0500 Received: from mail-wm1-x32c.google.com (mail-wm1-x32c.google.com [IPv6:2a00:1450:4864:20::32c]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id AB5F9C06161C for ; Mon, 17 Jan 2022 06:30:42 -0800 (PST) Received: by mail-wm1-x32c.google.com with SMTP id l12-20020a7bc34c000000b003467c58cbdfso24789782wmj.2 for ; Mon, 17 Jan 2022 06:30:42 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=baylibre-com.20210112.gappssmtp.com; s=20210112; h=subject:to:references:from:organization:message-id:date:user-agent :mime-version:in-reply-to:content-language:content-transfer-encoding; bh=1qCDtK0pn2oxt/dygNI3dBfTIc8Ow2NP2GJorgRm9sA=; b=tC0xSuKFutKm9eO/94iduqujirQJ/J/cZSJASDLdN3De2Q8dwRjZEOS7gNymWSZtJk nJ4h6NgRWKUZFHxeib0pOht0apN3VL48llsfJc8ay91rjw4KiRm7kHeuWSgfnz5Z57EE aAqk43UviPgI8fRAywyd5JCxul27SxUkkz9cR9jOBSZCIFKIDmdb6I3Aoi7EQKaexCXl wFGjiAoLDJ/sTvl33QO2EVNS4c/ZPpWg1juygPJjlrfESgUpfwIefrSMcaBbroZUA2T9 Xz5lNn78G5Ih/PtIuBmxC6WHNj1Ov8v1IUPjV8WLyO6cXHJ7iTZcZJGMiq0aJOKqHAXa RlDg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:subject:to:references:from:organization :message-id:date:user-agent:mime-version:in-reply-to :content-language:content-transfer-encoding; bh=1qCDtK0pn2oxt/dygNI3dBfTIc8Ow2NP2GJorgRm9sA=; b=Xk9R3OGZKrJ6oSDxcTHIy2LI4Pcq7JpB8UaWhkkO1YP+R6fYRVYFwK6qpFvNUzhicf LJDiNxgiKVspelybomAd/2NO2NXpEmjCBLXesZ491cMPVjO8x9BeKwd8TRJLGIJUclid tJpvAyuq8BDzpYetmOcbeBhz4ZdPWYAiWjUiA0W/8GHZLA+aP4EeOPdMBk3HMMlaxs50 e7F321jVXLhYw+fw7EjvDySEp6x2slqRiR5K6RsqeBjO2wenzzjDtYBmryTCSTQzjfHC ugp9SLIm3OkELuxQ4HIZ7SXVYjPsSSYENdg+vncGyGZScCm9bNilBEgJQwN80vmQtLeL EgCQ== X-Gm-Message-State: AOAM533GELMHuM1uriZVFTPsXwV0qMbgkXzoM+3wgSUNPMkCkk+wNnl3 mAIiaQKho01vdZ19g4598+uSaEKk7DsDsA== X-Received: by 2002:a5d:42c3:: with SMTP id t3mr19995885wrr.301.1642429840767; Mon, 17 Jan 2022 06:30:40 -0800 (PST) Received: from ?IPv6:2001:861:44c0:66c0:c004:9fe1:fbda:2d0c? ([2001:861:44c0:66c0:c004:9fe1:fbda:2d0c]) by smtp.gmail.com with ESMTPSA id x8sm13243778wru.102.2022.01.17.06.30.39 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Mon, 17 Jan 2022 06:30:40 -0800 (PST) Subject: Re: [PATCH 3/3] arm64: dts: meson: remove Broadcom WiFi/BT nodes from Khadas VIM1 To: Christian Hewitt , Rob Herring , Mark Rutland , Kevin Hilman , devicetree@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-amlogic@lists.infradead.org, linux-kernel@vger.kernel.org References: <20220113041746.16040-1-christianshewitt@gmail.com> <20220113041746.16040-4-christianshewitt@gmail.com> From: Neil Armstrong Organization: Baylibre Message-ID: <2236d8a8-77e7-7dc9-fd32-b3ade335a128@baylibre.com> Date: Mon, 17 Jan 2022 15:30:39 +0100 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:78.0) Gecko/20100101 Thunderbird/78.14.0 MIME-Version: 1.0 In-Reply-To: <20220113041746.16040-4-christianshewitt@gmail.com> Content-Type: text/plain; charset=utf-8 Content-Language: en-US Content-Transfer-Encoding: 7bit Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Hi, On 13/01/2022 05:17, Christian Hewitt wrote: > The Broadcom WiFi/BT SDIO nodes are now inherited from the P212 common dtsi > so we can remove them from the VIM1 board dts. > > Signed-off-by: Christian Hewitt > --- > .../amlogic/meson-gxl-s905x-khadas-vim.dts | 19 ------------------- > 1 file changed, 19 deletions(-) > > diff --git a/arch/arm64/boot/dts/amlogic/meson-gxl-s905x-khadas-vim.dts b/arch/arm64/boot/dts/amlogic/meson-gxl-s905x-khadas-vim.dts > index 6ab1cc125b96..108232a5aa2e 100644 > --- a/arch/arm64/boot/dts/amlogic/meson-gxl-s905x-khadas-vim.dts > +++ b/arch/arm64/boot/dts/amlogic/meson-gxl-s905x-khadas-vim.dts > @@ -217,25 +217,6 @@ > pinctrl-0 = <&pwm_e_pins>, <&pwm_f_clk_pins>; > }; > > -&sd_emmc_a { > - max-frequency = <100000000>; The SDIO freq is marked as 50000000 in the p212 DTSI and was explicitly changes by Jerome in adc52bf7ef16 ("arm64: dts: meson: fix mmc v2 chips max frequencies") The change is ok if you change the p212 DTSI to 100000000 aswell. > - > - brcmf: wifi@1 { > - reg = <1>; > - compatible = "brcm,bcm4329-fmac"; > - }; > -}; > - > -&uart_A { > - bluetooth { > - compatible = "brcm,bcm43438-bt"; > - shutdown-gpios = <&gpio GPIOX_17 GPIO_ACTIVE_HIGH>; > - max-speed = <2000000>; > - clocks = <&wifi32k>; > - clock-names = "lpo"; > - }; > -}; > - > /* This is brought out on the Linux_RX (18) and Linux_TX (19) pins: */ > &uart_AO { > status = "okay"; > With the change in p212 dtsi: Reviewed-by: Neil Armstrong Thanks, Neil