Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18;
Subject: Re: [PATCH] usb: common: ulpi: Fix crash in ulpi_match()
To:     Heikki Krogerus <heikki.krogerus@linux.intel.com>
Cc:     Stephan Gerhold <stephan@gerhold.net>,
        Andy Gross <agross@kernel.org>,
        Bjorn Andersson <bjorn.andersson@linaro.org>,
        linux-usb@vger.kernel.org, linux-kernel@vger.kernel.org,
        linux-tegra@vger.kernel.org
References: <20220114100217.59541-1-jonathanh@nvidia.com>
 <YeV466hTEyDwvmyL@kuha.fi.intel.com>
From:   Jon Hunter <jonathanh@nvidia.com>
Message-ID: <170d3614-97e3-8494-ac87-37d11dc48770@nvidia.com>
Date:   Mon, 17 Jan 2022 15:01:55 +0000
User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:78.0) Gecko/20100101
 Thunderbird/78.14.0
In-Reply-To: <YeV466hTEyDwvmyL@kuha.fi.intel.com>
Content-Type: text/plain; charset=utf-8; format=flowed
Content-Language: en-US
Content-Transfer-Encoding: 7bit
MIME-Version: 1.0
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?WHZ6U1AxdG4yb1cyRmlrdjArVHJXbUZGd1NFZExod0dXQmlLMGVaMzhTbUR3?=
 =?utf-8?B?Zi9tc0pPUWZRQlB2cDBXTUtrdy8rZUlHVEZBZWVuTFNsdENsWVZvTkRCZjM4?=
 =?utf-8?B?OWlaNldvRnZpbUJQdC8vYzJtdFQyU3lrb1A3c01uNk5tLzdKNzR4TnIyMnZi?=
 =?utf-8?B?endGam51WGE3RzFlRkpkNzBnTEh4c3I1MlVyT2Y4cFNMWDBzb3dNZVNQN0c2?=
 =?utf-8?B?TTMzMHNIajY2d2YvdjcwWkptdHFGQ3pOcUhuRGlndDV5c01NeFBsWnVGQitI?=
 =?utf-8?B?RVZtRTczTEFqMncvUEwrN0lHcE44Q29VTEZCSmt3TFhLYTRjUzNKb3pROEt6?=
 =?utf-8?B?T3JFa05LUVkvNTVhT0pkT283YnVNbWRNcjg4SHQ0ZG15RU9reFdJUVYwVTRx?=
 =?utf-8?B?TExpeWw2S3hEb0w5L1lIZXlVaFB6US9iVUJSUzlFNmVTSHBIMjZtRGRVTE5k?=
 =?utf-8?B?SDcxeTkxSFIvQUlGc2hMVjE1MUMvSC9Na3JNSkQzempZcmdqY0JHbG8xMXdu?=
 =?utf-8?B?R3FUS21XSjNqbi9Sa3ErNVZRWEFPbFU0MnU0SEZRbWRUZ0IrQ3lnL21rSkRG?=
 =?utf-8?B?Yk9RcDl4VFpxQ00yRU5hM3ZOMWtiZDJxeFZoMGFrREVKWTNoWXNoUGliWVBV?=
 =?utf-8?B?VnYyRmxPK0ZJaGROOURnb3d1eHYwemFiWUpjQSt3V2MwYml1SFRIWG1ibDZw?=
 =?utf-8?B?VWhrR3gxMzR3ZXAzdWhPMlJzQjdZWHFwOFo3QXBlR1ZkZFE0Ky90MDJLYlNz?=
 =?utf-8?B?ZDFkb0dXQjBQL1U1L3AzVmxuaXpFcDB5ZWZ0c04xVExPWE9BbmxhcUlNU3lU?=
 =?utf-8?B?U1E0UUxjVWF1dGx1YzVEU1l3Njhkc051SzQ5OVFEcDdwbjhGUFFLM1M0eC96?=
 =?utf-8?B?eWs2YnhNdXJ6RDZ6bEIvbyt1UXAySGEzQ2RKL2xHM1JJQmlIbzFZUzlIazlU?=
 =?utf-8?B?MFdUcVhMYnh5R3NodEdrS0pReUlCdCtUcURiMzRXcXNEMi9MWnM2blFmMGFw?=
 =?utf-8?B?aFY1aFVkSXVYeTA0Uy9vRXpQVjRnQS91clgyVVZVd1NDbGJlSk4wTElJL09l?=
 =?utf-8?B?OEpaUWw1K3VDeWk0UUtaWkprUnZZQllBNUJvcnRrK1QwcFdpYUdwVExpUENN?=
 =?utf-8?B?amt0K0hHU0hiczBSNFpXQTNDUDhib3YxM21BU0N3NXpwWEQxR0NnZlpUSmVn?=
 =?utf-8?B?ZFE1L0NLS3EralhHK0hqUGp5eEpaVHN6NnplU1BzclA4UjdjU094dzMyZXZo?=
 =?utf-8?B?d0dyMksrcWlLN3hTS3hiWG9aMlZ4TTQwN3dFUGFpOE4xZ2hWT1R4ZGhEUlNu?=
 =?utf-8?B?M05rQkVPUkhlOEhSNUtoRE5sRUJHQ0RuL092cXJ2OFVOOEtSd2VTdytSRFFh?=
 =?utf-8?B?UkFranJiSXV1R2dnYVpvS3hqaGJIbVBBS2lyKzVXTzhKVmpJZ2lqczFtZUhn?=
 =?utf-8?B?Um0rTGk4L3J3RUpyaS9RczQzU1RwZjRJTzlBVkpaaXltZ0F2R3ROVTM2a0VZ?=
 =?utf-8?B?Z2M2S095QStqZm9UdzgxZ2orcDRrWDRuamJJb1hpSWt3ZnBqcnhMR2RDazhS?=
 =?utf-8?B?YU9IYklZME5Pb1BHbHgzK2pLbXBtUkpGUmZyY0pWdTB1OXY2clJubk15LzJS?=
 =?utf-8?B?Rk5TQjdRdEFIZlRLaUhXb3FXTXBOYzNBSWp3WVRoejltTjN2ZzNZNVBKR0FZ?=
 =?utf-8?B?SmdvSCt4VjM5MzdubE9ZYUw2N3VBcmhrMmJCdm9QT1lhWDBIOHFoUTIraHk2?=
 =?utf-8?B?ckNSSmNHOW10V1dicWFEVjIycWQ0YXZyTzdBM21pQ3pUeWd4Ukk5d1dmelk2?=
 =?utf-8?B?YlUxZkVJbS9hM3U2ZkpyOGJIRUNNNVNYOU1wdDcwTHNYVHkyM1pnRUJHSEh5?=
 =?utf-8?B?QXNQTnVmMkRsb2dTT3BRakRzT2NhT2NtQkM5TlJkOTZzWjRxNENpRUZ5WTNj?=
 =?utf-8?B?RzlaZmV2aTlZV2hRU21jWjluVXVRK2FLcmxIbUo1eU9vcE5WQWtualNYTnZz?=
 =?utf-8?B?VzRZeWtScGxIbmtmSEp3THB5ajhxRmpEbXdQVnVHODlhUzlreU1wZWpDVG03?=
 =?utf-8?B?d2ozWjlQTHkwUUd2SkdpS3FUQ1pRdWVVTWw0RGdFNnoxMnJJU2UyRWIxeXc3?=
 =?utf-8?B?ZmV3ZTYyRGdWYXQybVBZVSs3VEVUelFpU0ZEOWNmdjBsU1VrQk40M0VDeFVZ?=
 =?utf-8?Q?6vNrKzq8wdwkKPwOeQwms0g=3D?=
X-OriginatorOrg: Nvidia.com
X-MS-Exchange-CrossTenant-Network-Message-Id: 3f61c6e9-3caf-4c3f-21a0-08d9d9ca51bd
X-MS-Exchange-CrossTenant-AuthSource: CO6PR12MB5444.namprd12.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 17 Jan 2022 15:02:03.0106
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: 43083d15-7273-40c1-b7db-39efd9ccc17a
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: tZjoA/QUzMGUY/trcJaesmCJvDqR2XpQs7mj8tw1Cz7N6GPdXxbt4nIJJIhATC+a6GpHByjI4x1EJaMsPmXwbw==
X-MS-Exchange-Transport-CrossTenantHeadersStamped: DM6PR12MB4729
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

Hi Heikki,

On 17/01/2022 14:10, Heikki Krogerus wrote:
> Hi Jon,
> 
> On Fri, Jan 14, 2022 at 10:02:17AM +0000, Jon Hunter wrote:
>> Commit 7495af930835 ("ARM: multi_v7_defconfig: Enable drivers for
>> DragonBoard 410c") enables the CONFIG_PHY_QCOM_USB_HS for the ARM
>> multi_v7_defconfig. Enabling this Kconfig is causing the kernel to crash
>> on the Tegra20 Ventana platform in the ulpi_match() function.
>>
>> The Qualcomm USB HS PHY driver that is enabled by CONFIG_PHY_QCOM_USB_HS,
>> registers a ulpi_driver but this driver does not provide an 'id_table',
>> so when ulpi_match() is called on the Tegra20 Ventana platform, it
>> crashes when attempting to deference the id_table pointer which is not
>> valid. The Qualcomm USB HS PHY driver uses device-tree for matching the
>> ULPI driver with the device and so fix this crash by using device-tree
>> for matching if the id_table is not valid.
>>
>> Signed-off-by: Jon Hunter <jonathanh@nvidia.com>
> 
> So is this fixing commit 7495af930835, or perhaps commit ef6a7bcfb01c
> ("usb: ulpi: Support device discovery via DT")?
> 
> I would assume ef6a7bcfb01c ("usb: ulpi: Support device discovery via
> DT"). Please include the appropriate Fixes tag.


Yes that does sound appropriate. I have added and sent an update.

Cheers
Jon

-- 
nvpublic