Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18;
Date:   Mon, 17 Jan 2022 21:37:05 +0530
From:   Manivannan Sadhasivam <mani@kernel.org>
To:     Slark Xiao <slark_xiao@163.com>
Cc:     hemantk@codeaurora.org, mhi@lists.linux.dev,
        linux-arm-msm@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: Re: [PATCH net v2] For default mechanism, product would use
 default MRU 3500 if they didn't define it. But for Foxconn SDX55, there is a
 known issue which MRU 3500 would lead to data connection lost. So we align
 it with Qualcomm default MRU settings.
Message-ID: <20220117160705.GC4209@thinkpad>
References: <20220117081644.21121-1-slark_xiao@163.com>
 <20220117084432.GB4209@thinkpad>
 <50e92997.386b.17e6775c20b.Coremail.slark_xiao@163.com>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <50e92997.386b.17e6775c20b.Coremail.slark_xiao@163.com>
Precedence: bulk

On Mon, Jan 17, 2022 at 05:54:37PM +0800, Slark Xiao wrote:
> 
> 
> 
> 
> 
> 
> At 2022-01-17 16:44:32, "Manivannan Sadhasivam" <mani@kernel.org> wrote:
> >On Mon, Jan 17, 2022 at 04:16:44PM +0800, Slark Xiao wrote:
> >> Fixes: 5c2c85315948 ("bus: mhi: pci-generic: configurable network interface MRU")
> >
> >You have messed up the patch subject, please fix it. Also, the correct fixes tag
> >should be the one added the Foxconn modem support, precisely "aac426562f56".
> >
> Yes, sorry for this mistake. 
> >One more thing, please make sure this MRU value works well for other Foxconn
> >modems supported by this config.
> >
> I am sure this would work for all  our device. BTW, I want to add this mru_default to 
> cinterion-mv31 PRODUCT. Shall I use v3 or create a new version for that? It's confirmed 
> that this change could help fix issue on that product.

Please submit individual patches with Fixes tag each.

> >> Signed-off-by: Slark Xiao <slark_xiao@163.com>
> >
> >You should have added my Reviewed-by tag too...
> Shall I add reviewd-by tag if I add changes on MV31 product?
> >

No, only to this patch since I haven't reviewed the MV31 patch.

Thanks,
Mani

> >Thanks,
> >Mani
> >
> >> 
> >> ---
> >> v2: Add Fixes tag
> >> ---
> >>  drivers/bus/mhi/pci_generic.c | 1 +
> >>  1 file changed, 1 insertion(+)
> >> 
> >> diff --git a/drivers/bus/mhi/pci_generic.c b/drivers/bus/mhi/pci_generic.c
> >> index 3a258a677df8..74e8fc342cfd 100644
> >> --- a/drivers/bus/mhi/pci_generic.c
> >> +++ b/drivers/bus/mhi/pci_generic.c
> >> @@ -366,6 +366,7 @@ static const struct mhi_pci_dev_info mhi_foxconn_sdx55_info = {
> >>  	.config = &modem_foxconn_sdx55_config,
> >>  	.bar_num = MHI_PCI_DEFAULT_BAR_NUM,
> >>  	.dma_data_width = 32,
> >> +	.mru_default = 32768,
> >>  	.sideband_wake = false,
> >>  };
> >>  
> >> -- 
> >> 2.25.1
> >>