Received: by 2002:a05:6a10:af89:0:0:0:0 with SMTP id iu9csp3362457pxb; Mon, 17 Jan 2022 18:37:34 -0800 (PST) X-Google-Smtp-Source: ABdhPJx1QaEH3E+BHNAGe1iHuj5johJu6NN79KTRLriZhdCH//qigzB70jBDPE5o+R8wWpyVMHIY X-Received: by 2002:a63:bf0a:: with SMTP id v10mr21232675pgf.404.1642473453852; Mon, 17 Jan 2022 18:37:33 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1642473453; cv=none; d=google.com; s=arc-20160816; b=uV3Yo0kt041w2ANILEQGi9PkKeYHpyLazmov9LRMAES9pMFDGBlJ6VVdvr8O1vpwuX 4cGiKFh+unAOcTUsh6hkKlOw+zrbZ94QoKu6iJLAVe1jQqQyBr2cqvokUx9kxYfBUkog dQG7kMTbqRTbt0hBNpqux2JTrFcII8S3uBC6SmQLClDFFe4TbblHpRQx+x80XOMGPCd0 9dV4v18aB2PyelcO1vkck9+wQamL9K4bq5cRQtkTWa0U/aWTgEEJ+H4ORqvqT+D8Gbyl j/5dGyKF+P4yL9t7mRt+efw2JxNOqW1bA7iVqE4dJXMD7s5BxJtn3kLFvAEQWrIZWtiF v/xg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:content-transfer-encoding:mime-version :references:in-reply-to:message-id:date:subject:cc:to:from :dkim-signature; bh=bl5u1NTQ5L1xVZfZHeopeNSvmI7iSBTqrV2EHIRtC04=; b=lixD8E7hc5bpylryxkno6g7S5ZCUWVXwCdOTMwfeAlB6dLDEqdvlFhfX7Ou0EftZqJ 4xBY0JDKVem+56O/20lWDuUjpKxs/S7FXagXutkL1SBmt+BfYuEXinkVX3XpTQCvp+1M bFJcaL6ZYcrBONY+uVxG1yx8erBhJejLgXh+VG8EES/fv3gGsAo9Bl0uWE+9noHg8Av0 Cj8oIsfq+ERbzkGyI9fivVAx82/+5Y6JfREaqV4RC2i+Y+V+RoANCINp0aEiNEPowcpe 2f3e/pCyYXA0YdQb8qj1cbF207oFxhrvANcqmK9S6G9oUlxrEF8sF3NpG0j0Rlho9gl6 JIUQ== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@cirrus.com header.s=PODMain02222019 header.b=ABYlKoOy; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=REJECT sp=REJECT dis=NONE) header.from=cirrus.com Return-Path: Received: from vger.kernel.org (vger.kernel.org. [23.128.96.18]) by mx.google.com with ESMTP id bg12si15140964plb.400.2022.01.17.18.37.21; Mon, 17 Jan 2022 18:37:33 -0800 (PST) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18; Authentication-Results: mx.google.com; dkim=pass header.i=@cirrus.com header.s=PODMain02222019 header.b=ABYlKoOy; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=REJECT sp=REJECT dis=NONE) header.from=cirrus.com Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S240805AbiAQQJ1 (ORCPT + 99 others); Mon, 17 Jan 2022 11:09:27 -0500 Received: from mx0a-001ae601.pphosted.com ([67.231.149.25]:46830 "EHLO mx0b-001ae601.pphosted.com" rhost-flags-OK-OK-OK-FAIL) by vger.kernel.org with ESMTP id S235180AbiAQQJX (ORCPT ); Mon, 17 Jan 2022 11:09:23 -0500 Received: from pps.filterd (m0077473.ppops.net [127.0.0.1]) by mx0a-001ae601.pphosted.com (8.16.1.2/8.16.1.2) with ESMTP id 20HFFYHC025138; Mon, 17 Jan 2022 10:08:35 -0600 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=cirrus.com; h=from : to : cc : subject : date : message-id : in-reply-to : references : mime-version : content-transfer-encoding : content-type; s=PODMain02222019; bh=bl5u1NTQ5L1xVZfZHeopeNSvmI7iSBTqrV2EHIRtC04=; b=ABYlKoOylzmVdR60EJP8p8eXcFV4koeulRwpGDUtSRp3edJ3h5Nkv7TF9n7dsFmfaidQ 3B/JYwppuhGlNN/71Le3Ov6yWNJxKtqPznrIq0TV3UDyBdFzLtZY5DMnCsJ15ka/nIVA acd0NW1nL2Y5sCtwP8AY+Yl3inVYu3uKwIZSwH2xF5147LCd2DL7UvbA3vjav1uNZSdE QLW4nhaRJU/k8m7Nn5LcGP4jy09l+kOlIRkFFa8BCsP0AsCC9skeEF26Zf3K+hZWqeTY EbOFgPKJBxKRiP+KXnlMctHCdvBYmJxONNcUYY7SDKL8rBMhkTBXolJalCudwWGwy7d6 2A== Received: from ediex01.ad.cirrus.com ([84.19.233.68]) by mx0a-001ae601.pphosted.com (PPS) with ESMTPS id 3dnaxhr22c-2 (version=TLSv1.2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128 verify=NOT); Mon, 17 Jan 2022 10:08:34 -0600 Received: from EDIEX01.ad.cirrus.com (198.61.84.80) by EDIEX01.ad.cirrus.com (198.61.84.80) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2375.18; Mon, 17 Jan 2022 16:08:32 +0000 Received: from ediswmail.ad.cirrus.com (198.61.86.93) by EDIEX01.ad.cirrus.com (198.61.84.80) with Microsoft SMTP Server id 15.1.2375.18 via Frontend Transport; Mon, 17 Jan 2022 16:08:32 +0000 Received: from aryzen.ad.cirrus.com (unknown [198.61.64.122]) by ediswmail.ad.cirrus.com (Postfix) with ESMTP id 30A6646C; Mon, 17 Jan 2022 16:08:32 +0000 (UTC) From: Lucas Tanure To: Jaroslav Kysela , Takashi Iwai , Mark Brown CC: , , , Charles Keepax , Lucas Tanure Subject: [PATCH v2 2/6] ALSA: hda: cs35l41: Add calls to newly added test key function Date: Mon, 17 Jan 2022 16:08:26 +0000 Message-ID: <20220117160830.709403-2-tanureal@opensource.cirrus.com> X-Mailer: git-send-email 2.34.1 In-Reply-To: <20220117160830.709403-1-tanureal@opensource.cirrus.com> References: <20220117160830.709403-1-tanureal@opensource.cirrus.com> MIME-Version: 1.0 Content-Transfer-Encoding: 8bit Content-Type: text/plain X-Proofpoint-GUID: ppEl2H72LnyX2_9CGX-V0GQJPYmIQdqP X-Proofpoint-ORIG-GUID: ppEl2H72LnyX2_9CGX-V0GQJPYmIQdqP X-Proofpoint-Spam-Reason: safe Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org From: Charles Keepax The test key now needs to be manually held when calling cs35l41_register_errata_patch, after patch: Add the missing function calls to this driver. Fixes: f517ba4924ad ("ASoC: cs35l41: Add support for hibernate memory retention mode") Signed-off-by: Charles Keepax Signed-off-by: Lucas Tanure --- V2: Add Fixes tag --- sound/pci/hda/cs35l41_hda.c | 8 ++++++++ 1 file changed, 8 insertions(+) diff --git a/sound/pci/hda/cs35l41_hda.c b/sound/pci/hda/cs35l41_hda.c index c47c5f0b4e59..509a380f9be7 100644 --- a/sound/pci/hda/cs35l41_hda.c +++ b/sound/pci/hda/cs35l41_hda.c @@ -463,6 +463,10 @@ int cs35l41_hda_probe(struct device *dev, const char *device_name, int id, int i goto err; } + ret = cs35l41_test_key_unlock(cs35l41->dev, cs35l41->regmap); + if (ret) + goto err; + ret = cs35l41_register_errata_patch(cs35l41->dev, cs35l41->regmap, reg_revid); if (ret) goto err; @@ -473,6 +477,10 @@ int cs35l41_hda_probe(struct device *dev, const char *device_name, int id, int i goto err; } + ret = cs35l41_test_key_lock(cs35l41->dev, cs35l41->regmap); + if (ret) + goto err; + ret = cs35l41_hda_apply_properties(cs35l41, acpi_hw_cfg); if (ret) goto err; -- 2.34.1