Received: by 2002:a05:6a10:af89:0:0:0:0 with SMTP id iu9csp3365105pxb; Mon, 17 Jan 2022 18:42:01 -0800 (PST) X-Google-Smtp-Source: ABdhPJwT2jGUm3yX6aI0k9fvQkqtnJs64buNyhwJRhAdQqQrxnDNvtKk3wgkCzHDJPWKC9HqUeLP X-Received: by 2002:a63:7c07:: with SMTP id x7mr21567881pgc.549.1642473721401; Mon, 17 Jan 2022 18:42:01 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1642473721; cv=none; d=google.com; s=arc-20160816; b=r+jXP+4bmqq0DUFPdQTB5Yc3ZLMi97D1qeeozSWz75qbpURe2GR/zLGS+3/liG0ivr Or905mmQu+wX/jJOOpgfgiyll4wheuRT8tV1hcd94kzwDSnNGfcyHUC2wdnPPEseTgjM u5i6EmLGZ4xdLWg6BHNcMKJX7BmvEGU6mlyJjOSHxHyJ5+jxAp7/vJMPBzQedk8gpcbV q1ZdRLP83P1HOwpdTyYW+gRDJHbpzaStO6KxBDFq6EXlUjXjufpseIFzp/gSOABP0aSo Eo5h1wQ9G0NqH5mqBchDyJk1t50SimvhFCou1IyLeCU0FY8LdHtH49dQ1Cg8JzexzFRi KyVw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:content-transfer-encoding:mime-version :message-id:date:subject:cc:to:from:dkim-signature; bh=/H0K58++MtD3jpBaa9lUdA/393seXv0G5DUMon0OYX0=; b=yfodGfyjJi2Qh9QHHiWrJK3R2lEWUYeBFLWwglm8EgSYdiwRbcjvYuE1UgTDa3RpAN 6ea09s7NvIBJ9Hineuy+bMNLtxNkloC86UdsFjVkIWNkfIM9W5oKGjzxA4H8crBFmMOI twyAKr1DQ/f4ybANe6KFcRbaBdMZCmtyUJx8GeT/J2gz9WoFm31RF8vNj3maXRIk7Sy9 98uWLOk3WXOuhyu14RcdhY2Aj/pbzKfblw76viZKdWGUwXXNol9KoOJZ5yZPa1q/cHEE 3zbaXAwKq2BTFx4mKCTMFJaeCe/b1BQMVp2Ph3pvBCRF/bKHNNsjP3IGvl2ziNZfAoT3 FOXw== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@kernel.org header.s=k20201202 header.b=H9Y43t1t; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=kernel.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [23.128.96.18]) by mx.google.com with ESMTP id t2si14421971pfh.250.2022.01.17.18.41.49; Mon, 17 Jan 2022 18:42:01 -0800 (PST) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18; Authentication-Results: mx.google.com; dkim=pass header.i=@kernel.org header.s=k20201202 header.b=H9Y43t1t; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S241158AbiAQQ7D (ORCPT + 99 others); Mon, 17 Jan 2022 11:59:03 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:44458 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S237741AbiAQQ65 (ORCPT ); Mon, 17 Jan 2022 11:58:57 -0500 Received: from dfw.source.kernel.org (dfw.source.kernel.org [IPv6:2604:1380:4641:c500::1]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 85F0FC061574; Mon, 17 Jan 2022 08:58:57 -0800 (PST) Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by dfw.source.kernel.org (Postfix) with ESMTPS id 2599B61196; Mon, 17 Jan 2022 16:58:57 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id 557D6C36AE3; Mon, 17 Jan 2022 16:58:55 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1642438736; bh=jMvOlTe10aiL8xVey/HFWpKZibYbbP0tunjN77I5CEA=; h=From:To:Cc:Subject:Date:From; b=H9Y43t1tmAXNYlc//esilVi2HvXiRWDQ0sSUipvB08xhigdJpOWH4JmVufwTmt7Ge z1fmrq3zLZUqqdb6QdP2jBAbNHlpAy/nCPzRNqBIVdWjfrN8JO78tOGLS+ZepU7Ruc Xgdshv6/XV5JY3u4/iVkZKzt0e9C00TsJk3J9p4jLUKmfWD+j0q7HwI2piFC2poJTw l/Z+7VHXafimMl1BOpKmaDEbe+Z28m7vZj3DabFMLjnI0lOdID3H6Rt6c2UA6yMzD9 E2jD40O3LLfXLv2/U0WA8k1jKVsrJUFAkTfUuVUews9JrHHgFCA2lFt+V430SO3zmf 13NIjEX1gAICg== From: Sasha Levin To: linux-kernel@vger.kernel.org, stable@vger.kernel.org Cc: Changcheng Deng , Zeal Robot , Abel Vesa , Sasha Levin , mturquette@baylibre.com, sboyd@kernel.org, shawnguo@kernel.org, linux-clk@vger.kernel.org, linux-imx@nxp.com, linux-arm-kernel@lists.infradead.org Subject: [PATCH AUTOSEL 5.16 01/52] clk: imx: Use div64_ul instead of do_div Date: Mon, 17 Jan 2022 11:58:02 -0500 Message-Id: <20220117165853.1470420-1-sashal@kernel.org> X-Mailer: git-send-email 2.34.1 MIME-Version: 1.0 X-stable: review X-Patchwork-Hint: Ignore Content-Transfer-Encoding: 8bit Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org From: Changcheng Deng [ Upstream commit c1b6ad9a902539f9c037b6b3c35cb134c5724022 ] do_div() does a 64-by-32 division. Here the divisor is an unsigned long which on some platforms is 64 bit wide. So use div64_ul instead of do_div to avoid a possible truncation. Reported-by: Zeal Robot Signed-off-by: Changcheng Deng Reviewed-by: Abel Vesa Link: https://lore.kernel.org/r/20211118080634.165275-1-deng.changcheng@zte.com.cn Signed-off-by: Abel Vesa Signed-off-by: Sasha Levin --- drivers/clk/imx/clk-pllv3.c | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git a/drivers/clk/imx/clk-pllv3.c b/drivers/clk/imx/clk-pllv3.c index 20ee9611ba6e3..eea32f87c60aa 100644 --- a/drivers/clk/imx/clk-pllv3.c +++ b/drivers/clk/imx/clk-pllv3.c @@ -247,7 +247,7 @@ static long clk_pllv3_av_round_rate(struct clk_hw *hw, unsigned long rate, div = rate / parent_rate; temp64 = (u64) (rate - div * parent_rate); temp64 *= mfd; - do_div(temp64, parent_rate); + temp64 = div64_ul(temp64, parent_rate); mfn = temp64; temp64 = (u64)parent_rate; @@ -277,7 +277,7 @@ static int clk_pllv3_av_set_rate(struct clk_hw *hw, unsigned long rate, div = rate / parent_rate; temp64 = (u64) (rate - div * parent_rate); temp64 *= mfd; - do_div(temp64, parent_rate); + temp64 = div64_ul(temp64, parent_rate); mfn = temp64; val = readl_relaxed(pll->base); @@ -334,7 +334,7 @@ static struct clk_pllv3_vf610_mf clk_pllv3_vf610_rate_to_mf( /* rate = parent_rate * (mfi + mfn/mfd) */ temp64 = rate - parent_rate * mf.mfi; temp64 *= mf.mfd; - do_div(temp64, parent_rate); + temp64 = div64_ul(temp64, parent_rate); mf.mfn = temp64; } -- 2.34.1