Received: by 2002:a05:6a10:af89:0:0:0:0 with SMTP id iu9csp3365285pxb; Mon, 17 Jan 2022 18:42:16 -0800 (PST) X-Google-Smtp-Source: ABdhPJwmf4ObDKGhCdRCde1Rb41nq/Y3zD3u1pwptQFheeUcQn2H1QrJvWlxpTPM9XcqD/zuZpu6 X-Received: by 2002:a17:90b:1a8a:: with SMTP id ng10mr28005156pjb.175.1642473736189; Mon, 17 Jan 2022 18:42:16 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1642473736; cv=none; d=google.com; s=arc-20160816; b=CrCSpwwxkKWkGvdEP0rFT1xG4LpSm+fRTFJDnQyofp2ckXCX+NdT1sdsO76SXgE5vD F1PU3Q8bdz5UGhsfYdvEKJt3hhuCyg0FA7TY/BN+p0jlwsFY2xtS7jWW4riKPNYIBOeo 9mOTla1jTtxE1TURYxTrq3aRYpWHOSycmono592uXuhMR9RjxX7YkPHW2+WN5g9C5OSK yLg7NzA/BLVvYhwwkY4UCqAHXnLv+Th7xsd+Bg1sts4f0sC/923ThYU/KqLzJZlhiszf 0upnxde+DLGVOq3tt7n4r3UQxMYe+nO62AQWUrrmf3dSl3zAusTS4/AadqPMocSP9ggS ufZw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:content-transfer-encoding:mime-version :references:in-reply-to:message-id:date:subject:cc:to:from :dkim-signature; bh=l5PPQcl/DMcJjeWZyeKB8ahX55T1JEqIjDRLx6BpqXM=; b=ejVM/5GvhfaC0HS4Yym2SZV/Od6lWQMTc1KH83dyz5yq7X+KT7jG4mjGcmqQk7PEtE ORPlpccLEM+dCZ0KdSL/z9ePZkrzQ4Px/Kkk9vBgqGtFka8Cnyp5CDisXuFQUTpOUdAV bPkXlkYFqDf7cYWMxKfe+7sUiFwBpnVBRQTJDqRIpEVFC/PR1nWgKDJyXIP1kqvV18AE ku0PPeqPizaU1CbiXQMMUHro/v6vHOjJ5qK8gNPol3ts6r1+RFXOvZORknMFojVL9GnY 5mjPerLtqe6vN/nNiVr2vQz5SXCnMzGk0WjJ2geSAypl89JAUe6F3UPQWEIlkR7fwGT2 g8VQ== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@kernel.org header.s=k20201202 header.b=ckLq59fP; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=kernel.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [23.128.96.18]) by mx.google.com with ESMTP id k190si15464986pgk.353.2022.01.17.18.42.03; Mon, 17 Jan 2022 18:42:16 -0800 (PST) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18; Authentication-Results: mx.google.com; dkim=pass header.i=@kernel.org header.s=k20201202 header.b=ckLq59fP; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S241213AbiAQQ7Q (ORCPT + 99 others); Mon, 17 Jan 2022 11:59:16 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:44522 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S241161AbiAQQ7K (ORCPT ); Mon, 17 Jan 2022 11:59:10 -0500 Received: from dfw.source.kernel.org (dfw.source.kernel.org [IPv6:2604:1380:4641:c500::1]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 0ADFEC06161C; Mon, 17 Jan 2022 08:59:09 -0800 (PST) Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by dfw.source.kernel.org (Postfix) with ESMTPS id 54AA8611C6; Mon, 17 Jan 2022 16:59:09 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id 04766C36AE7; Mon, 17 Jan 2022 16:59:07 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1642438748; bh=noPkjLggVRzhHtJtUyyY8AiSqQGvqU0JZkwRb0GYV3U=; h=From:To:Cc:Subject:Date:In-Reply-To:References:From; b=ckLq59fPO9SqttJJShCYw+MSjWS0r6xL4jcKUtgdsOj9L+EjyHXPM9CYeOAcNlQ8t UTQQsqPFWphG8M40mTRIas4pGsSFEphxbA8wSc9yK4piGQ4spum69Cf4hQIYY2oORL g9AOHKd8WBDrpDt/Xn77CyMr8MhkVHEW+WLhW7Xbaw7Cz4zWB6qC3jpASu3SfkB9Ny e0nrZpbztBMLf8ZXtM294CWutlp4nbt+Sw8Idcza7OWHrm5v0hSnd8uBkDmGR01V91 Th2UEOm5wr6KoRt9rsvahLKoLbptE4QtD7UlXWc41qSdChtn8/7OvSFgRmrB6CRcRA OGrmMmp5iXBjw== From: Sasha Levin To: linux-kernel@vger.kernel.org, stable@vger.kernel.org Cc: Julia Lawall , Michael Ellerman , Sasha Levin , nick.child@ibm.com, linuxppc-dev@lists.ozlabs.org Subject: [PATCH AUTOSEL 5.16 06/52] powerpc/btext: add missing of_node_put Date: Mon, 17 Jan 2022 11:58:07 -0500 Message-Id: <20220117165853.1470420-6-sashal@kernel.org> X-Mailer: git-send-email 2.34.1 In-Reply-To: <20220117165853.1470420-1-sashal@kernel.org> References: <20220117165853.1470420-1-sashal@kernel.org> MIME-Version: 1.0 X-stable: review X-Patchwork-Hint: Ignore Content-Transfer-Encoding: 8bit Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org From: Julia Lawall [ Upstream commit a1d2b210ffa52d60acabbf7b6af3ef7e1e69cda0 ] for_each_node_by_type performs an of_node_get on each iteration, so a break out of the loop requires an of_node_put. A simplified version of the semantic patch that fixes this problem is as follows (http://coccinelle.lip6.fr): // @@ local idexpression n; expression e; @@ for_each_node_by_type(n,...) { ... ( of_node_put(n); | e = n | + of_node_put(n); ? break; ) ... } ... when != n // Signed-off-by: Julia Lawall Signed-off-by: Michael Ellerman Link: https://lore.kernel.org/r/1448051604-25256-6-git-send-email-Julia.Lawall@lip6.fr Signed-off-by: Sasha Levin --- arch/powerpc/kernel/btext.c | 4 +++- 1 file changed, 3 insertions(+), 1 deletion(-) diff --git a/arch/powerpc/kernel/btext.c b/arch/powerpc/kernel/btext.c index 803c2a45b22ac..1cffb5e7c38d6 100644 --- a/arch/powerpc/kernel/btext.c +++ b/arch/powerpc/kernel/btext.c @@ -241,8 +241,10 @@ int __init btext_find_display(int allow_nonstdout) rc = btext_initialize(np); printk("result: %d\n", rc); } - if (rc == 0) + if (rc == 0) { + of_node_put(np); break; + } } return rc; } -- 2.34.1