Received: by 2002:a05:6a10:af89:0:0:0:0 with SMTP id iu9csp3366136pxb; Mon, 17 Jan 2022 18:43:51 -0800 (PST) X-Google-Smtp-Source: ABdhPJwLbIS4cgg3fOc0mY4AnCSjoOvluJlnTW8EcQsXi6yta7H4Z0qfdfT90eE/6pMDlO9KnpFb X-Received: by 2002:a17:902:d503:b0:14a:6e28:5904 with SMTP id b3-20020a170902d50300b0014a6e285904mr25513941plg.114.1642473831371; Mon, 17 Jan 2022 18:43:51 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1642473831; cv=none; d=google.com; s=arc-20160816; b=DPWTqqUowWaiYXvhljg/reHDQKznrI2M1WCjYTQcGjnfB/QDuGmNHaK6z1IxBMI0eZ zt1rMfUqizP7To2Dd7L5g6Bl6OywUjE7AsMUuBVVpqi0h0FEDGSWtXlU/yvnPpMNy8SP cf9eStkWY8LsmvnD21r8+S8i88X/bNw9SH5FGNI6ZSVfZBs6d6p0jf5/DyNUxM3tLWKr qxKUMyh/mmXss4v9Z7qHnU0Dd3HySXwkGq1kz9OrDlcdN5fLSDcbmO6ihgi6RPW4/qCw 9Y1sOcZkJTRx4oaiv9y9OVUPI6WOAOYNxBNuWL89u8HdLlFqYAoEfRqZaXrke6tTZT27 G1vA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:content-transfer-encoding:mime-version :references:in-reply-to:message-id:date:subject:cc:to:from :dkim-signature; bh=ALqX+37duMxeg44pLgi9jmsZk6g/0dKGFyRQmOzYteA=; b=oUMc7tTT951kpwRdQxuOOEYTH2MxoTt1zGRi/U0Uk6DTW3mf+kqUsYe+pIFhyn6Nr3 MXKd05ZAF2wuzD5OweawlbQ5Frt4vJvw98l6xMTcB11qLWLBGWedaWysGd7GGOAhzO4U RGqw0Dm6AdtCk3QWoyTr9+ASFJxD+8K87x8gWAbZvngt0DZcvrjoNyVHF1R+jdFGSTBk Ow+D9/wibdkW2G45W4mSJWTP55sS9graZOObYQceNXzs3xWaRBQxplpGkdxdP0/z/fw8 0nch+K8/xpZjtIo2PQ7j7H+3F+4xMLpwzPpFcjdBJz2VK1u/6tgpCuX4kvx3M45+sHDu 3Dtg== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@kernel.org header.s=k20201202 header.b="p1E3b/3a"; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=kernel.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [23.128.96.18]) by mx.google.com with ESMTP id 15si6059890pgc.700.2022.01.17.18.43.38; Mon, 17 Jan 2022 18:43:51 -0800 (PST) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18; Authentication-Results: mx.google.com; dkim=pass header.i=@kernel.org header.s=k20201202 header.b="p1E3b/3a"; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S241545AbiAQRBv (ORCPT + 99 others); Mon, 17 Jan 2022 12:01:51 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:45078 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S241795AbiAQRAx (ORCPT ); Mon, 17 Jan 2022 12:00:53 -0500 Received: from ams.source.kernel.org (ams.source.kernel.org [IPv6:2604:1380:4601:e00::1]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 42E0CC061763; Mon, 17 Jan 2022 09:00:51 -0800 (PST) Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by ams.source.kernel.org (Postfix) with ESMTPS id 02C42B8113E; Mon, 17 Jan 2022 17:00:50 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id 9B0D1C36AE3; Mon, 17 Jan 2022 17:00:47 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1642438848; bh=vqm+l+et8fHmf+ZDrFYxAyjLbW9sX4AdX0B4LSjo1aY=; h=From:To:Cc:Subject:Date:In-Reply-To:References:From; b=p1E3b/3atEdyXJfPNyWoAjkL1drHzsh96miZe0YqvLW1Doe2SfoCrWh3h+YsxVFkC 3MryI3OHEV4634h0UmyzJDUpLPbMauAUmLsQMPGiejpVlxOma1/B7G66zhHEozNhHq 8wMjcKxiig4Kdb5VW1Z/cM8zv/glXXLeu4G3WN4aCRh09myy7XFqU2apV4ksCP4kny 01OUGsZBBnqB8Qqg4nneAuzcVEiTkGd683Z647N1qM0MhDb+qQcvZhj2nMXzlovVDR RAjcBqhakjBuujX7J+KAjzrQAEOiUUsagHqxkbIqZoO8Fhc9XkgLCBneyaHeNK2/Nv H8YdDjS3FoWgw== From: Sasha Levin To: linux-kernel@vger.kernel.org, stable@vger.kernel.org Cc: Tzung-Bi Shih , Mark Brown , Sasha Levin , lgirdwood@gmail.com, perex@perex.cz, tiwai@suse.com, matthias.bgg@gmail.com, jiaxin.yu@mediatek.com, alsa-devel@alsa-project.org, linux-arm-kernel@lists.infradead.org, linux-mediatek@lists.infradead.org Subject: [PATCH AUTOSEL 5.16 43/52] ASoC: mediatek: mt8192-mt6359: fix device_node leak Date: Mon, 17 Jan 2022 11:58:44 -0500 Message-Id: <20220117165853.1470420-43-sashal@kernel.org> X-Mailer: git-send-email 2.34.1 In-Reply-To: <20220117165853.1470420-1-sashal@kernel.org> References: <20220117165853.1470420-1-sashal@kernel.org> MIME-Version: 1.0 X-stable: review X-Patchwork-Hint: Ignore Content-Transfer-Encoding: 8bit Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org From: Tzung-Bi Shih [ Upstream commit 4e28491a7a198c668437f2be8a91a76aa52f20eb ] The of_parse_phandle() document: >>> Use of_node_put() on it when done. The driver didn't call of_node_put(). Fixes the leak. Signed-off-by: Tzung-Bi Shih Link: https://lore.kernel.org/r/20211214040028.2992627-1-tzungbi@google.com Signed-off-by: Mark Brown Signed-off-by: Sasha Levin --- sound/soc/mediatek/mt8192/mt8192-mt6359-rt1015-rt5682.c | 6 +++++- 1 file changed, 5 insertions(+), 1 deletion(-) diff --git a/sound/soc/mediatek/mt8192/mt8192-mt6359-rt1015-rt5682.c b/sound/soc/mediatek/mt8192/mt8192-mt6359-rt1015-rt5682.c index a606133951b70..24a5d0adec1ba 100644 --- a/sound/soc/mediatek/mt8192/mt8192-mt6359-rt1015-rt5682.c +++ b/sound/soc/mediatek/mt8192/mt8192-mt6359-rt1015-rt5682.c @@ -1172,7 +1172,11 @@ static int mt8192_mt6359_dev_probe(struct platform_device *pdev) return ret; } - return devm_snd_soc_register_card(&pdev->dev, card); + ret = devm_snd_soc_register_card(&pdev->dev, card); + + of_node_put(platform_node); + of_node_put(hdmi_codec); + return ret; } #ifdef CONFIG_OF -- 2.34.1