Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18;
MIME-Version: 1.0
References: <20220114234825.110502-1-martin.blumenstingl@googlemail.com>
 <20220114234825.110502-2-martin.blumenstingl@googlemail.com> <87k0eysgs9.fsf@kernel.org>
In-Reply-To: <87k0eysgs9.fsf@kernel.org>
From:   Martin Blumenstingl <martin.blumenstingl@googlemail.com>
Date:   Mon, 17 Jan 2022 18:48:30 +0100
Message-ID: <CAFBinCCnvO-CjjzSr0wkv6d-nin2Wa=GUbMMoUh02KD5aQWFoQ@mail.gmail.com>
Subject: Re: [PATCH 1/4] rtw88: pci: Change type of rtw_hw_queue_mapping() and
 ac_to_hwq to enum
To:     Kalle Valo <kvalo@kernel.org>
Cc:     linux-wireless@vger.kernel.org, tony0620emma@gmail.com,
        netdev@vger.kernel.org, linux-kernel@vger.kernel.org,
        Neo Jou <neojou@gmail.com>,
        Jernej Skrabec <jernej.skrabec@gmail.com>,
        Pkshih <pkshih@realtek.com>
Content-Type: text/plain; charset="UTF-8"
Precedence: bulk

Hi Kalle,

On Mon, Jan 17, 2022 at 1:11 PM Kalle Valo <kvalo@kernel.org> wrote:
[...]
> > -static u8 ac_to_hwq[] = {
> > +static enum rtw_tx_queue_type ac_to_hwq[] = {
> >       [IEEE80211_AC_VO] = RTW_TX_QUEUE_VO,
> >       [IEEE80211_AC_VI] = RTW_TX_QUEUE_VI,
> >       [IEEE80211_AC_BE] = RTW_TX_QUEUE_BE,
>
> Shouldn't ac_to_hwq be static const?
Good point, thanks for this suggestion!
I will include that in v2 of this series (which I will send in a few
days so others can share their thoughts about these patches as well).


Best regards,
Martin