Received: by 2002:a05:6a10:af89:0:0:0:0 with SMTP id iu9csp3372661pxb; Mon, 17 Jan 2022 18:55:48 -0800 (PST) X-Google-Smtp-Source: ABdhPJx6zKYT0tTmi2LCzyZ9MHbJWF3/HLkXFPodgWb7zVSLn0HJUBCHfCMM8TRA39oqL5T0QED4 X-Received: by 2002:a05:6a00:cd5:b0:4c3:26d5:9bff with SMTP id b21-20020a056a000cd500b004c326d59bffmr13588713pfv.20.1642474548457; Mon, 17 Jan 2022 18:55:48 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1642474548; cv=none; d=google.com; s=arc-20160816; b=XpO1RKj6+ASfrcBMj3rvrVWyrAF7ZPaGi2EZjyYq7J/BdJvMvWSMH2qDl/ZHdKlta5 Jz2i/fdPJWPYUtGovTPeIAG1nG6pHZa5GTG/HplFX/PIG8DrWx/V7Bkv6n/aFY7G66mH yQRjCQVU3zswGRBJwt/dZNkbXja7R+vlF67qQHd3NfgWubnWJ4uyi9quafHiQYHLXFD9 F1pWH20IgoFd/jqiGmCr0tvfRGT+yeJXOOLn7gTaaB/3tYnh0BGuuHBN3Ah8SLX6KHLE syHyBXh7G3nxSIz7ldh8qbLWVvvWECRwOmts1EM7OnsyyI+nCJ/kmX8WEhHuTTUDtYKv VreA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:in-reply-to:content-disposition:mime-version :references:message-id:subject:cc:to:from:date:dkim-signature; bh=bouPhsb4Ue1P9gCaopOfeEfpi1LBOvsEfL0wKx1nnuk=; b=r9PQEq2LcIOBHrZYCCH59d7W1twq8tEsANo8NBa09f9Hg3tvLFjEa2HCJ/AXhm5spE Nvi6/IJbkidsBLT9Lzp7Rb6LaXiB758BhKJMC1dvHCxfnKjVK1QOWsnhc2lc5vIGNYQd /2v9cuNERiLKDbZLcZ82y2GLtJU+A0RLHLA1UhU/1CCCzOxIDGxv1EgzlPWRR7B1x4uK p0XeUSbjyj7wP3tJPNIs1aO57YNzcIwerZjJwNDjckWgSnLw9lqTLpci9sTN8EjVk+cN QjydJ/8RxYk0CBCrzULxp/XkMm45nfz0bWFymBn6ldz/5IrQDCJcdjk3bgDve/qdm3Px 7HKg== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@alien8.de header.s=dkim header.b="mDoYwot/"; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=alien8.de Return-Path: Received: from vger.kernel.org (vger.kernel.org. [23.128.96.18]) by mx.google.com with ESMTP id n15si17793642plf.464.2022.01.17.18.55.35; Mon, 17 Jan 2022 18:55:48 -0800 (PST) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18; Authentication-Results: mx.google.com; dkim=pass header.i=@alien8.de header.s=dkim header.b="mDoYwot/"; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=alien8.de Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S242367AbiAQSOr (ORCPT + 99 others); Mon, 17 Jan 2022 13:14:47 -0500 Received: from mail.skyhub.de ([5.9.137.197]:44528 "EHLO mail.skyhub.de" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S242361AbiAQSOh (ORCPT ); Mon, 17 Jan 2022 13:14:37 -0500 Received: from zn.tnic (dslb-088-067-202-008.088.067.pools.vodafone-ip.de [88.67.202.8]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.skyhub.de (SuperMail on ZX Spectrum 128k) with ESMTPSA id D6CE41EC0531; Mon, 17 Jan 2022 19:14:31 +0100 (CET) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=alien8.de; s=dkim; t=1642443272; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:in-reply-to:in-reply-to: references:references; bh=bouPhsb4Ue1P9gCaopOfeEfpi1LBOvsEfL0wKx1nnuk=; b=mDoYwot/tXbqF6HF3Eu6cgDT6nKVaWMYS+m75E3dH7UqGWyU+ILZraeWnwVupdo2hXXsSv CRboS7T6LEo6JUkcCReWZM71LVGGJh7z2/0DIx9hY/4FpODkKkG830gFgc7uUkpKE4PNdb PzOQlEGzxt7kiupVj6JTD7J4vw9UsL4= Date: Mon, 17 Jan 2022 19:14:34 +0100 From: Borislav Petkov To: Brijesh Singh Cc: x86@kernel.org, linux-kernel@vger.kernel.org, kvm@vger.kernel.org, linux-efi@vger.kernel.org, platform-driver-x86@vger.kernel.org, linux-coco@lists.linux.dev, linux-mm@kvack.org, Thomas Gleixner , Ingo Molnar , Joerg Roedel , Tom Lendacky , "H. Peter Anvin" , Ard Biesheuvel , Paolo Bonzini , Sean Christopherson , Vitaly Kuznetsov , Jim Mattson , Andy Lutomirski , Dave Hansen , Sergio Lopez , Peter Gonda , Peter Zijlstra , Srinivas Pandruvada , David Rientjes , Dov Murik , Tobin Feldman-Fitzthum , Michael Roth , Vlastimil Babka , "Kirill A . Shutemov" , Andi Kleen , "Dr . David Alan Gilbert" , tony.luck@intel.com, marcorr@google.com, sathyanarayanan.kuppuswamy@linux.intel.com Subject: Re: [PATCH v8 30/40] x86/boot: add a pointer to Confidential Computing blob in bootparams Message-ID: References: <20211210154332.11526-1-brijesh.singh@amd.com> <20211210154332.11526-31-brijesh.singh@amd.com> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline In-Reply-To: <20211210154332.11526-31-brijesh.singh@amd.com> Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Fri, Dec 10, 2021 at 09:43:22AM -0600, Brijesh Singh wrote: > diff --git a/arch/x86/include/uapi/asm/bootparam.h b/arch/x86/include/uapi/asm/bootparam.h > index 1ac5acca72ce..bea5cdcdf532 100644 > --- a/arch/x86/include/uapi/asm/bootparam.h > +++ b/arch/x86/include/uapi/asm/bootparam.h > @@ -188,7 +188,8 @@ struct boot_params { > __u32 ext_ramdisk_image; /* 0x0c0 */ > __u32 ext_ramdisk_size; /* 0x0c4 */ > __u32 ext_cmd_line_ptr; /* 0x0c8 */ > - __u8 _pad4[116]; /* 0x0cc */ > + __u8 _pad4[112]; /* 0x0cc */ > + __u32 cc_blob_address; /* 0x13c */ > struct edid_info edid_info; /* 0x140 */ > struct efi_info efi_info; /* 0x1c0 */ > __u32 alt_mem_k; /* 0x1e0 */ Yes, you said that this is a boot/compressed stage -> kernel proper info pass field but let's document it anyway, please, and say what it is, just like: 1E4/004 ALL scratch Scratch field for the kernel setup code is documented, for example. And now that I look at it, acpi_rsdp_addr isn't documented either so if you wanna add it too, while you're at it, that would be nice. Thx. -- Regards/Gruss, Boris. https://people.kernel.org/tglx/notes-about-netiquette