Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18;
Subject: Re: [PATCH] drm/radeon: fix UVD suspend error
To:     Qiang Ma <maqianga@uniontech.com>, alexander.deucher@amd.com,
        christian.koenig@amd.com, Xinhui.Pan@amd.com, airlied@linux.ie,
        daniel@ffwll.ch
Cc:     dri-devel@lists.freedesktop.org, amd-gfx@lists.freedesktop.org,
        linux-kernel@vger.kernel.org
References: <20220117074731.29882-1-maqianga@uniontech.com>
From:   Leo Liu <leo.liu@amd.com>
Message-ID: <581d4658-0f12-f355-0c4c-4b0da9b23d61@amd.com>
Date:   Mon, 17 Jan 2022 15:05:00 -0500
User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:78.0) Gecko/20100101
 Thunderbird/78.14.0
In-Reply-To: <20220117074731.29882-1-maqianga@uniontech.com>
Content-Type: text/plain; charset=utf-8; format=flowed
Content-Transfer-Encoding: 7bit
Content-Language: en-US
MIME-Version: 1.0
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?dnVSSlc5aitrSnF3M3hIY3F6S0kySGljeEU4N0wwTFluRVhtYlNJWlo0MkJN?=
 =?utf-8?B?SlNYTUV5OU5hV1VMT0N3elZJYUN1Tm1UNnhBRm0wT0JPbmtCS2FQclQ0bEc5?=
 =?utf-8?B?SVFsNDRDUjI1U20xdWw2VERTc2lKOGxqR0ppVXlzUndodlFGb3ZZZ0trSGRJ?=
 =?utf-8?B?Q2hCYWNMYlZwWU1DVDNnZmo1N3p1NCtVVlBVSVNTWmlBZHV2dzFEMUdzdjk0?=
 =?utf-8?B?NnZ1RlFWVmIxZld3UW9OMlVaRXdVM2VEZlpNVkJNSVV6aEpIYVNjZ2dsUk9P?=
 =?utf-8?B?ajk5cmx2dFRpTE1HMnVxQXlkdEZHeGZ1blF3aWxkZ2h4NnBlV05XcTl3azZr?=
 =?utf-8?B?aFNGdkNGU1dHaXhBd0NxMTVzUnNTYU5hYTYvK2J2eWMrbVR2L1BCSzlldDhH?=
 =?utf-8?B?NWI0MkZrNS9OdkFIbHdva1l0R0hHK2lCVTk3VVFRRHp1cEZCWlZNMGV5OTFp?=
 =?utf-8?B?clh5MkhrdGNSVUFVcGNNNjBBNkZkQ0FyWDdITURLSzRVVkJuMkltSTlUVTRn?=
 =?utf-8?B?aE5GYlEyaDA0YjNzRWRHSG5BRjFJRUFrOUEvVERaRVNsVmNkTmdhenV1Qisy?=
 =?utf-8?B?M3FPTGs0ZDBwbk9XYXBSMVZWZmU5c2RGaFNiQmtSQkZndDFNeERHZmRmWmRr?=
 =?utf-8?B?ZUlEeFZlaW1hd3p4MkEwZC9iV2hrb0MwOS90M0hNQUtFdnlKdDd4SFEwSUpn?=
 =?utf-8?B?N2lONTJDOW5vOEtaaFZlLzYxOTJOalU4dGxEMXU3QUdDOFZZMjRseW5XaWQy?=
 =?utf-8?B?TDRzd0tzcmV6bGNvemRXR2hicE1OalRJV1RiRHAyeE1aSC96WXZ5djhtOFl4?=
 =?utf-8?B?eXpKaHJyYk9hT2xHTEd0anI5YUdKeHVYRU5kcEJJUGl3M3pxY0paNEZxYXNo?=
 =?utf-8?B?eTk5aURNV0M3UlczTHlZcWVSUmFzaVV4M3hqK0c5VTE2Y3hlK1Q5cEI2WTNj?=
 =?utf-8?B?eG1MZml3V3luaVhMUjBiQWE2NXUvZVZjZnRBZmdWZ1ZxUUJETjRlTXlHNEI5?=
 =?utf-8?B?R3ZQK0FwdUxzZTQ3eUc5TUNiQkJzREhOeE45RzdqZzkzZkFLTEwvSC9jcEpH?=
 =?utf-8?B?WlhXc3JxNzlNUTloLzB1dE1NWVdUa3NyVzNxZ0FGYjNvcldNOUZpREs1Zm81?=
 =?utf-8?B?WmNpTkg1bE9KY0pSZUl2ZWg5SkRLL2xVVUt3Q0Vsdk1GaTMxMzZyR1J3aXZN?=
 =?utf-8?B?OWtoRG1DSEFNRUlGL2JGcCtpVXIva3ZXalFNMmtUZFdEaTErZFRIVWxCTjNq?=
 =?utf-8?B?ejlyYlF3Z2RGTWR6M3pQSHpwN3BkYzRnOWJUaDBoY3pIakJvTDR0Q2pGMXEz?=
 =?utf-8?B?R3VlTGVDMmpKRjE1cUdWd2MxRGlSVWtkVXhldHFaK3M0SGp3U2VPU0tTZFhh?=
 =?utf-8?B?QXM2MFVISEluMnRmM2FVVkVVMFRzYk14VHlSc2dUNG5mbnlSM09ab21LVHBV?=
 =?utf-8?B?QmlqVVNIVXh2U1JCSllUWFlrb1pKTkUvdytkdGdVNHNlQ1F2ZTFUcUFoakJj?=
 =?utf-8?B?U0RrdU1LMHRZTTFyL2JOL3NwQUU3K3pTOUx1eUEvMEFCMGh5MUd3OXNMQ2Fk?=
 =?utf-8?B?OGNTZmg3WGxyMlpQdEl0emhUS0NBVXg2UWN0L1M2T0s2VzE2anQxQ25qRmVp?=
 =?utf-8?B?SHI3bFowOWxyOFZoWFIzVlJqem8wU3VWc0xhZzB2dW9CbSt1d0VYTzQ3SFh1?=
 =?utf-8?B?dVgxS2J5UDgwbTgvTGpXRXV5Q0t2QmR4Ym5ZeUZnVTNmand4d1RwNndjMkww?=
 =?utf-8?B?WTdOQ2g5dmp3ekwzZ0FlZVY1T1pWZjdXRzBTemhMYlJZYUNtcjdEeVBVTlhH?=
 =?utf-8?B?d2E0bGc0WkxTWXZqNkRPWmpTaWlJQmN6MCtzUVppOTFVNWtCRnpSQWpxVzZr?=
 =?utf-8?B?VzY2NzRuYlJXaTFiQVBiYXZiQmdXMFFMOU80dGQ1VWtiODVsMWFrNjNzbWk3?=
 =?utf-8?B?SmNYT2VYMUJTb2drYVZjU2NZQjVVT0YycStRS0h4cEVyWkl5SS9xdkNzeGp5?=
 =?utf-8?B?MHZlWG1yVmFjYTZBYjZ4U3lTV05GQVQ5Mld1OXRZNW9iQ2hUcjZFT1NUbFhL?=
 =?utf-8?B?cG1nVjhHR09BbVNOd29EblhPdU43cHVRQ1llTFpUdGg5OUJXVnc3YVV6aW9Z?=
 =?utf-8?Q?AU5k=3D?=
X-OriginatorOrg: amd.com
X-MS-Exchange-CrossTenant-Network-Message-Id: 318d0b4b-181c-414e-a68f-08d9d9f4a604
X-MS-Exchange-CrossTenant-AuthSource: DM8PR12MB5399.namprd12.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 17 Jan 2022 20:05:03.2226
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: 3dd8961f-e488-4e60-8e11-a82d994e183d
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: pHjsoINx0ksRGjp438Tv0YWBclecunZmekHqckRmfSkg60xTEBfAMoWlEekPeLI/
X-MS-Exchange-Transport-CrossTenantHeadersStamped: CY4PR12MB1158
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org


On 2022-01-17 2:47 a.m., Qiang Ma wrote:
> I met a bug recently and the kernel log:
>
> [  330.171875] radeon 0000:03:00.0: couldn't schedule ib
> [  330.175781] [drm:radeon_uvd_suspend [radeon]] *ERROR* Error destroying UVD (-22)!
>
> In radeon drivers, using UVD suspend is as follows:
>
> if (rdev->has_uvd) {
>          uvd_v1_0_fini(rdev);
>          radeon_uvd_suspend(rdev);
> }
>
> In radeon_ib_schedule function, we check the 'ring->ready' state,
> but in uvd_v1_0_fini funciton, we've cleared the ready state.
> So, just modify the suspend code flow to fix error.

It seems reasonable to me. The suspend sends the destroy message if 
there is still incomplete job, so it should be before the fini which 
stops the hardware.

The series are:

Reviewed-by: Leo Liu <leo.liu@amd.com>


>
> Signed-off-by: Qiang Ma <maqianga@uniontech.com>
> ---
>   drivers/gpu/drm/radeon/cik.c       | 2 +-
>   drivers/gpu/drm/radeon/evergreen.c | 2 +-
>   drivers/gpu/drm/radeon/ni.c        | 2 +-
>   drivers/gpu/drm/radeon/r600.c      | 2 +-
>   drivers/gpu/drm/radeon/rv770.c     | 2 +-
>   drivers/gpu/drm/radeon/si.c        | 2 +-
>   6 files changed, 6 insertions(+), 6 deletions(-)
>
> diff --git a/drivers/gpu/drm/radeon/cik.c b/drivers/gpu/drm/radeon/cik.c
> index 81b4de7be9f2..5819737c21c6 100644
> --- a/drivers/gpu/drm/radeon/cik.c
> +++ b/drivers/gpu/drm/radeon/cik.c
> @@ -8517,8 +8517,8 @@ int cik_suspend(struct radeon_device *rdev)
>   	cik_cp_enable(rdev, false);
>   	cik_sdma_enable(rdev, false);
>   	if (rdev->has_uvd) {
> -		uvd_v1_0_fini(rdev);
>   		radeon_uvd_suspend(rdev);
> +		uvd_v1_0_fini(rdev);
>   	}
>   	if (rdev->has_vce)
>   		radeon_vce_suspend(rdev);
> diff --git a/drivers/gpu/drm/radeon/evergreen.c b/drivers/gpu/drm/radeon/evergreen.c
> index eeb590d2dec2..455f8036aa54 100644
> --- a/drivers/gpu/drm/radeon/evergreen.c
> +++ b/drivers/gpu/drm/radeon/evergreen.c
> @@ -5156,8 +5156,8 @@ int evergreen_suspend(struct radeon_device *rdev)
>   	radeon_pm_suspend(rdev);
>   	radeon_audio_fini(rdev);
>   	if (rdev->has_uvd) {
> -		uvd_v1_0_fini(rdev);
>   		radeon_uvd_suspend(rdev);
> +		uvd_v1_0_fini(rdev);
>   	}
>   	r700_cp_stop(rdev);
>   	r600_dma_stop(rdev);
> diff --git a/drivers/gpu/drm/radeon/ni.c b/drivers/gpu/drm/radeon/ni.c
> index 4a364ca7a1be..927e5f42e97d 100644
> --- a/drivers/gpu/drm/radeon/ni.c
> +++ b/drivers/gpu/drm/radeon/ni.c
> @@ -2323,8 +2323,8 @@ int cayman_suspend(struct radeon_device *rdev)
>   	cayman_cp_enable(rdev, false);
>   	cayman_dma_stop(rdev);
>   	if (rdev->has_uvd) {
> -		uvd_v1_0_fini(rdev);
>   		radeon_uvd_suspend(rdev);
> +		uvd_v1_0_fini(rdev);
>   	}
>   	evergreen_irq_suspend(rdev);
>   	radeon_wb_disable(rdev);
> diff --git a/drivers/gpu/drm/radeon/r600.c b/drivers/gpu/drm/radeon/r600.c
> index ca3fcae2adb5..dd78fc499402 100644
> --- a/drivers/gpu/drm/radeon/r600.c
> +++ b/drivers/gpu/drm/radeon/r600.c
> @@ -3232,8 +3232,8 @@ int r600_suspend(struct radeon_device *rdev)
>   	radeon_audio_fini(rdev);
>   	r600_cp_stop(rdev);
>   	if (rdev->has_uvd) {
> -		uvd_v1_0_fini(rdev);
>   		radeon_uvd_suspend(rdev);
> +		uvd_v1_0_fini(rdev);
>   	}
>   	r600_irq_suspend(rdev);
>   	radeon_wb_disable(rdev);
> diff --git a/drivers/gpu/drm/radeon/rv770.c b/drivers/gpu/drm/radeon/rv770.c
> index e592e57be1bb..38796af4fadd 100644
> --- a/drivers/gpu/drm/radeon/rv770.c
> +++ b/drivers/gpu/drm/radeon/rv770.c
> @@ -1894,8 +1894,8 @@ int rv770_suspend(struct radeon_device *rdev)
>   	radeon_pm_suspend(rdev);
>   	radeon_audio_fini(rdev);
>   	if (rdev->has_uvd) {
> -		uvd_v1_0_fini(rdev);
>   		radeon_uvd_suspend(rdev);
> +		uvd_v1_0_fini(rdev);
>   	}
>   	r700_cp_stop(rdev);
>   	r600_dma_stop(rdev);
> diff --git a/drivers/gpu/drm/radeon/si.c b/drivers/gpu/drm/radeon/si.c
> index 013e44ed0f39..8d5e4b25609d 100644
> --- a/drivers/gpu/drm/radeon/si.c
> +++ b/drivers/gpu/drm/radeon/si.c
> @@ -6800,8 +6800,8 @@ int si_suspend(struct radeon_device *rdev)
>   	si_cp_enable(rdev, false);
>   	cayman_dma_stop(rdev);
>   	if (rdev->has_uvd) {
> -		uvd_v1_0_fini(rdev);
>   		radeon_uvd_suspend(rdev);
> +		uvd_v1_0_fini(rdev);
>   	}
>   	if (rdev->has_vce)
>   		radeon_vce_suspend(rdev);