Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18;
From:   Peng Fan <peng.fan@nxp.com>
To:     Mathieu Poirier <mathieu.poirier@linaro.org>,
        "Peng Fan (OSS)" <peng.fan@oss.nxp.com>
CC:     "bjorn.andersson@linaro.org" <bjorn.andersson@linaro.org>,
        "shawnguo@kernel.org" <shawnguo@kernel.org>,
        "s.hauer@pengutronix.de" <s.hauer@pengutronix.de>,
        "kernel@pengutronix.de" <kernel@pengutronix.de>,
        "festevam@gmail.com" <festevam@gmail.com>,
        dl-linux-imx <linux-imx@nxp.com>,
        "linux-remoteproc@vger.kernel.org" <linux-remoteproc@vger.kernel.org>,
        "linux-arm-kernel@lists.infradead.org" 
        <linux-arm-kernel@lists.infradead.org>,
        "linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>
Subject: RE: [PATCH] remoteproc: imx_rproc: validate resource table
Thread-Topic: [PATCH] remoteproc: imx_rproc: validate resource table
Thread-Index: AQHYBpwmO5aK4OtvYkq+yuw1fYEnI6xnkheAgAB0wYA=
Date:   Tue, 18 Jan 2022 01:24:38 +0000
Message-ID: <DU0PR04MB9417BEA67ED9C2185C5C874A88589@DU0PR04MB9417.eurprd04.prod.outlook.com>
References: <20220111033333.403448-1-peng.fan@oss.nxp.com>
 <20220111033333.403448-2-peng.fan@oss.nxp.com>
 <20220117182551.GC1119324@p14s>
In-Reply-To: <20220117182551.GC1119324@p14s>
Accept-Language: en-US
Content-Language: en-US
x-ms-exchange-antispam-messagedata-chunkcount: 1
x-ms-exchange-antispam-messagedata-0: =?us-ascii?Q?iwl0VuqGhpPW7at4mpdvEg3kHOK19MmyHnpR2FP4IeGBk4aJW4reAyLiP8yv?=
 =?us-ascii?Q?yeuBxGdVCMyMwYA+ZiTFmonzPdXsDUP48NCZAlWLUOvFs58mBln3FeaQG89l?=
 =?us-ascii?Q?5iJpjnrdk5SYOSRqdOAfxjYjP6CljVnoRTVmXrCROt1Jw1PJR9EzDD1AJ6RD?=
 =?us-ascii?Q?XntGLK7QQMUO0EdEWHVqTMePdHbaVfwWG/8rCdlbFU/ccMnI39dB9tgUBjhN?=
 =?us-ascii?Q?4E29mqv9yOHHigA3RaB3DOiQjuDIV6JZCMjsFE4dJz+YoTNXf3oX+K/4ofEf?=
 =?us-ascii?Q?+CV6/48uxbSyO3Z7ZJlS+MBxQrHJ/VdgGvQjXSShIoiiipITcPcWyM4sgzus?=
 =?us-ascii?Q?VAi3tx9hBWNr1CdynU0EOZmIVhCwPEDAO1rUn0Jb71lgBPO+NWOZKw7cQbf2?=
 =?us-ascii?Q?M7z2UKDTqCQsjE91q4nP3tOmPlcWquDrvFYKtPtwnI4DSsuVjW9FuK+fGUOE?=
 =?us-ascii?Q?lioHR6Zz1EcsA351YTT6otgP+f8E4gX9/+Ll8JxZjbwSO3D2V2svyQXHisS+?=
 =?us-ascii?Q?4BCtAS8PGeDHWHnZF9nDUTuYiKW9JYxNpXCuYY0F/Z9GXI4nj0IZ5otMrIE7?=
 =?us-ascii?Q?lZgowHl4pjNj0e2RDWdwhCPbBySmxUGoJXV6UuBALe81OvVVwiNc7vC9Xas2?=
 =?us-ascii?Q?R2rev77y3XtYVSIgrzM5rtFRyQ/JoAZ8avHpsZtif0Eg/PwgDIqbb9MzN6rm?=
 =?us-ascii?Q?vZJd00xEQhkGyi/9gHW5JLVzSlae4nNm4zW/R+RyLfzj7KhsvbeI7ngVHa4W?=
 =?us-ascii?Q?0q6hOQ8sqEe9jrZTG8JkrfmPiZQCnYkqerqQRABDBlN3GTrKJ3PXTzOMKoux?=
 =?us-ascii?Q?PS7dPr62TO64OroAQn4R4H/ytVXXq6kGTGzaNj2W2HzCFnag0ciWYqYoLtfC?=
 =?us-ascii?Q?Z+nYbQ3N+x2Cfoui/L/ElagnOLbYbcG1tqd+KJUfwKJXRL1H79RJJgzM69T5?=
 =?us-ascii?Q?Acz/vU8pLjQpzBlw4kSSlpKfWG3Dcf/dgmfTWM8NslzlJ+gCWoeCyluBqCgo?=
 =?us-ascii?Q?sWjeAaEeR7Jlfdauxl1KWWj+88C92owyKjbYPXxLBSRSdyYnIzOIZBw07EO/?=
 =?us-ascii?Q?SM/V47hMjLejcjbWJpnc9vuowZ3VXvw8nAhMkCFMrQ7pOyrsdNe6wXlkW8pW?=
 =?us-ascii?Q?mDcfgr9MCUI9hhr8f/Pwp/9Mc4yY1rUGHK88i1/JGSb8cxZF2zc11xs06Nmn?=
 =?us-ascii?Q?mZcwR3TnOigujynvPvTTAkyyuxRtG41DEfTOVhtyaVoLd63thxVhscf1FRvs?=
 =?us-ascii?Q?8+lqAs/KJ2fe0SEwPzvcTlblcbsPhlNqJBBZLULt3kbbZZvuNJWPGZHCHNNT?=
 =?us-ascii?Q?gnF8k5+lLLvRys9h94PJ/Ms7CeGj/o9c597cP6CJOj6wJIMWpPyGYBUbRwgm?=
 =?us-ascii?Q?xuz8iyFQHmKcb2m6hIBXIv36cUxr85jV/Cj73Mfc56no5+we/r+ARj4EDTuV?=
 =?us-ascii?Q?bIWJxFM5QYzGDkeJvDYYUdLxrLXX9mI/QkXgW2F7/lIwA2OMNJUqcEN9Y3rK?=
 =?us-ascii?Q?EQme3/YxFLkqT+XsKPcRi4bktRzYsUIHnrCENJ7qh/OK0vLCyRHaeOGRFAzs?=
 =?us-ascii?Q?YQYDvT2BDVnybxahUnsKiERVlFsJpk+SVoGzw+MYxhkTs0mYC2ir9PSOZspJ?=
 =?us-ascii?Q?FA=3D=3D?=
Content-Type: text/plain; charset="us-ascii"
Content-Transfer-Encoding: quoted-printable
MIME-Version: 1.0
X-OriginatorOrg: nxp.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-AuthSource: DU0PR04MB9417.eurprd04.prod.outlook.com
X-MS-Exchange-CrossTenant-Network-Message-Id: 88e54e93-c505-4193-90f5-08d9da214b77
X-MS-Exchange-CrossTenant-originalarrivaltime: 18 Jan 2022 01:24:38.3745
 (UTC)
X-MS-Exchange-CrossTenant-fromentityheader: Hosted
X-MS-Exchange-CrossTenant-id: 686ea1d3-bc2b-4c6f-a92c-d99c5c301635
X-MS-Exchange-CrossTenant-mailboxtype: HOSTED
X-MS-Exchange-CrossTenant-userprincipalname: R1BFZCnVUAStr93Vxejub1E6Bp+kVG5P2K+LVu6BG2QHmQHNN3cl6ZXYon3+1ZKBIOo+uQju72PJta8BoO19CA==
X-MS-Exchange-Transport-CrossTenantHeadersStamped: AS8PR04MB7958
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

> Subject: Re: [PATCH] remoteproc: imx_rproc: validate resource table
>=20
> Good morning,
>=20
> On Tue, Jan 11, 2022 at 11:33:23AM +0800, Peng Fan (OSS) wrote:
> > From: Peng Fan <peng.fan@nxp.com>
> >
> > Currently NXP use one device tree to support all NXP released Cortex-M
> > demos. There is one simple demo that not need to communicate with
> > Linux, thus it will not update the resource table. So there maybe
> > garbage data in it. In such case, Linux should directly ignore it.
> >
> > It is hard to decide what data is garbage data, NXP released SDK use
> > ver(1), reserved(0) in a valid resource table. But in case others use
> > different value, so here use 0xff as a max value for ver and num.
> >
> > Signed-off-by: Peng Fan <peng.fan@nxp.com>
> > ---
> >  drivers/remoteproc/imx_rproc.c | 8 ++++++++
> >  1 file changed, 8 insertions(+)
> >
> > diff --git a/drivers/remoteproc/imx_rproc.c
> > b/drivers/remoteproc/imx_rproc.c index 0bd24c937a73..75fde16f80a4
> > 100644
> > --- a/drivers/remoteproc/imx_rproc.c
> > +++ b/drivers/remoteproc/imx_rproc.c
> > @@ -490,11 +490,19 @@ static int imx_rproc_attach(struct rproc *rproc)
> > static struct resource_table *imx_rproc_get_loaded_rsc_table(struct
> > rproc *rproc, size_t *table_sz)  {
> >  	struct imx_rproc *priv =3D rproc->priv;
> > +	struct resource_table *table;
> >
> >  	/* The resource table has already been mapped in imx_rproc_addr_init
> */
> >  	if (!priv->rsc_table)
> >  		return NULL;
> >
> > +	table =3D priv->rsc_table;
> > +	/* Gabage data check */
> > +	if (table->ver >=3D 0xff || table->num >=3D 0xff || table->reserved[0=
] ||
> table->reserved[1]) {
> > +		dev_err(priv->dev, "Ignore invalid rsc table\n");
> > +		return NULL;
> > +	}
> > +
>=20
> This seems like the wrong fix to me.  Either use different DTs or update =
the
> resource table for all demos - efficiency should not be a problem since t=
hey
> are demos.  With the above it is only a matter of time before the pattern
> associated with valid resource tables changes, leading to more hacks that=
 will
> be impossible to maintain over time.

I see, drop this patch :)

Thanks,
Peng.

>=20
> Thanks,
> Mathieu
>=20
> >  	*table_sz =3D SZ_1K;
> >  	return (struct resource_table *)priv->rsc_table;  }
> > --
> > 2.25.1
> >