Date: Sun, 4 Feb 2007 11:18:43 +0100 (CET)
From: Tim Schmielau <tim@physik3.uni-rostock.de>
To: Mathieu Desnoyers <mathieu.desnoyers@polymtl.ca>
cc: linux-kernel@vger.kernel.org, Andrew Morton <akpm@osdl.org>,
       Ingo Molnar <mingo@redhat.com>
Subject: Re: [PATCH] kernel/time/clocksource.c needs struct task_struct on
 m68k
In-Reply-To: <20070204062211.GA10674@Krystal>
Message-ID: <Pine.LNX.4.63.0702041112560.8256@gockel.physik3.uni-rostock.de>
References: <20070204062211.GA10674@Krystal>
MIME-Version: 1.0
Content-Type: TEXT/PLAIN; charset=US-ASCII
Sender: linux-kernel-owner@vger.kernel.org
Content-Length: 1013
Lines: 23

On Sun, 4 Feb 2007, Mathieu Desnoyers wrote:

> kernel/time/clocksource.c needs struct task_struct on m68k.
> 
> Because it uses spin_unlock_irq(), which, on m68k, uses hardirq_count(), which
> uses preempt_count(), which needs to dereference struct task_struct, we
> have to include sched.h. Because it would cause a loop inclusion, we
> cannot include sched.h in any other of asm-m68k/system.h,
> linux/thread_info.h, linux/hardirq.h, which leaves this ugly include in
> a C file as the only simple solution.

This indeed sounds quite ugly. If there really is no other simple way to 
resolve this, this case seems to provide the missing incentive to create a 
task_struct.h header file.

Unfortunately, I currently cannot foresee when I will have time to do so.

Tim
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/