Received: by 2002:a05:6a10:af89:0:0:0:0 with SMTP id iu9csp5235175pxb; Wed, 19 Jan 2022 14:05:08 -0800 (PST) X-Google-Smtp-Source: ABdhPJyxUfhvRERTqL7fcXIe/bsH9AURsjvl0xL/BbVaxs0Cqbxve8yaD4+InbuFmm+fRbs3zWBZ X-Received: by 2002:a63:6c03:: with SMTP id h3mr28977519pgc.458.1642629908108; Wed, 19 Jan 2022 14:05:08 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1642629908; cv=none; d=google.com; s=arc-20160816; b=UKisqxJuHH9PtD5a6uCXqPoXQq67ROd5fnBLCEgyWHxzfBenQ91CyerHSj8BQ/+go3 yM+ZucbWkQg3AsiNty2UXMY8p+EW3GK4j+h66bNjN/vLKr++pcf9t4MScpx1McO3h2Ip 3k4bj2tc4afWDVjxkE5MGWccrGF1DuW9jk5reo4PGlrl7SA2jBP/eS9hC5lPgHbsXovI iXrTENWeSk9TzBlFIHCwyPJJCv8eaIiPXrduExwo+TjJ2XyBPCDfnBPNy3TymWHEnEab rmKdDOG8UfCDe3EreFOobadZx/eoqKFH7t/+5sEK8hCi7IfwA9ASs53cM2oKD2bgVg3+ xqIg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:content-transfer-encoding:mime-version :message-id:date:subject:cc:to:from:dkim-signature; bh=oVASYcnUzo//aC4Lo3/46A3KtVN0oXM5tvWTeJ4jCZ8=; b=M6HWEYm2x/S3fwxpm/RuH26Rl8vjBxUJa8A03kOGgjPGljBo0frjinl/Vub+jZHqp8 lmD5tyZEIvyj3xmL0yHeP5LtsSd8Rxf/mrSmP070she1vwd9QhZN5cXCg9xF3F0VxYG4 rGWmB23Fm6mzHdQ6xG2aAYFF/YpbSfFELM45EbRNQRp13Dt53GxzbCODH761bXkzAggM HO5WyfzuVThiPMRXdaWOeCh/B18AnO79y1wNZrk7amslUJtKZNPv5he1kQVDNOTSRjaS UVQuAa5e0PCbtLLnNVc9jNNPBjPkfaSOg1139EWO7NcQ2Ae5DG4DHBBAxoVWWxZ+EUyT vt9g== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@gmail.com header.s=20210112 header.b=dFYGMojL; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=QUARANTINE dis=NONE) header.from=gmail.com Return-Path: Received: from vger.kernel.org (vger.kernel.org. [23.128.96.18]) by mx.google.com with ESMTP id n9si789386plk.379.2022.01.19.14.04.48; Wed, 19 Jan 2022 14:05:08 -0800 (PST) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18; Authentication-Results: mx.google.com; dkim=pass header.i=@gmail.com header.s=20210112 header.b=dFYGMojL; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=QUARANTINE dis=NONE) header.from=gmail.com Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S235988AbiARH5R (ORCPT + 99 others); Tue, 18 Jan 2022 02:57:17 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:50480 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S231722AbiARH5M (ORCPT ); Tue, 18 Jan 2022 02:57:12 -0500 Received: from mail-qt1-x82e.google.com (mail-qt1-x82e.google.com [IPv6:2607:f8b0:4864:20::82e]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 0C80DC061574 for ; Mon, 17 Jan 2022 23:57:12 -0800 (PST) Received: by mail-qt1-x82e.google.com with SMTP id l17so21390279qtk.7 for ; Mon, 17 Jan 2022 23:57:12 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; h=from:to:cc:subject:date:message-id:mime-version :content-transfer-encoding; bh=oVASYcnUzo//aC4Lo3/46A3KtVN0oXM5tvWTeJ4jCZ8=; b=dFYGMojLFUBw1OMQjj6HwqnFRyARImliTcO5d7rybcEcORxWEfUGG7jjQtc9PHvOhb FTa0uKEgRc18PNWHHcixKTxZa+PX1QMKX20DuT5ma1QOhCgYVM22WgljjR4LB6SlXNYp jif/sq0cmvxhBSQ0kOaqsHsd3B+bEeDTxG7Chlz4Zd5FUfDSSeCgGJLCJ9l2AYOlGAPM 6TzP+9gN33/WW2NlNFUROaL87ApVOyv1AgPoG5yMDqSOPrbMz3ES6zeZ12yOapBa7nk4 I+IxRKwRqZYxPiW7qZNqrvhv1zLwawkF9wvs2u2JyItB1A8c2cCboH1TPGHCDcV8cShI a05Q== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:from:to:cc:subject:date:message-id:mime-version :content-transfer-encoding; bh=oVASYcnUzo//aC4Lo3/46A3KtVN0oXM5tvWTeJ4jCZ8=; b=s3qijnV5ydZtp3rtJEUmlbvmGwgj0/K53OSKw4xIXrWYFZEcguyFwGn9qGqzyOIq1G VQoiWKdQAeql5GPNOtpLaC+abXqHaZVwWlYJEm9PqcrU3ifHchS63P0soF6GKvB4doH3 SLiu+sS81UOcdKGH8OYXnueCQd0dAb2vQ46yNmsYZzvDY+WneaxLfau3fnXUumgjN9Dt 7HZF2IWMtUja+x4mM9PByK1Ru70Ip2pspPXsNusnvPeWKn7EUPZvkPqGL2Jm2cb+3PBE J3RsykAKJQWKxqtDjeANghGX054kEe5e/3x68End9EPYR5HD4eCKtu0Srs+F9/Thm56k sAPA== X-Gm-Message-State: AOAM532JqFbIUAX/Lq2WpUrqa93KxVO37noRd2C0SbYf4jLmw2oJL5/S KhSDIkQyf7xxHq4XPdq3JRk= X-Received: by 2002:a05:622a:2d1:: with SMTP id a17mr18608482qtx.196.1642492631252; Mon, 17 Jan 2022 23:57:11 -0800 (PST) Received: from localhost.localdomain ([193.203.214.57]) by smtp.gmail.com with ESMTPSA id o7sm10070549qke.44.2022.01.17.23.57.06 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 17 Jan 2022 23:57:10 -0800 (PST) From: cgel.zte@gmail.com X-Google-Original-From: chi.minghao@zte.com.cn To: alexander.deucher@amd.com Cc: christian.koenig@amd.com, Xinhui.Pan@amd.com, airlied@linux.ie, daniel@ffwll.ch, Hawking.Zhang@amd.com, john.clements@amd.com, candice.li@amd.com, lijo.lazar@amd.com, lang.yu@amd.com, Oak.Zeng@amd.com, jonathan.kim@amd.com, amd-gfx@lists.freedesktop.org, dri-devel@lists.freedesktop.org, linux-kernel@vger.kernel.org, Minghao Chi , Zeal Robot , CGEL ZTE Subject: [PATCH] amdgpu/amdgpu_psp: remove unneeded ret variable Date: Tue, 18 Jan 2022 07:57:02 +0000 Message-Id: <20220118075702.925929-1-chi.minghao@zte.com.cn> X-Mailer: git-send-email 2.25.1 MIME-Version: 1.0 Content-Transfer-Encoding: 8bit Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org From: Minghao Chi Return value from amdgpu_bo_create_kernel() directly instead of taking this in another redundant variable. Reported-by: Zeal Robot Signed-off-by: Minghao Chi Signed-off-by: CGEL ZTE --- drivers/gpu/drm/amd/amdgpu/amdgpu_psp.c | 6 +----- 1 file changed, 1 insertion(+), 5 deletions(-) diff --git a/drivers/gpu/drm/amd/amdgpu/amdgpu_psp.c b/drivers/gpu/drm/amd/amdgpu/amdgpu_psp.c index dee17a0e1187..ac2b87f81ef9 100644 --- a/drivers/gpu/drm/amd/amdgpu/amdgpu_psp.c +++ b/drivers/gpu/drm/amd/amdgpu/amdgpu_psp.c @@ -914,19 +914,15 @@ static void psp_prep_ta_load_cmd_buf(struct psp_gfx_cmd_resp *cmd, static int psp_ta_init_shared_buf(struct psp_context *psp, struct ta_mem_context *mem_ctx) { - int ret; - /* * Allocate 16k memory aligned to 4k from Frame Buffer (local * physical) for ta to host memory */ - ret = amdgpu_bo_create_kernel(psp->adev, mem_ctx->shared_mem_size, + return amdgpu_bo_create_kernel(psp->adev, mem_ctx->shared_mem_size, PAGE_SIZE, AMDGPU_GEM_DOMAIN_VRAM, &mem_ctx->shared_bo, &mem_ctx->shared_mc_addr, &mem_ctx->shared_buf); - - return ret; } static void psp_ta_free_shared_buf(struct ta_mem_context *mem_ctx) -- 2.25.1