Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18;
Subject: Re: [PATCH V2] usb: common: ulpi: Fix crash in ulpi_match()
To:     Greg KH <gregkh@linuxfoundation.org>
Cc:     Heikki Krogerus <heikki.krogerus@linux.intel.com>,
        Stephan Gerhold <stephan@gerhold.net>,
        Andy Gross <agross@kernel.org>,
        Bjorn Andersson <bjorn.andersson@linaro.org>,
        linux-usb@vger.kernel.org, linux-kernel@vger.kernel.org,
        linux-tegra@vger.kernel.org
References: <20220117150039.44058-1-jonathanh@nvidia.com>
 <YeWN1Hb0tpjDzn+C@kroah.com>
From:   Jon Hunter <jonathanh@nvidia.com>
Message-ID: <ae60ab9f-2fd7-b706-3584-ef8ab6bc39de@nvidia.com>
Date:   Tue, 18 Jan 2022 09:02:36 +0000
User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:78.0) Gecko/20100101
 Thunderbird/78.14.0
In-Reply-To: <YeWN1Hb0tpjDzn+C@kroah.com>
Content-Type: text/plain; charset=utf-8; format=flowed
Content-Language: en-US
Content-Transfer-Encoding: 7bit
MIME-Version: 1.0
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?dEdsYi90czRTVEtHcTB4Zkd0MmN4QWE3UGgyT3pLMldWQXVOUUNXK3JnMmFF?=
 =?utf-8?B?UEc4UDEzOXVrME1JdDgyZWp3dFBKZVdHNkJuTWtPZ2tqNUJ0cTgwZlBNTi9m?=
 =?utf-8?B?WGNhR1grYkwxbm1qQUNtV1ZzOHlyYnlQQlFIWXVhR0gzVDV3ckYvNUVBQUpM?=
 =?utf-8?B?QmE2NU9oV0E0S1haRlJ0NWo2VTN5QmxJbzZFY1Zoc3kycXJFdzMveGxMUGRL?=
 =?utf-8?B?dDdXOTA2eE45UjNzQzFSVXl6R2Q5YlpiVytUd3VOWmtXTExyNlJ4aWFvbFFB?=
 =?utf-8?B?Qnl4T3A2QjJmNWNadEd0ZXZxSHZjdzZjMXo5U053K01DMkF5UHU2bVNwaEph?=
 =?utf-8?B?N1BydWtwMHM2UUprTnZhRDMvNHBSZWhpbWgzbkQzeDRQeGZ3RCtLRXVBdzIz?=
 =?utf-8?B?ZzYxK2JyMlFPaU03emU3WEdwaUpOR2wyNW1PSG4zSkpES2ZvSTMrNXliNTEx?=
 =?utf-8?B?THF2cDVuZW1UV1NZMVFwUjU1TFhhV1B0NXduZk44WkNaUEVRNmszYkZrT053?=
 =?utf-8?B?RlZFbDk5QitQTEtXUDZEMFlNSDVFaU8rc1JCSVNOOU1rSjFSNzFWOWlPL1o1?=
 =?utf-8?B?blZSMVNGN3hzNk5sQnlyV2ZkbGhHU1lPS3BwZmFzSWI1OWhPUkRRMXV5RVlv?=
 =?utf-8?B?T1ZaeUVESDJpa201eExlcXVLNGZhOHV0dWgwRW9iajBUNTJFWENwWmVRaUFL?=
 =?utf-8?B?eVd2VkI3RFREbmxuWXVrUHN1elBjZnBrY0tmeGNUV1BrellmMUsxbTRwVG5U?=
 =?utf-8?B?R1I0MXdjUEpReGtuQ3R6allDcGE0V2FEcjZFd1Y0YlFPcTVkNHNtenBjL3JK?=
 =?utf-8?B?bWJaa1RFbFgrdi9TWWJtQmplejVibmdLckl3S29Sb2ptTXpCb0FWcy8xTzlW?=
 =?utf-8?B?SXNQNEtpb3AxYjFLS1o3WkI2NGZlVzJadXVicTkzSXN3aUhsTjZTNWRyVjYw?=
 =?utf-8?B?SWxDZThjcGJ5QkszTDRmZnJtYnh4ZGltMTRySC9nYStzSy9OM2NhTUh5a1h1?=
 =?utf-8?B?N0xhdTZtVWdyQ2JqM1ZXSWMxczFrR3A2bTl3UDVZUmZQUUh6cGw3U0JJTG5O?=
 =?utf-8?B?YkV5U1hNR0daazNUT04rbjhBSzNqK2tFOFh3USt3cDJEUWplUlNKQUtlVUps?=
 =?utf-8?B?N2NTT0VMbGI0OFFtOHFKWGFmSG9zMWRqVFpaUGNZNUNFNFNVS25POGNtaXdJ?=
 =?utf-8?B?WnZJd1YrM2ZwTmlKYXlobFViT2RCNk1Ld0wxVG9sdVBwUFUyV3RSQkFEUlFU?=
 =?utf-8?B?ejhURU52N2xWQjYrQlV2Rk1pQ0RrSmNhQUNJNFowbGFOMTVFZEVQSmx2YjZy?=
 =?utf-8?B?dXNiaGJuSDdhaktOMnEzQUgySThRUzlISVc0WjBYRmZaK0xKRFlMNEI2YVVJ?=
 =?utf-8?B?Yjl3VlNPYXdnSFhYTG5kQTlNZVhlbWJyVHBra1JLaDNVc0pGSXVHVTZDUUZy?=
 =?utf-8?B?WnJaZjVicll1UGtScWdPN3pIWWJTY3c5b3Ntc2lPdFJhMVVDYyt3QkVnR2tj?=
 =?utf-8?B?d05FS1EwUzFHRVZObExWcUxTODFTNGNGQlN0UVZBbEVVeEZDOEw3WjFxVFV3?=
 =?utf-8?B?SFFrKzQ2V1I2RmJrS1Y0ODZyWHdoeituZFY4YkxXcC9JNEFBQzNGd0Q4YkRD?=
 =?utf-8?B?R1VmSllxYUJ5VWlxQVdtMTVFcExSRVl0Z0x3WG41NHpISXNYZmJuVElxQlFN?=
 =?utf-8?B?dWFUays1cHEwMGI2TytJdXFsaDc2czFtNi8xU2h3ZzFMTHZROHJpZUxNUXBB?=
 =?utf-8?B?cTVWYmVSZC9wSHA2anVqQTdocWdoZFpjMkV2TjJmZlJ5RGhFMGZ5WlJydVNn?=
 =?utf-8?B?aDQ3eVVUV0dubktWcXJWUUkvTlJrRmoweWtRZ2ZmS1NsWS9kZTVZYTZMYnRo?=
 =?utf-8?B?SzQ0TGltaW1lUkJxRlF5THVwdk9Nam1VRXkxaFRBTXlLSmZjMDdBWjBHY0ha?=
 =?utf-8?B?SWdlb0hGZ2lEMDBGSVA1c3RGM3JYclhkR0crd3F2VDBQbzJENzFYb25uU28r?=
 =?utf-8?B?bTZISWxNbVM4OHRyemZlZTZJU1VuZFFlSG5rdG8ydkpHTk9hOVloU01pU1h3?=
 =?utf-8?B?OGVQSlZpdUpGR0ZZbHNHSjhlQ0tEMG5kamNVYUNHd2ZWOWNVZjRXVEZla3dE?=
 =?utf-8?B?SndqTExSeWtubEJTSEFMbkNyRzBmcEVLUkZ5em5LRkV5anVXdm05V0NzS0E5?=
 =?utf-8?Q?NN4VRGx/jQjjeXOrXM2zUlo=3D?=
X-OriginatorOrg: Nvidia.com
X-MS-Exchange-CrossTenant-Network-Message-Id: e88bedba-8325-4ff3-1e77-08d9da6149e4
X-MS-Exchange-CrossTenant-AuthSource: CO6PR12MB5444.namprd12.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 18 Jan 2022 09:02:43.8660
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: 43083d15-7273-40c1-b7db-39efd9ccc17a
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: 3YOnyVi8MnX8WahiF2b2R9F3fO9lqRSABIiBUtGhhr4ei7v1TOJmYp1uwS9Xs3fuitt8bc6FQvaFMy27hJTG2g==
X-MS-Exchange-Transport-CrossTenantHeadersStamped: BL0PR12MB4850
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org


On 17/01/2022 15:40, Greg KH wrote:
> On Mon, Jan 17, 2022 at 03:00:39PM +0000, Jon Hunter wrote:
>> Commit 7495af930835 ("ARM: multi_v7_defconfig: Enable drivers for
>> DragonBoard 410c") enables the CONFIG_PHY_QCOM_USB_HS for the ARM
>> multi_v7_defconfig. Enabling this Kconfig is causing the kernel to crash
>> on the Tegra20 Ventana platform in the ulpi_match() function.
>>
>> The Qualcomm USB HS PHY driver that is enabled by CONFIG_PHY_QCOM_USB_HS,
>> registers a ulpi_driver but this driver does not provide an 'id_table',
>> so when ulpi_match() is called on the Tegra20 Ventana platform, it
>> crashes when attempting to deference the id_table pointer which is not
>> valid. The Qualcomm USB HS PHY driver uses device-tree for matching the
>> ULPI driver with the device and so fix this crash by using device-tree
>> for matching if the id_table is not valid.
>>
>> Fixes: ef6a7bcfb01c ("usb: ulpi: Support device discovery via DT")
>> Signed-off-by: Jon Hunter <jonathanh@nvidia.com>
> 
> No cc: of stable since this is a bug going back to 4.11?


Yes good point.

Heikki, let me know if you want me to resend or if you can add the 
stable tag?

Cheers
Jon

-- 
nvpublic