Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18;
Date:   Tue, 18 Jan 2022 10:15:30 +0100
From:   Heiko Carstens <hca@linux.ibm.com>
To:     cgel.zte@gmail.com
Cc:     oleg@redhat.com, gor@linux.ibm.com, borntraeger@linux.ibm.com,
        agordeev@linux.ibm.com, linux-s390@vger.kernel.org,
        linux-kernel@vger.kernel.org, Minghao Chi <chi.minghao@zte.com.cn>,
        Zeal Robot <zealci@zte.com.cn>
Subject: Re: [PATCH] arch/s390/kernel: remove unneeded rc variable
Message-ID: <YeaFMspieut8Y6tJ@osiris>
References: <20220118075115.925468-1-chi.minghao@zte.com.cn>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <20220118075115.925468-1-chi.minghao@zte.com.cn>
Precedence: bulk

On Tue, Jan 18, 2022 at 07:51:15AM +0000, cgel.zte@gmail.com wrote:
> From: Minghao Chi <chi.minghao@zte.com.cn>
> 
> Return value from user_regset_copyin() directly instead
> of taking this in another redundant variable.
> 
> Reported-by: Zeal Robot <zealci@zte.com.cn>
> Signed-off-by: Minghao Chi <chi.minghao@zte.com.cn>
> Signed-off-by: CGEL ZTE <cgel.zte@gmail.com>
> ---
>  arch/s390/kernel/ptrace.c | 5 +----
>  1 file changed, 1 insertion(+), 4 deletions(-)
...
> -	int rc;
> -
>  	if (!MACHINE_HAS_VX)
>  		return -ENODEV;
>  	if (target == current)
>  		save_fpu_regs();
>  
> -	rc = user_regset_copyin(&pos, &count, &kbuf, &ubuf,
> +	return user_regset_copyin(&pos, &count, &kbuf, &ubuf,
>  				target->thread.fpu.vxrs + __NUM_VXRS_LOW, 0, -1);
> -	return rc;

This "breaks" indentation. Could you guys please stop sending such
semi-automated generated questionable patches? I really don't see any
benefit besides code churn, and the possibility of introducing bugs.

Thanks!