Received: by 2002:a05:6a10:af89:0:0:0:0 with SMTP id iu9csp5353967pxb; Wed, 19 Jan 2022 16:52:49 -0800 (PST) X-Google-Smtp-Source: ABdhPJz6p5MxQ7lqxLO/7Ev9PM4Rxq9PYFFT7NTr9PbaH2urlox4nCkIAHeGuYH0iYuvvWKgBaGN X-Received: by 2002:a17:902:8f82:b0:14a:c442:8ca5 with SMTP id z2-20020a1709028f8200b0014ac4428ca5mr15058820plo.31.1642639969537; Wed, 19 Jan 2022 16:52:49 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1642639969; cv=none; d=google.com; s=arc-20160816; b=Vjdj2RPlbeD5mfrgn+2AcOeIKa1tdHsGcK1flrwUMyrG15W0Z9apYuUN6lltIYmWAN MVMjzv9RsbiTn9JEHpizRTkt8bJfi77y0AGK1gqOaaL1rls8t3hftXoAZp2C/p4wbeh2 DoSJs7rDy0Ob1+SELrbhlGKcuzuWTBR9dXHvd0eaUVrvU1obQXfI7b9sF1I9rmj/qtjW 89zFKj+T+hdMPS+4cu8yYcjQuiGqWICv6SsywM4o0rZP4y232AJ8cD4qN9PFX+sE25SA sAw3oTVToZcOOMef0wPUGPJq9QeDw3WdDfAjHSHI147IXUcV36DIR6QDTssW/9QFCDMW LonA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:in-reply-to:content-disposition:mime-version :references:message-id:subject:cc:to:from:date:dkim-signature; bh=5Zvs9+UMuisbE1S/G8Xv89qZmGNrRAyujh7XOE4Gpac=; b=MA01mIXMDjDrFJ+tbeRL6AIgdcraRCJySHk9/3gtmkKa2MW8wJnEI5rSzciJLYsRHR VIEURHRkhRNmALBkMXCsDv8df9AlhkPB3zAHR27+H2QOgHf5Y+MGkI2WIZdCfkVo12pB jIt/CA6quKvJxPt2LbJ24G1TiXm1kqueC+GUFZVILvw9GqsUIT5xIczlBHVXvqhZcEbo 4WOfSTApSdvC8PSf+/EAuczfNCxAcGYn5lKJPhcvU8OTR2DRLOjL3YI1ATHSbfg9D14M 2v/i2r96Nu6j7bdjhx8mu0T7pnqONEjPcslPncUE4K3NsgONCdsOiKRFT6S6Fd3d1OEI mz1Q== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@google.com header.s=20210112 header.b=WNs7c1MT; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=REJECT sp=REJECT dis=NONE) header.from=google.com Return-Path: Received: from vger.kernel.org (vger.kernel.org. [23.128.96.18]) by mx.google.com with ESMTP id w3si1210992ply.342.2022.01.19.16.52.37; Wed, 19 Jan 2022 16:52:49 -0800 (PST) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18; Authentication-Results: mx.google.com; dkim=pass header.i=@google.com header.s=20210112 header.b=WNs7c1MT; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=REJECT sp=REJECT dis=NONE) header.from=google.com Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S237545AbiARJV2 (ORCPT + 99 others); Tue, 18 Jan 2022 04:21:28 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:42070 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S235153AbiARJV0 (ORCPT ); Tue, 18 Jan 2022 04:21:26 -0500 Received: from mail-il1-x12e.google.com (mail-il1-x12e.google.com [IPv6:2607:f8b0:4864:20::12e]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 2F40CC06161C for ; Tue, 18 Jan 2022 01:21:26 -0800 (PST) Received: by mail-il1-x12e.google.com with SMTP id h30so16975975ila.12 for ; Tue, 18 Jan 2022 01:21:26 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=20210112; h=date:from:to:cc:subject:message-id:references:mime-version :content-disposition:in-reply-to; bh=5Zvs9+UMuisbE1S/G8Xv89qZmGNrRAyujh7XOE4Gpac=; b=WNs7c1MTDzC9jGA7BOWDtnQYV9lhuodolnBJBBDhbPGOnvPzIRjK3ikEJe7FpeZWF7 khHNeCGff946aku7HKG4YWIraUbOgbcrban0UwppU+ZvLt5FwAd90Z6C41CEY9fpyNod 4Xx8cWlhS025exLxB0ao3sOAsRH921YrlE6z/uUtrHvv9SJWc7VY4EtPUyfSiDaKKqDr hdRPjoope/KEeIneL+fkDjaHzun/u6EFFCHd0Gd10PGXeSknHaoyHcUEGJ8+UtjhrZwc 4q2WEwVmfoZON9nDK44fxgg7jqC5p7GuiDxZalbaTsqTm1pcX8RGq7sGmeYCmQLq9QSa nv2g== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:in-reply-to; bh=5Zvs9+UMuisbE1S/G8Xv89qZmGNrRAyujh7XOE4Gpac=; b=LqxgUlxashq8pCq0sJDopi6myh/ZMNr9bXRZBUTkCyF+MoPcDfj71u0YU6W26EgBD+ 9rNDCc+WOIt1ozNi1RcO82TRQlDFk8DX+nEvic8eHqk2EspG8iUYYszgKfp8PkCoZghN Wou9sI3xqeAz10VPhQFbNRRf0612Iwbsm2jBbUwoUz8IDcTDbAwTxKspESNq5aENEmVV 0+TlSKgiX1ttMWA1lUc1tUgFkvrbY0Y386p/gfjlgWAV0SWC1V7g4DoksY4VxiTzXG03 pdTo9hdt83ljHy8q/TQ6M6vp+5A329+z+ZbR+jfirOziQBMBXScxvOPgdynStXQgui2K iDQg== X-Gm-Message-State: AOAM5336IJ+/U14xQnhLiBTVENUYL87/nQme2BFWLDu49Dh0D7WMuIXK iXwZgm/lHBbg4RioV5RNxAqkrw== X-Received: by 2002:a92:cd4b:: with SMTP id v11mr7081222ilq.3.1642497685350; Tue, 18 Jan 2022 01:21:25 -0800 (PST) Received: from google.com ([2620:15c:183:200:40dc:e0ca:c949:a83b]) by smtp.gmail.com with ESMTPSA id o10sm2389761iow.0.2022.01.18.01.21.24 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 18 Jan 2022 01:21:24 -0800 (PST) Date: Tue, 18 Jan 2022 02:21:21 -0700 From: Yu Zhao To: Donald Carr Cc: Andi Kleen , Catalin Marinas , Dave Hansen , Hillf Danton , Jens Axboe , Jesse Barnes , Johannes Weiner , Jonathan Corbet , Matthew Wilcox , Mel Gorman , Michael Larabel , Michal Hocko , Rik van Riel , Vlastimil Babka , Will Deacon , Ying Huang , linux-arm-kernel@lists.infradead.org, linux-doc@vger.kernel.org, linux-kernel@vger.kernel.org, linux-mm@kvack.org, page-reclaim@google.com, x86@kernel.org, Andrew Morton , Linus Torvalds Subject: Re: [PATCH v6 0/9] Multigenerational LRU Framework Message-ID: References: <20220104202227.2903605-1-yuzhao@google.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Tue, Jan 11, 2022 at 01:41:22AM -0700, Yu Zhao wrote: > On Tue, Jan 04, 2022 at 01:30:00PM -0700, Yu Zhao wrote: > > On Tue, Jan 04, 2022 at 01:22:19PM -0700, Yu Zhao wrote: > > > TLDR > > > ==== > > > The current page reclaim is too expensive in terms of CPU usage and it > > > often makes poor choices about what to evict. This patchset offers an > > > alternative solution that is performant, versatile and > > > straightforward. > > > > > > > > > Summery > > > ======= > > > The facts are: > > > 1. The independent lab results and the real-world applications > > > indicate substantial improvements; there are no known regressions. > > > 2. Thrashing prevention, working set estimation and proactive reclaim > > > work out of the box; there are no equivalent solutions. > > > 3. There is a lot of new code; nobody has demonstrated smaller changes > > > with similar effects. > > > > > > Our options, accordingly, are: > > > 1. Given the amount of evidence, the reported improvements will likely > > > materialize for a wide range of workloads. > > > 2. Gauging the interest from the past discussions [14][15][16], the > > > new features will likely be put to use for both personal computers > > > and data centers. > > > 3. Based on Google's track record, the new code will likely be well > > > maintained in the long term. It'd be more difficult if not > > > impossible to achieve similar effects on top of the existing > > > design. > > > > Hi Andrew, Linus, > > > > Can you please take a look at this patchset and let me know if it's > > 5.17 material? > > > > My goal is to get it merged asap so that users can reap the benefits > > and I can push the sequels. Please examine the data provided -- I > > think the unprecedented coverage and the magnitude of the improvements > > warrant a green light. My gratitude to Donald who has been helping test MGLRU since v2: Donald Carr (d@chaos-reins.com) Founder of Chaos Reins (http://chaos-reins.com), an SF based consultancy company specializing in designing/creating embedded Linux appliances. Can you please provide your Tested-by tags? This will ensure the credit for your contributions. Thanks!