Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18;
From:   Vladimir Oltean <vladimir.oltean@nxp.com>
To:     Sasha Levin <sashal@kernel.org>
CC:     "linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
        "stable@vger.kernel.org" <stable@vger.kernel.org>,
        Colin Foster <colin.foster@in-advantage.com>,
        Florian Fainelli <f.fainelli@gmail.com>,
        Jakub Kicinski <kuba@kernel.org>,
        Claudiu Manoil <claudiu.manoil@nxp.com>,
        "alexandre.belloni@bootlin.com" <alexandre.belloni@bootlin.com>,
        "UNGLinuxDriver@microchip.com" <UNGLinuxDriver@microchip.com>,
        "andrew@lunn.ch" <andrew@lunn.ch>,
        "vivien.didelot@gmail.com" <vivien.didelot@gmail.com>,
        "davem@davemloft.net" <davem@davemloft.net>,
        "linux@armlinux.org.uk" <linux@armlinux.org.uk>,
        "netdev@vger.kernel.org" <netdev@vger.kernel.org>
Subject: Re: [PATCH AUTOSEL 5.16 108/217] net: dsa: ocelot: felix: Remove
 requirement for PCS in felix devices
Thread-Topic: [PATCH AUTOSEL 5.16 108/217] net: dsa: ocelot: felix: Remove
 requirement for PCS in felix devices
Thread-Index: AQHYDBKgJJQHtgdBEEWeoJNKtqf88KxotDEA
Date:   Tue, 18 Jan 2022 12:23:17 +0000
Message-ID: <20220118122316.yas6mmyzog6said3@skbuf>
References: <20220118021940.1942199-1-sashal@kernel.org>
 <20220118021940.1942199-108-sashal@kernel.org>
In-Reply-To: <20220118021940.1942199-108-sashal@kernel.org>
Accept-Language: en-US
Content-Language: en-US
x-ms-exchange-antispam-messagedata-chunkcount: 1
x-ms-exchange-antispam-messagedata-0: =?us-ascii?Q?UwQkosIe7DvsauQ9Af8cpnGAUSksBb7uOBcGDYdC3AzN88CK4zncvJijSGNv?=
 =?us-ascii?Q?zjptWPafvEfx42NZO/g4rpz8ZaRPn4VOgHur16A9O83znVNRhE4zmX0JBhja?=
 =?us-ascii?Q?ART6vCXhS/iEZ3+nkXFWD17Ao88ZYX/lsqWnsgumZFkJxfKZqgDYumYYkOlI?=
 =?us-ascii?Q?f9npRa4fSqssUlH/2JYE17Ellq7hgG/FhW3Qdig3RDApmQc8a6/Q40IK/1IO?=
 =?us-ascii?Q?sN1a2Z5Dec9yQcy68okQkkCnWANkVnXLMlG+Peu1Mul36ahWmE4LVonLV7EV?=
 =?us-ascii?Q?udNyup8xJdCO8IKAEQuVg0u90a3XV5hdDSN5WdwysH/Vs4qkDdHqa7FGaKeY?=
 =?us-ascii?Q?OCS3sinObe50JsIB4/OTx4s2v/QrMvUQFWjXx/8A8SdMX57R+uRazoTjXMD7?=
 =?us-ascii?Q?2ecjwRgK6t4HVy+jQjX3wi72NurHFJZb7uQA/be/+dey5SAc4BuoG2ZGYCCe?=
 =?us-ascii?Q?BWo5FVPlIC6YaKJvhyWMPxc3WRT1FIWWnTBVIL6l1CLMfiAo+iUPtNLEnS2m?=
 =?us-ascii?Q?J5yOzcTHEmwo92Do515kt5cHeZzqq7DDe+Wqwn2BkL2MVlGMUK6UbkvJhPnG?=
 =?us-ascii?Q?F5/otYCQJX8yXiH2McgxmPHHNUJvR2qtmyFb0nkFYFheck1KhGIfPzmrl2DS?=
 =?us-ascii?Q?fsPzKSQKAG6w21fjN3QYMCD8BdGPK2E8OKH1zxyRgO8k4T5Lzu3DTs5FK9TP?=
 =?us-ascii?Q?JLzJup7UvgZoWSinGdor86oNSvSHrf2x7FLUfsLPtSkTqELed0CCCtb2LD50?=
 =?us-ascii?Q?DsZ2wnq/474lvTgtU62zOwaMWpXzc82yWfm78Zpy0U7ikdGs+iisHnkcY6FA?=
 =?us-ascii?Q?h3b03Fgw02eQ9SQNr35p6syZYZT43hC1+fL+rFWZAutriQNwnNq9MuCVQV05?=
 =?us-ascii?Q?Po+odSSdNrcJ0XCEvE4exFnUI7rUtAK9BZIlfCkLqJNVEBGd6A8Uw9J4b3xe?=
 =?us-ascii?Q?IE/YN7LLEY3hWjitaSOUz8H0JGjDhxKV2yAMd73nBoydWrbxIERGYvuoS2Ly?=
 =?us-ascii?Q?ekPIjymzp55hhbCjb1HHrVK15dKIYkSLbKzg6+YHbI3YDpUALA8seN0d4iS7?=
 =?us-ascii?Q?zgsgNT02BkGzwtHCbRdKckNDytKHmUy0uKIuWCRcodM92XZdRp9LOJGq6G/9?=
 =?us-ascii?Q?GJoBPl7XBQB1y+e3U30BUzQtLBYqfKy4PurI+93B4qzSj/iTkr0FV5rAvKOk?=
 =?us-ascii?Q?82rMRZhCnVLIuUQgo5hpOu86KVyMprIX1omANjKuE80KcazGUowQcA5sisIB?=
 =?us-ascii?Q?5RyKoXv9hj9pCFDC6qqwwPa12IxhYeOptSA7AawKh77c2xrPHrUi9RlmFTI9?=
 =?us-ascii?Q?v+urSrgOmJsbvwn1OS5M0xle5XHNutjgOSEAkgTrifGAh+nVJSfc5ojMDKtW?=
 =?us-ascii?Q?vWLu55/8WNJlArcX4VOYWT3zu5R89bmDEY22vwabelWCUJTtA+mrjIGhAgtm?=
 =?us-ascii?Q?I7Ry9eerWMXtfU12gBALWjOdmsWAb0GkwoASo9ly9Xu4k4X9K3ESU/Po3O78?=
 =?us-ascii?Q?iALqp+xfxxmmD+BQojBMf8f44tMj+EDIeFNIzuAwl2K+nCH4LLkl1HKis8vv?=
 =?us-ascii?Q?6dlo6YQFafHxIle6jmulayVmrUKvAtbjb7QCSM8CqHZ5qylIe2C0Bw+3LQel?=
 =?us-ascii?Q?x/VAz5mqAA5KFm9AMBlExjk=3D?=
Content-Type: text/plain; charset="us-ascii"
Content-ID: <3202A6493A3FBC4C979515BD9F983492@eurprd04.prod.outlook.com>
Content-Transfer-Encoding: quoted-printable
MIME-Version: 1.0
X-OriginatorOrg: nxp.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-AuthSource: VI1PR04MB5136.eurprd04.prod.outlook.com
X-MS-Exchange-CrossTenant-Network-Message-Id: 8d4b53e7-2fd3-48db-6890-08d9da7d4e9d
X-MS-Exchange-CrossTenant-originalarrivaltime: 18 Jan 2022 12:23:17.3560
 (UTC)
X-MS-Exchange-CrossTenant-fromentityheader: Hosted
X-MS-Exchange-CrossTenant-id: 686ea1d3-bc2b-4c6f-a92c-d99c5c301635
X-MS-Exchange-CrossTenant-mailboxtype: HOSTED
X-MS-Exchange-CrossTenant-userprincipalname: 36NQzC3cSAaw6fTCGq601RQ7H7vbObKovDKr7/yUkqm1kQYATKsnJ0lacIAAVrd8BQ4ZZK0sqW9jFlE/1AY7MA==
X-MS-Exchange-Transport-CrossTenantHeadersStamped: DB8PR04MB5836
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

Hello Sasha,

On Mon, Jan 17, 2022 at 09:17:51PM -0500, Sasha Levin wrote:
> From: Colin Foster <colin.foster@in-advantage.com>
>=20
> [ Upstream commit 49af6a7620c53b779572abfbfd7778e113154330 ]
>=20
> Existing felix devices all have an initialized pcs array. Future devices
> might not, so running a NULL check on the array before dereferencing it
> will allow those future drivers to not crash at this point
>=20
> Signed-off-by: Colin Foster <colin.foster@in-advantage.com>
> Reviewed-by: Vladimir Oltean <vladimir.oltean@nxp.com>
> Reviewed-by: Florian Fainelli <f.fainelli@gmail.com>
> Signed-off-by: Jakub Kicinski <kuba@kernel.org>
> Signed-off-by: Sasha Levin <sashal@kernel.org>
> ---
>  drivers/net/dsa/ocelot/felix.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
>=20
> diff --git a/drivers/net/dsa/ocelot/felix.c b/drivers/net/dsa/ocelot/feli=
x.c
> index f1a05e7dc8181..221440a61e17e 100644
> --- a/drivers/net/dsa/ocelot/felix.c
> +++ b/drivers/net/dsa/ocelot/felix.c
> @@ -823,7 +823,7 @@ static void felix_phylink_mac_config(struct dsa_switc=
h *ds, int port,
>  	struct felix *felix =3D ocelot_to_felix(ocelot);
>  	struct dsa_port *dp =3D dsa_to_port(ds, port);
> =20
> -	if (felix->pcs[port])
> +	if (felix->pcs && felix->pcs[port])
>  		phylink_set_pcs(dp->pl, &felix->pcs[port]->pcs);
>  }
> =20
> --=20
> 2.34.1
>

Please drop this patch from all stable branches (5.16, 5.15, 5.10).=