Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18;
Message-ID: <0ba294a9-1428-98cf-93b6-f9a195924a8f@amd.com>
Date:   Tue, 18 Jan 2022 19:33:14 +0530
User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:91.0) Gecko/20100101
 Thunderbird/91.3.2
Subject: Re: [PATCH] drm/amdgpu: Add missing pm_runtime_put_autosuspend
Content-Language: en-US
To:     Yongzhi Liu <lyz_cs@pku.edu.cn>, airlied@linux.ie, daniel@ffwll.ch,
        nirmoy.das@amd.com, Jingwen.Chen2@amd.com, evan.quan@amd.com,
        Jack.Zhang1@amd.com, kevin1.wang@amd.com, tom.stdenis@amd.com
Cc:     amd-gfx@lists.freedesktop.org, dri-devel@lists.freedesktop.org,
        linux-kernel@vger.kernel.org
References: <1642507272-17545-1-git-send-email-lyz_cs@pku.edu.cn>
From:   "Lazar, Lijo" <lijo.lazar@amd.com>
In-Reply-To: <1642507272-17545-1-git-send-email-lyz_cs@pku.edu.cn>
Content-Type: text/plain; charset=UTF-8; format=flowed
Content-Transfer-Encoding: 7bit
MIME-Version: 1.0
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?ajdOcEdmeFUxaTBwemlyaFpuUTQwZnZjTjE2bk82REtPOEk1cFNMWHd2SXZM?=
 =?utf-8?B?MUgyb0pieFpudldtQ2x3RFYrUUc0LzdNdUZ3elZ6Znk0S1FsRFFDUjhQZjJx?=
 =?utf-8?B?Y0tQUWVHQktySkp6azA1eHpTVXlwaUJ3QXgyUkRoWVUxQVNLSnh1VmYvVEtq?=
 =?utf-8?B?a3ZGVGNlV0JhU0V3aWJTSkVGeGN6UmJDMVBYUTFoSmtxSzRkUGlNUWFPZXoz?=
 =?utf-8?B?Z2hJTjdta1Zsd2ZCUlh0K25FeHppSE5Rc0RldEE3TThWMFFDelFqQnVnRm1Q?=
 =?utf-8?B?eVFrWDhxSlJxVk1pMFhOU0JMSWM3eWtUd3Uwa3JBem1sOGpXWmhNMHljMkdm?=
 =?utf-8?B?MXNhVjROS1BVaWIreEFBbVpPU3NXZW5XNHQrZTdZZlBvVjlDZVJyZnBpazZo?=
 =?utf-8?B?RWZXalhUUmRQRjZaeG5jQWN0Ri8xeVVEaEl4ajkySFJocHMwdE5lWElZRDBx?=
 =?utf-8?B?a3JSOUxzcUU3Q3lBMzR0R3J2T29FN1EyUkJ5OENYaW8yOHdUL0xieWJITU01?=
 =?utf-8?B?NWlrdXpqSWlpaHFMRTh0VHRQcCtSTzJUZ29NTW5mWGRBdXFIdHVpVW5BVnla?=
 =?utf-8?B?RGc1eTg2dFdNbncxSnV4SjhKOThObldMaW5KYm5wNThnSWwrWEpsRTE3OTNz?=
 =?utf-8?B?L3RRL2NRZi9QZGVySFErOGxwTnhZdVk5bTVocHJqREJnL21NR201V3IyWHlD?=
 =?utf-8?B?aDNCbDhOREl6bEJLYStpbUxMZWpGa1NDQjh1UmZIbzFPTzhZUktGblU1Wkh0?=
 =?utf-8?B?MVducXJoa3FJZzh6TGo4VWJPSy92eXl2WHpPdzBaMU8vNytHT1B4OWNPL1hB?=
 =?utf-8?B?NUlMQXVtNWFrSXRNU2Z5cW8rMHlIS2l4eGNZMG1MWXIvd0dJMnUxK0VhV2VP?=
 =?utf-8?B?RWhMK2Z4M0FaYUVzZHdMUXBmQ01TTUd5TFUzY2p1M09MQ1cvODA0SHMwSE1v?=
 =?utf-8?B?a3pHeUhxRFEzOXc4VTI2Q2RmeXI0dTREdTFaOU9IODZWbzI1ZHhSRTc1K2tF?=
 =?utf-8?B?REhSZFJicXI3OXFtenk1RFREM1RSQ1A5KytlUmRZY2FzQ0g3M3EzL3hORkZJ?=
 =?utf-8?B?ekRMbHNwakM5THRsYTRIYTdpaTh1ZXNuYlV0UHVtUjFhUm9KT0RxdEl6Tm8x?=
 =?utf-8?B?djF3UGxPMElacWNyWG83V1JUeFlPM1VYdVFjNXdPbDh0MVFxdVRZMXVGSmtl?=
 =?utf-8?B?WTUyNVRtbi9ZRzFMeE9aY3BWZTZnbzZqbCtlbUt6QWdIaUdvS2JtaTBJVDdP?=
 =?utf-8?B?dXBpUTc3clNycU5BbVo0c1VDWVJVb2Y4N0ZIcUxXdHpmSk4ybTB2eGJ1a0pH?=
 =?utf-8?B?TTgycTlrK2lnNW5vejRhY29BZXVoNXVtUElNUkFLVi9zYUdRS3luZlVHZ0hN?=
 =?utf-8?B?VDVQWElyTEpUVUI3TWRyT21QeUFpa2tXNmw0K2czUUpWeGQrZGtLQmRqSkZQ?=
 =?utf-8?B?TlZERHNHWnRIMjRpOGtoV3hCMkhRVnpldmZNY0YzckZjaHJJdFRMK3hQL3VR?=
 =?utf-8?B?SktQNTg0ZTE1QkE3ZjdpdHR1UFJWMkUvdlpwcU9mQWxNU2JOb215cnl4MnpU?=
 =?utf-8?B?RkR2NkM2Qi9XN0h2QkNYNlI5cDlqOFgyOGdSOGJYT3Y0WkNGT1V1aUhEWkNT?=
 =?utf-8?B?YTlUL0NuUDc3THJjVXhJWVdYaUltMnBNOU80Q3ZJbk5sSFVDckdPbXdkNm9l?=
 =?utf-8?B?RTVvRVdubk1DRTU1cHZpWHhoUUMvc0E0TlFUb0FMbkVUYm42VjZqWnh2Ly9y?=
 =?utf-8?B?bHNESTEwZnlvVmRtNngwYmM0RDN6OUxad3h0dDB0Q1ZXNkUyaTlXL1RFSFZT?=
 =?utf-8?B?eFFuT1dFODdIWGRidVdOQzNrR2JCRWZlL016T2JXZno0MTl0WmZyeGYzYmEy?=
 =?utf-8?B?dHZjRmx5Vjl5aDVHSHlmaW9pNEU5b2ZmdWl4UVQyQVV1aUk2djJGT0hsMVlI?=
 =?utf-8?B?SlNML01IZ0tLUUxvRUVIN3ZWUGJwdnFyZ2NKbjZDaDdsd3N6SlRnSDcvcDRj?=
 =?utf-8?B?YjYvWnBVT3ZLdmxaM0N5aXVyQmp1dTFHMnMxYWtER3QwekROc0dWWGJFM1Jr?=
 =?utf-8?B?d2VkWTZHQnlUdFZYSmRkV1R6MkYzaUNodUFaajJZQVpHMURBWGs3ME9tTVZJ?=
 =?utf-8?Q?te+8=3D?=
X-OriginatorOrg: amd.com
X-MS-Exchange-CrossTenant-Network-Message-Id: 5b3a08c6-822e-4dd2-2266-08d9da8b5123
X-MS-Exchange-CrossTenant-AuthSource: BYAPR12MB4614.namprd12.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 18 Jan 2022 14:03:35.0264
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: 3dd8961f-e488-4e60-8e11-a82d994e183d
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: ycEYnIBuNNnjpgWAajmkbs6mn50VPVYB81+SFTZToKG+gWwc8UQJXyt7KVJwFgoB
X-MS-Exchange-Transport-CrossTenantHeadersStamped: CY4PR1201MB2516
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org


On 1/18/2022 5:31 PM, Yongzhi Liu wrote:
> pm_runtime_get_sync() increments the runtime PM usage counter even
> when it returns an error code, thus a matching decrement is needed
> on the error handling path to keep the counter balanced.
> 
> Signed-off-by: Yongzhi Liu <lyz_cs@pku.edu.cn>

Thanks!

Reviewed-by: Lijo Lazar <lijo.lazar@amd.com>

> ---
>   drivers/gpu/drm/amd/amdgpu/amdgpu_debugfs.c | 4 +++-
>   1 file changed, 3 insertions(+), 1 deletion(-)
> 
> diff --git a/drivers/gpu/drm/amd/amdgpu/amdgpu_debugfs.c b/drivers/gpu/drm/amd/amdgpu/amdgpu_debugfs.c
> index 9aea1cc..4b950de 100644
> --- a/drivers/gpu/drm/amd/amdgpu/amdgpu_debugfs.c
> +++ b/drivers/gpu/drm/amd/amdgpu/amdgpu_debugfs.c
> @@ -1120,8 +1120,10 @@ static ssize_t amdgpu_debugfs_gfxoff_read(struct file *f, char __user *buf,
>   		return -EINVAL;
>   
>   	r = pm_runtime_get_sync(adev_to_drm(adev)->dev);
> -	if (r < 0)
> +	if (r < 0) {
> +		pm_runtime_put_autosuspend(adev_to_drm(adev)->dev);
>   		return r;
> +	}
>   
>   	while (size) {
>   		uint32_t value;
>