Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18;
From:   "Alim Akhtar" <alim.akhtar@samsung.com>
To:     "'Krzysztof Kozlowski'" <krzysztof.kozlowski@canonical.com>,
        <linux-arm-kernel@lists.infradead.org>,
        <linux-kernel@vger.kernel.org>
Cc:     <soc@kernel.org>, <linux-clk@vger.kernel.org>,
        <devicetree@vger.kernel.org>, <olof@lixom.net>,
        <linus.walleij@linaro.org>, <catalin.marinas@arm.com>,
        <robh+dt@kernel.org>, <s.nawrocki@samsung.com>,
        <linux-samsung-soc@vger.kernel.org>, <pankaj.dubey@samsung.com>,
        <linux-fsd@tesla.com>,
        "'Shashank Prashar'" <s.prashar@samsung.com>,
        "'Aswani Reddy'" <aswani.reddy@samsung.com>
In-Reply-To: <b8040d39-cd4d-e5b0-8aec-f03c5257d63e@canonical.com>
Subject: RE: [PATCH 15/23] arm64: dts: fsd: Add initial pinctrl support
Date:   Tue, 18 Jan 2022 20:28:37 +0530
Message-ID: <023d01d80c7b$e14d4d40$a3e7e7c0$@samsung.com>
MIME-Version: 1.0
Content-Transfer-Encoding: quoted-printable
Thread-Index: AQKuNmZ/+9PJHbdzezyQqzGEXzr0sgJL1gp6AanHgoQCI2LlggH1bO0EAd3QJpGqbSOWAA==
Content-Language: en-us
Content-Type: text/plain; charset="utf-8"
CMS-TYPE: 105P
DLP-Filter: Pass
References: <20220113121143.22280-1-alim.akhtar@samsung.com>
        <CGME20220113122417epcas5p47398a5190cdf4c574c6f1762918b549f@epcas5p4.samsung.com>
        <20220113121143.22280-16-alim.akhtar@samsung.com>
        <2927c34e-3259-4e9a-a657-aeeebf9089d2@canonical.com>
        <00ca01d80ba8$6b9b9800$42d2c800$@samsung.com>
        <b8040d39-cd4d-e5b0-8aec-f03c5257d63e@canonical.com>
Precedence: bulk


>-----Original Message-----
>From: Krzysztof Kozlowski =5Bmailto:krzysztof.kozlowski=40canonical.com=5D
>Sent: Monday, January 17, 2022 7:20 PM
>To: Alim Akhtar <alim.akhtar=40samsung.com>; linux-arm-
>kernel=40lists.infradead.org; linux-kernel=40vger.kernel.org
>Cc: soc=40kernel.org; linux-clk=40vger.kernel.org; devicetree=40vger.kerne=
l.org;
>olof=40lixom.net; linus.walleij=40linaro.org; catalin.marinas=40arm.com;
>robh+dt=40kernel.org; s.nawrocki=40samsung.com; linux-samsung-
>soc=40vger.kernel.org; pankaj.dubey=40samsung.com; linux-fsd=40tesla.com;
>'Shashank Prashar' <s.prashar=40samsung.com>; 'Aswani Reddy'
><aswani.reddy=40samsung.com>
>Subject: Re: =5BPATCH 15/23=5D arm64: dts: fsd: Add initial pinctrl suppor=
t
>
>On 17/01/2022 14:44, Alim Akhtar wrote:
>> Hi Krzysztof
>>
>>> -----Original Message-----
>>> From: Krzysztof Kozlowski =5Bmailto:krzysztof.kozlowski=40canonical.com=
=5D
>>> Sent: Thursday, January 13, 2022 6:50 PM
>>> To: Alim Akhtar <alim.akhtar=40samsung.com>; linux-arm-
>>> kernel=40lists.infradead.org; linux-kernel=40vger.kernel.org
>>> Cc: soc=40kernel.org; linux-clk=40vger.kernel.org;
>>> devicetree=40vger.kernel.org; olof=40lixom.net; linus.walleij=40linaro.=
org;
>>> catalin.marinas=40arm.com;
>>> robh+dt=40kernel.org; s.nawrocki=40samsung.com; linux-samsung-
>>> soc=40vger.kernel.org; pankaj.dubey=40samsung.com; linux-fsd=40tesla.co=
m;
>>> Shashank Prashar <s.prashar=40samsung.com>; Aswani Reddy
>>> <aswani.reddy=40samsung.com>
>>> Subject: Re: =5BPATCH 15/23=5D arm64: dts: fsd: Add initial pinctrl
>>> support
>>>
>>> On 13/01/2022 13:11, Alim Akhtar wrote:
>>>> Add initial pin configuration nodes for FSD SoC.
>>>>
>>>> Cc: linux-fsd=40tesla.com
>>>> Signed-off-by: Shashank Prashar <s.prashar=40samsung.com>
>>>> Signed-off-by: Aswani Reddy <aswani.reddy=40samsung.com>
>>>> Signed-off-by: Alim Akhtar <alim.akhtar=40samsung.com>
>>>> ---
>>>>  arch/arm64/boot/dts/tesla/fsd-pinctrl.dtsi =7C 338
>>> +++++++++++++++++++++
>>>>  arch/arm64/boot/dts/tesla/fsd.dtsi         =7C  22 ++
>>>>  2 files changed, 360 insertions(+)
>>>>  create mode 100644 arch/arm64/boot/dts/tesla/fsd-pinctrl.dtsi
>>>>
>>>> diff --git a/arch/arm64/boot/dts/tesla/fsd-pinctrl.dtsi
>>>> b/arch/arm64/boot/dts/tesla/fsd-pinctrl.dtsi
>>>> new file mode 100644
>>>> index 000000000000..ec8d944af636
>>>> --- /dev/null
>>>> +++ b/arch/arm64/boot/dts/tesla/fsd-pinctrl.dtsi
>>>> =40=40 -0,0 +1,338 =40=40
>>>> +// SPDX-License-Identifier: GPL-2.0
>>>> +/*
>>>> + * Tesla Full Self-Driving SoC device tree source
>>>> + *
>>>> + * Copyright (c) 2017-2021 Samsung Electronics Co., Ltd.
>>>> + *		https://www.samsung.com
>>>> + * Copyright (c) 2017-2021 Tesla, Inc.
>>>> + *		https://www.tesla.com
>>>> + */
>>>> +
>>>> +=23include <dt-bindings/pinctrl/samsung.h>
>>>> +
>>>> +&pinctrl_fsys0 =7B
>>>> +
>>>
>>> No need for empty line.
>>>
>> Noted
>>
>>>> +	gpf0: gpf0 =7B
>>>
>>> FYI:
>>> It's ok now, but the nodes will have to be renamed to =22xxx-gpio-bank=
=22
>later.
>>>
>> Have rebased my v2 on your pinmux schema update, so these and below
>comments are addressed.
>> Thanks
>>
>
>OK, but have in mind that -gpio-bank suffix is not needed now. This depend=
s
>on support in the pinctrl driver, which will be applied after the merge wi=
ndow
>to different tree or branches than DTS is going to.
>Therefore if I apply your DTS with =22-gpio-bank=22 to my next/dt64, the k=
ernel
>won't find GPIo banks and won't properly boot. The linux-next will be fine=
,
>just my next/dt64 won't be.
>
Thanks, got it, for now let me send v2 on linux-next (as of today).
As required I will rebase to your next/dt64 and send again.
Which also means that my v2 will not be based on your new pinmux schema.
Probably we will move to that after the merge window.

>If you're fine with it - use =22-gpio-bank=22 suffix. If you prefer my
>next/dt64 to have a fully working Tesla SoC DTS, then stick to old node na=
ming
>and let's replace it later.
>
>Best regards,
>Krzysztof