Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18;
Date:   Tue, 18 Jan 2022 16:01:42 +0100
From:   David Heidelberg <david@ixit.cz>
Subject: Re: [PATCH v4] dt-bindings: misc: fastrpc convert bindings to yaml
To:     Rob Herring <robh@kernel.org>
Cc:     Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
        Andy Gross <agross@kernel.org>,
        Bjorn Andersson <bjorn.andersson@linaro.org>,
        Srinivas Kandagatla <srinivas.kandagatla@linaro.org>,
        ~okias/devicetree@lists.sr.ht, linux-arm-msm@vger.kernel.org,
        devicetree@vger.kernel.org, linux-kernel@vger.kernel.org
Message-Id: <U2VW5R.K2NKZT1MORH03@ixit.cz>
In-Reply-To: <7A333484-F1D4-4D0E-97D5-6A40DEC44BFE@ixit.cz>
References: <20211208101508.24582-1-david@ixit.cz>
        <YbPIM9OXyuU5hfHY@robh.at.kernel.org>
        <7A333484-F1D4-4D0E-97D5-6A40DEC44BFE@ixit.cz>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii; format=flowed
Precedence: bulk

Should I pick different approach or keeping additionalProperties: true 
is suitable solution in this situation?

Thanks
David Heidelberg

On Sun, Dec 12 2021 at 13:03:40 +0000, David Heidelberg <david@ixit.cz> 
wrote:
> Well, since this is a subnode, some nodes are not converted yet and 
> at least know it'll bash about iommus, qcom,glink-channels and 
> qcom,smd-channels. I can change it to false, bit it'll print these 
> additional warnings, until other binding don't get converted.
> 
> David
> 
> 
>>  +    required:
>>  +      - compatible
>>  +      - reg
>>  +
>>  +    additionalProperties: true
> 
> Why? What other properties are present.
> 
>>  +
>>  +required:
>>  +  - compatible
>>  +  - label
>>  +  - '#address-cells'
>>  +  - '#size-cells'
>>  +
>>  +additionalProperties: true
> 
> Why? What other properties are present. This is generally never 
> correct.
> 
> Rob
>