Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18;
Date:   Tue, 18 Jan 2022 07:19:04 -0800
From:   Richard Cochran <richardcochran@gmail.com>
To:     cgel.zte@gmail.com
Cc:     andrew@lunn.ch, hkallweit1@gmail.com, linux@armlinux.org.uk,
        davem@davemloft.net, kuba@kernel.org, netdev@vger.kernel.org,
        linux-kernel@vger.kernel.org, Minghao Chi <chi.minghao@zte.com.cn>,
        Zeal Robot <zealci@zte.com.cn>
Subject: Re: [PATCH] drivers/net/phy/dp83640: remove unneeded val variable
Message-ID: <20220118151904.GA31192@hoboy.vegasvil.org>
References: <20220118075438.925768-1-chi.minghao@zte.com.cn>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <20220118075438.925768-1-chi.minghao@zte.com.cn>
User-Agent: Mutt/1.10.1 (2018-07-13)
Precedence: bulk

On Tue, Jan 18, 2022 at 07:54:38AM +0000, cgel.zte@gmail.com wrote:
> From: Minghao Chi <chi.minghao@zte.com.cn>
> 
> Return value from phy_read() directly instead
> of taking this in another redundant variable.

NAK this is purely cosmetic and not clearly better WRT CodingStyle.
 
> Reported-by: Zeal Robot <zealci@zte.com.cn>

Please make your robot less zealous or filter its results before
posting.

This is the second time I told you.  It isn't wise to ignore feedback,
and it is also rude.

Thanks,
Richard