Received: by 2002:a05:6a10:af89:0:0:0:0 with SMTP id iu9csp5884014pxb; Thu, 20 Jan 2022 06:33:35 -0800 (PST) X-Google-Smtp-Source: ABdhPJy+OmVdu4S5tLlGcPKMLlX7V5VRLkQWcLgEeUpfGK0SevWhOCegezNwWWpVhjEHdHBXzVYw X-Received: by 2002:a17:902:b592:b0:14a:d75a:11c0 with SMTP id a18-20020a170902b59200b0014ad75a11c0mr13949018pls.81.1642689214962; Thu, 20 Jan 2022 06:33:34 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1642689214; cv=none; d=google.com; s=arc-20160816; b=G23oMGGISdrRtUBRv+mv8/D5Y0TuTMYk6seScppnkTqxQ/IP9S3R8RgUdoZM5rPnSy 7L63WcOB3AdMtmYgXuJLSXSE2M1qUSGBTwavq4CkUR3y72RUa3LBVpmKq3UNtjk/vjsZ e23TuH216O2obOx5ZN7zNFR8BxNXq/GoteRbg8rth+5UepEThBOpF8dtf0cAGp9VJhBo c1AM0aA7EX4j6bpwWSJ6/uRjzSh7jOAdCZrOX8NI9kF8ndpivzg8G4KDBeEzG5tF4b4g QQS+uHHW9UwRVOog2jSpVlL/UMgrLE/U9jCjSTzSweMofjja5eAMqp8M1CJjP70DcqTC BA7Q== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:in-reply-to:content-disposition:mime-version :references:message-id:subject:cc:to:from:date:dkim-signature :dkim-filter; bh=4Kxcr52+gHAbySx/ypcqz/aerBruEfVlDA6UU7MRmqA=; b=qBpxtVAT04OjxjiWN6Cy6Yp6fS2d72XE64nSyWKwEOUUuYtP1Y9lE6GoNitFlaERLm 5gAQaZ2aNBAjv2DJbzHyarXRWd7//9onv0/xz6NnB21+F/6ilXVaJ6r0NGWLr/aZGtZk LeRGGr2PSz5EUUawq3058TRi1jViV4vA9NDp21BIfyG1vyWeGVbv0TNySISDM55OtQWq F01+gw+LH9NAegIcbGIZTLwDvP5tLtfivv9DwXSzPANevzQ6g6wLCLpVw7jj3rtGvAOW TRW1IJv5FPfH5Mq6aMRB2Ucu1td3ZQD9BJ6JHwH8LadAxSjfNVRjhbtsyj5O3rs2ij89 mGlA== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@linux.microsoft.com header.s=default header.b=rNo3lqJc; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=linux.microsoft.com Return-Path: Received: from vger.kernel.org (vger.kernel.org. [23.128.96.18]) by mx.google.com with ESMTP id c6si3177150pgk.157.2022.01.20.06.33.23; Thu, 20 Jan 2022 06:33:34 -0800 (PST) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18; Authentication-Results: mx.google.com; dkim=pass header.i=@linux.microsoft.com header.s=default header.b=rNo3lqJc; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=linux.microsoft.com Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1345739AbiARP22 (ORCPT + 99 others); Tue, 18 Jan 2022 10:28:28 -0500 Received: from linux.microsoft.com ([13.77.154.182]:34646 "EHLO linux.microsoft.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S235669AbiARP21 (ORCPT ); Tue, 18 Jan 2022 10:28:27 -0500 Received: from sequoia (162-237-133-238.lightspeed.rcsntx.sbcglobal.net [162.237.133.238]) by linux.microsoft.com (Postfix) with ESMTPSA id 33D7A20B926E; Tue, 18 Jan 2022 07:28:26 -0800 (PST) DKIM-Filter: OpenDKIM Filter v2.11.0 linux.microsoft.com 33D7A20B926E DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linux.microsoft.com; s=default; t=1642519706; bh=4Kxcr52+gHAbySx/ypcqz/aerBruEfVlDA6UU7MRmqA=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=rNo3lqJc3Fi043vZPmsF/n6MCeFaLJeFTsCY4AGA1bZ1ZkLUoffQShpUh6LKmgpwx Lu9rlX3AoiV6JE2vfKIFapbVi+QfDXMnXRN1IRkWpTZZdcx8/fiepGX6ZjxyUc0mDS 5CevifvHgY5dnFd6H+Z4zn7IEr/r7OUC0EM1BWCQ= Date: Tue, 18 Jan 2022 09:28:16 -0600 From: Tyler Hicks To: Borislav Petkov Cc: Lei Wang , Tony Luck , Mauro Carvalho Chehab , Sinan Kaya , Shiping Ji , James Morse , Robert Richter , linux-edac@vger.kernel.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH] EDAC/dmc520: Don't print an error for each unconfigured interrupt line Message-ID: <20220118152816.GA89184@sequoia> References: <20220111163800.22362-1-tyhicks@linux.microsoft.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 2022-01-16 19:29:46, Borislav Petkov wrote: > On Tue, Jan 11, 2022 at 10:38:00AM -0600, Tyler Hicks wrote: > > The dmc520 driver requires that at least one interrupt line, out of the ten > > possible, is configured. The driver prints an error and returns -EINVAL > > from its .probe function if there are no interrupt lines configured. > > > > Don't print a KERN_ERR level message for each interrupt line that's > > unconfigured as that can confuse users into thinking that there is an > > error condition. > > > > Before this change, the following KERN_ERR level messages would be > > reported if only dram_ecc_errc and dram_ecc_errd were configured in the > > device tree: > > > > dmc520 68000000.dmc: IRQ ram_ecc_errc not found > > dmc520 68000000.dmc: IRQ ram_ecc_errd not found > > dmc520 68000000.dmc: IRQ failed_access not found > > dmc520 68000000.dmc: IRQ failed_prog not found > > dmc520 68000000.dmc: IRQ link_err not > > dmc520 68000000.dmc: IRQ temperature_event not found > > dmc520 68000000.dmc: IRQ arch_fsm not found > > dmc520 68000000.dmc: IRQ phy_request not found > > > > Fixes: 1088750d7839 ("EDAC: Add EDAC driver for DMC520") > > Signed-off-by: Tyler Hicks > > Cc: > > Why stable? AFAICT, this is fixing only the spew of some error messages > but the driver is still functional. KERN_ERR messages trip log scanners and cause concern that the kernel/hardware is not configured or working correctly. They also add a little big of ongoing stress into kernel maintainer's lives, as we prepare and test kernel updates, since they show up as red text in journalctl output that we have to think about regularly. Multiple KERN_ERR messages, 8 in this case, can also be considered a little worse than a single error message. I feel like this trivial fix is worth taking into stable rather than suppressing these errors (mentally and in log scanners) for years. Tyler > > -- > Regards/Gruss, > Boris. > > https://people.kernel.org/tglx/notes-about-netiquette >