Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18;
Date:   Tue, 18 Jan 2022 16:01:05 +0000 (GMT)
From:   "Maciej W. Rozycki" <macro@orcam.me.uk>
To:     Thomas Bogendoerfer <tsbogend@alpha.franken.de>
cc:     Tiezhu Yang <yangtiezhu@loongson.cn>,
        Xuefeng Li <lixuefeng@loongson.cn>, linux-mips@vger.kernel.org,
        linux-kernel@vger.kernel.org
Subject: Re: [PATCH v2 3/3] MIPS: signal: Remove unnecessary DEBUG_SIG related
 code
In-Reply-To: <20220102133231.GH3468@alpha.franken.de>
Message-ID: <alpine.DEB.2.21.2201180646170.19178@angie.orcam.me.uk>
References: <1639974460-3278-1-git-send-email-yangtiezhu@loongson.cn> <1639974460-3278-4-git-send-email-yangtiezhu@loongson.cn> <20220102133231.GH3468@alpha.franken.de>
User-Agent: Alpine 2.21 (DEB 202 2017-01-01)
MIME-Version: 1.0
Content-Type: text/plain; charset=US-ASCII
Precedence: bulk

On Sun, 2 Jan 2022, Thomas Bogendoerfer wrote:

> > DEBUG_SIG is not defined on MIPS, so DEBUGP() is an empty function.
> > Additionally, it is unacceptable to printk messages in the normal
> > path of signal handling, the system can not work well if DEBUG_SIG
> > is defined, so just remove the related code.
> 
> I like to keep this debug aid for now.

 And it is perhaps worth noting that we have similar developer aids in 
many places across our code base.

  Maciej