Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18;
From:   Sean Anderson <sean.anderson@seco.com>
Subject: Re: [PATCH 2/6] usb: dwc3: Get clocks individually
To:     Robert Hancock <robert.hancock@calian.com>,
        "gregkh@linuxfoundation.org" <gregkh@linuxfoundation.org>,
        "linux-usb@vger.kernel.org" <linux-usb@vger.kernel.org>
Cc:     "linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
        "bjagadee@codeaurora.org" <bjagadee@codeaurora.org>,
        "balbi@kernel.org" <balbi@kernel.org>,
        "baruch@tkos.co.il" <baruch@tkos.co.il>
References: <20220114233904.907918-1-sean.anderson@seco.com>
 <20220114233904.907918-3-sean.anderson@seco.com>
 <1c242d0114554b72f8f0b1f6507973a0dea50b3d.camel@calian.com>
Message-ID: <614267d5-4cfa-94d4-3f2a-c2467b3b9cd6@seco.com>
Date:   Tue, 18 Jan 2022 11:53:25 -0500
User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:68.0) Gecko/20100101
 Thunderbird/68.10.0
In-Reply-To: <1c242d0114554b72f8f0b1f6507973a0dea50b3d.camel@calian.com>
Content-Type: text/plain; charset=utf-8; format=flowed
Content-Language: en-US
Content-Transfer-Encoding: 7bit
MIME-Version: 1.0
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?QUN3ZTR6ZkZXT3VNVjYyQXZ6N2NQZTVFb0lFTWFIWm1vd2RoZ1VYbHkvVXY3?=
 =?utf-8?B?Mm1hQnZhTW5NNW1VS0dtcDJWaldETVk2M29FU0xlR0xTdEdxdk1aT2xXU09M?=
 =?utf-8?B?MkZpV29hMndJWEZ0NHAzYWo1ZGp2Y3VUVlJxdTBHRHRhMXRhYnpHbEVuU3NK?=
 =?utf-8?B?aXcvK2docHZTc21jUUk2T1c5SjFMQ3I3Z0xBd2ZGdXZBMW1NSWlYWTRJSmVt?=
 =?utf-8?B?cEEvY2JlSzliUVkwR2tpcVI1TkgyRXB3UUd1U2ZtaWwrMVExaVE0aElhby9n?=
 =?utf-8?B?Yk44MjFONHYrZG8wU3VQM1A0VVZOU3dBOTZqMmVrQXhSK3Y1bVhFVmcwZVhj?=
 =?utf-8?B?aVA3aHROY2NEaHdQL3JGQ1dpUEZhK003QlI1ajNyajNucHBiTWJ4R0VPcWg1?=
 =?utf-8?B?U2dLWEFmekxscjJLdFc4dWFDNHMzaG1MaE1EMlBFdFMvWXRHMkcyczlaUStz?=
 =?utf-8?B?Vi9HUUgzRXJTZzQ5MElSS1VIRnNZV3U2YjY2Z3hLTEZCdllVSSswVzU2ampY?=
 =?utf-8?B?azd6MU01b3dPZXo4YTBsWFdYSlhSL01vNWg5MG52RW9DZnAvbi85WVZ6R0pt?=
 =?utf-8?B?cVlqakJwOFdNUmJGaXV4a0FJUDhTM2JYbjhPYVN6Kzl0YjNKUnNENkErcnI5?=
 =?utf-8?B?VmtGKzExZFRvTk5aZWFsOEZTam11NHJnQVZLbEhZUDNhYjN1NDhIRFJRNzl2?=
 =?utf-8?B?b3hnRmFWWTFyeWZQZTlEMnVQK3AzMDRKTEkvSHhjSnRVeHJodUtmV0dkUG5O?=
 =?utf-8?B?Y3lyc2VPS3pZR3RXbkNldUJVQmwrMVEyd1ljYm5YRkFKaUozR0FjeVJ0MjhT?=
 =?utf-8?B?MStDaCtXZUpZSkpMbzhrYUEvaWRnSnJ6WDVzVjF5bXZObmRIQXgzQVRzVXBI?=
 =?utf-8?B?blRxYUc4bkowOUQ2ekRXV0tPY2l1cnkwZ2Fqb0JGVDAvQXI1dGJuWkVGZWdL?=
 =?utf-8?B?TUtkTDR2ejlheTRXbHJYaExja3lkemJyaEFHRjJCNzRNem9jRkF5c29DNnlr?=
 =?utf-8?B?cVUyd3BYZFhEOXRSMmFJTlRJdmkzaTRBNmh1S2xVeU8zZUtSSjhmVU80dG9S?=
 =?utf-8?B?UStmNHdOWnFPS09iQkU4NUZGNXJaTU9vZStURTk3K2ZGTHBjQmswakhOSlZ2?=
 =?utf-8?B?dHlmQVdNM2liQ25jMTFTaG84UVYvem90MVdwMDlZcFluK0V5N1FIcjhQQXor?=
 =?utf-8?B?RWVDaHdtMmhaYnA0MC8wSGZkM2NwS2FhSnVnL2VJNU5PMXJhdnBPb2FOYzlT?=
 =?utf-8?B?cXQxZkdiaGFRak1KMjZmRDhuV3dxeDBPT3VFNTlFcXgycm8vY0RLQlRPbGRL?=
 =?utf-8?B?cEpWQnllZEtrVWw3S3NTZHhSWHVzTlAwNFRCZFU0aEhQMVRNQ21Od01JVVpk?=
 =?utf-8?B?NGo5UzNhZElhMzI5UTVBY21XZVNwU1pwbTNuNzhjTUFuR1p6YXV0L1hvL0R0?=
 =?utf-8?B?TWZWc2pRdk53Rlk5QjF0N0JITkxpQnV6dTBWcnk2S3ozdmpPSlp4a2wwZS9k?=
 =?utf-8?B?STBSRlhORkQ2TC9HVVE2L2kyUEsxTVVpMktvdDBhS0pnT3c2VTJ2OEk5Wml6?=
 =?utf-8?B?MVBlUXg3Rk0zd0Q3RGtRNkM2ckowZ2l5bXRkODlQaUsxUXIxbENkTnJiSXIr?=
 =?utf-8?B?M3BCT2twdHh6WU1HbVJ3RTB3WktoaVV4YVhUYVlhTTdIWjJKUlRpV2NmQ3k5?=
 =?utf-8?B?Njl3Rm5pV3dkc2VkbUZhTHZhb1A4UFVzN1Y4bmlkVGszL2NXYlVabzczVmZj?=
 =?utf-8?B?a0ZrUVRKMEZXRzlFWUx5dFIzOUxCN1lxMWVTcnF2MHJsZlNSSXBvaW9GN2xv?=
 =?utf-8?B?NXZucTd0ejhwRmpocTBJV2FZYXlWbFhaM1JxdDM5cHZYcmNvK3VROGZxVzU1?=
 =?utf-8?B?T0lSMzhDeHFtMVhVUFdSUU9pdEFtVmY0dkZvdGZtTWZsKzk2dGp2NnB1Uy9m?=
 =?utf-8?B?bHBWaS82MUwxbTA1d0tDcG1EOEw4UENCSHVHMXljZDZXR2lzVXBqRFhEV2E5?=
 =?utf-8?B?TW52YU94dHRodVFRb20yYW9nMjRLTnpnNTEyMDVZMEVEeWI2bjE0S09VM2lV?=
 =?utf-8?B?L2VHS2syTm9ZbzJGOGJwOG9Dd3FtYnhIcnhJRTBmVmxKeWRwUVJtSmVub0hS?=
 =?utf-8?B?UGdkdlE5NHkwWFpWTmJROG11ZGx6N1N4NGFxNHZBaTcvWXZoMG5kTDF6eWt6?=
 =?utf-8?Q?zoTNB3gVanw7C/HFpO2FRLY=3D?=
X-OriginatorOrg: seco.com
X-MS-Exchange-CrossTenant-Network-Message-Id: 830181f9-2af7-4386-8a4a-08d9daa30d67
X-MS-Exchange-CrossTenant-AuthSource: DB7PR03MB4523.eurprd03.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 18 Jan 2022 16:53:28.9830
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: bebe97c3-6438-442e-ade3-ff17aa50e733
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: w3koFZxjg4xMdRGp8BGwyzLh/+ulbUEhYiJDIYvEdd0Z6ZbNY5YeT4rF+74Fyod9pNBuVaYYGiBgXY7wMbtd3g==
X-MS-Exchange-Transport-CrossTenantHeadersStamped: AM7PR03MB6216
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

Hi Rob,

On 1/14/22 8:04 PM, Robert Hancock wrote:
> On Fri, 2022-01-14 at 18:39 -0500, Sean Anderson wrote:
>> Instead of grabbing all clocks in bulk, grab them individually. This will
>> allow us to get the frequency or otherwise deal with discrete clocks. This
>> may break some platforms if they use a clock which doesn't use one of the
>> documented names.
>
> Another approach would be to keep the bulk get and prepare_enable and just
> search through the clocks in the bulk data to find the "ref" clock, i.e.
> something like:
>
> 		for (i = 0; i < dwc->num_clks; ++i)
> 			if (!strcmp("ref", dwc->clks[i].id)) {
> 				ref_clk_rate = clk_get_rate(dwc->clks[i].clk);
> 				break;
> 			}
>
> That's probably simpler than all the extra complexity to get each of the clocks
> individually and release them in the right order.

Hm, maybe. But in the future, we may want to access other clocks as
well. E.g. perhaps PM might be enhanced by treating the bus/suspend
clock specially for some modes. I think grabbing the clocks up front
will make later patches easier to write.

--Sean