Received: by 2002:a05:6a10:af89:0:0:0:0 with SMTP id iu9csp119072pxb; Thu, 20 Jan 2022 10:00:09 -0800 (PST) X-Google-Smtp-Source: ABdhPJz8iyi8FCf63uhYQso0L9YAF4tfARcfhfgeFEezon6zxdu6nuTe1B+792D0/0+VJ+c1UMh2 X-Received: by 2002:a17:902:7209:b0:149:64f4:b8a1 with SMTP id ba9-20020a170902720900b0014964f4b8a1mr39587501plb.0.1642701609368; Thu, 20 Jan 2022 10:00:09 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1642701609; cv=none; d=google.com; s=arc-20160816; b=tnC54hdnjTX9B1KzJjZK4dA/HuVu9muvRLwjH973xBQuIjyAMe+yyqxpKrCMffeeAm sHXMw31/u8RHkL1TFH4O9fq2flTSvA5VDK8MO1XH6IcKd87i3R3o3QgzYANVwkSTrBWM CtUBcLxBdh0eEXhy+2kqDfHxri53zR+ZZwI9oqqLVv2e84ooMysBMsHtih8wmG3BOhiR pvzA0lmIXAu7mFiIbCThEJl/KjewIHSnPRx8CiH6vlNpSlfx/Y8fmi4itg2QGOnb5xdO FMZ35buBdOgU3qjjl3oQkcVDF8GkSiymvP8/wdErmOt3FXxbRHF/VU1e0l9TLGqNIkuC 7bmA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:content-transfer-encoding:mime-version :references:in-reply-to:message-id:subject:cc:to:from:date :dkim-signature; bh=XlwfbSsSy6hzm89weuxMhB/3+oT4D46Ouf5mr9DDmNI=; b=xfdZvY8qu52E3tbMjrhQQ6x7D/Zucj2Ib0zWP3Tcxq9iJNfUsjsIPrV8YSBFw6rPs0 xo69mw3AvdhWmFreKDLMrSp0mP+kxqrsB0eopFS0DwMAjDFh+2N8Rq/0IpCIGRhpwnKf X2Ctj3+lUp2uIPug+YNGs6FLdCI4dqp7xEphbXJ3jtwB4lCkfvbw+6ardGng9w9CjTxO f/gAILvP6sZrAec6fsm1LU9VEbF8dmUU3onoqin4f4O5OcXR4oNFV7jjiTJ1u9JlFolb 2b8kXU87WZv0a/2I0DLlQlKEmGOU1Lo8fBg/as6gWcO86pXAF3le0u+ooRdSyy3hS8W6 KQ7w== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@kernel.org header.s=k20201202 header.b=KMsh0z7C; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=kernel.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [23.128.96.18]) by mx.google.com with ESMTP id p17si4646897plf.137.2022.01.20.09.59.56; Thu, 20 Jan 2022 10:00:09 -0800 (PST) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18; Authentication-Results: mx.google.com; dkim=pass header.i=@kernel.org header.s=k20201202 header.b=KMsh0z7C; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S243602AbiARQ4p (ORCPT + 99 others); Tue, 18 Jan 2022 11:56:45 -0500 Received: from dfw.source.kernel.org ([139.178.84.217]:34722 "EHLO dfw.source.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S231494AbiARQ4n (ORCPT ); Tue, 18 Jan 2022 11:56:43 -0500 Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by dfw.source.kernel.org (Postfix) with ESMTPS id 7B57960B3B; Tue, 18 Jan 2022 16:56:43 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id A7488C340E0; Tue, 18 Jan 2022 16:56:42 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1642525002; bh=Ju/Q+t8liA9n9d0kVnBQwMlama48+8Kb5bDFdizZR7w=; h=Date:From:To:Cc:Subject:In-Reply-To:References:From; b=KMsh0z7CJqD6FsPcp+1+BgiTrBaEd+23qNE9OoGMxhk66Cb1sPHcajJbQKIU9uKrt UAW6bH+L1dgvuRIiU88zgyyUra/bV+qX0UqVVrlQoIvJQWgHkBYt4junVVQ9VH9QRK QV1qwjsfkHigEzzVYdUGG+wTD+2/yyoJFWqQzNo/0u/sdgOI2proROQfTvIauxRqYr 3HvyzmV9YyIwfMKbO8mDzu3P5ztnQYjLI82KdEaAFGNw+c8LHT2k8sHmrVy3Q9BhXl tmi/j5EkKoeOjKrmUywvZBkyiS3iIdOjhy1mKzg8WF0pZcldeqH8c7V59qSi1QoUNN /xzyTgL6wHGmg== Date: Tue, 18 Jan 2022 08:56:41 -0800 From: Jakub Kicinski To: Sasha Levin Cc: linux-kernel@vger.kernel.org, stable@vger.kernel.org, "David S . Miller" , netdev@vger.kernel.org Subject: Re: [PATCH AUTOSEL 5.16 047/217] cirrus: mac89x0: use eth_hw_addr_set() Message-ID: <20220118085641.6c0c7cc9@kicinski-fedora-PC1C0HJN.hsd1.ca.comcast.net> In-Reply-To: <20220118021940.1942199-47-sashal@kernel.org> References: <20220118021940.1942199-1-sashal@kernel.org> <20220118021940.1942199-47-sashal@kernel.org> MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Mon, 17 Jan 2022 21:16:50 -0500 Sasha Levin wrote: > From: Jakub Kicinski > > [ Upstream commit 9a962aedd30f7fceb828d3161a80e0526e358eb5 ] > > Byte by byte assignments. > > Fixes build on m68k. > > Signed-off-by: Jakub Kicinski > Signed-off-by: David S. Miller > Signed-off-by: Sasha Levin Hi Sasha! You can drop all the eth_hw_addr_set() patches. They aren't fixes, I should have used a different verb, the point was to mention the arch where the driver is built. The patches are only needed in 5.17 where netdev->dev_addr becomes a const. I think that's patches 34-47, 53.