Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18;
Date:   Tue, 18 Jan 2022 17:10:55 +0000
From:   Mark Brown <broonie@kernel.org>
To:     Julian Braha <julianbraha@gmail.com>
Cc:     lgirdwood@gmail.com, perex@perex.cz, tiwai@suse.com,
        Vijendar.Mukunda@amd.com, AjitKumar.Pandey@amd.com,
        pierre-louis.bossart@linux.intel.com, kai.vehmanen@linux.intel.com,
        tanureal@opensource.cirrus.com, linux-kernel@vger.kernel.org,
        alsa-devel@alsa-project.org, fazilyildiran@gmail.com
Subject: Re: [PATCH] ASoC: amd: fix unmet dependency on GPIOLIB for
 SND_SOC_DMIC
Message-ID: <Yeb0n9AVXeVzBHrT@sirena.org.uk>
References: <20220117041528.59958-1-julianbraha@gmail.com>
MIME-Version: 1.0
Content-Type: multipart/signed; micalg=pgp-sha512;
        protocol="application/pgp-signature"; boundary="CS/byuj3seJkHJeR"
Content-Disposition: inline
In-Reply-To: <20220117041528.59958-1-julianbraha@gmail.com>
Precedence: bulk


--CS/byuj3seJkHJeR
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
Content-Transfer-Encoding: quoted-printable

On Sun, Jan 16, 2022 at 11:15:28PM -0500, Julian Braha wrote:
> When SND_SOC_AMD_YC_MACH is selected,
> and GPIOLIB is not selected,
> Kbuild gives the following warning:
>=20
> WARNING: unmet direct dependencies detected for SND_SOC_DMIC
>   Depends on [n]: SOUND [=3Dy] && !UML && SND [=3Dy] && SND_SOC [=3Dy] &&=
 GPIOLIB [=3Dn]
>   Selected by [y]:
>   - SND_SOC_AMD_YC_MACH [=3Dy] && SOUND [=3Dy] && !UML && SND [=3Dy] && S=
ND_SOC [=3Dy] && SND_SOC_AMD_ACP6x [=3Dy]

Why is this a good fix and not removing the dependency on gpiolib from
DMIC?  While a DMIC *can* use a GPIO it's not something that's an
intrinsic requirement and it's entirely optional in the code.

--CS/byuj3seJkHJeR
Content-Type: application/pgp-signature; name="signature.asc"

-----BEGIN PGP SIGNATURE-----

iQEzBAABCgAdFiEEreZoqmdXGLWf4p/qJNaLcl1Uh9AFAmHm9J4ACgkQJNaLcl1U
h9BKuwf/Z8fB1aPDyhYaL2XXxpKPsXuHvvGt5D8UkgJbTPWxZ7fSxW/y7c1N06wl
kxUICkVKHTKHyml19J8jfBoMIiGtOsRj4FupD0ofYuyrBGt6kdMaVg+XVmkwtaDz
MgivjuU+iWO3sX0N490JUfsKlAoZv2RpkrlkD7hHmYIl/ks1a2D695ZJ2vs3unJG
nR8s5zDbf6Zjn6PedxL4uQ7XySc3WJvpcW8Y53ixZLsOiZc4gmA7LBKOXIaWyz4m
bKq9QzokLmwVkB6o7KCVmRj2W9/s0m1X+LMmaAUhgdtBKjX6fyy6TvcFX02RoUUi
LGU7wQKllI2X4535+htPG0KYmDChAg==
=gjhz
-----END PGP SIGNATURE-----

--CS/byuj3seJkHJeR--