Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18;
Date:   Tue, 18 Jan 2022 09:15:51 -0800
From:   Jakub Kicinski <kuba@kernel.org>
To:     cgel.zte@gmail.com, Minghao Chi <chi.minghao@zte.com.cn>
Cc:     Richard Cochran <richardcochran@gmail.com>, andrew@lunn.ch,
        hkallweit1@gmail.com, linux@armlinux.org.uk, davem@davemloft.net,
        netdev@vger.kernel.org, linux-kernel@vger.kernel.org,
        Zeal Robot <zealci@zte.com.cn>
Subject: Re: [PATCH] drivers/net/phy/dp83640: remove unneeded val variable
Message-ID: <20220118091551.7aa44124@kicinski-fedora-PC1C0HJN.hsd1.ca.comcast.net>
In-Reply-To: <20220118151904.GA31192@hoboy.vegasvil.org>
References: <20220118075438.925768-1-chi.minghao@zte.com.cn>
        <20220118151904.GA31192@hoboy.vegasvil.org>
MIME-Version: 1.0
Content-Type: text/plain; charset=US-ASCII
Content-Transfer-Encoding: 7bit
Precedence: bulk

On Tue, 18 Jan 2022 07:19:04 -0800 Richard Cochran wrote:
> On Tue, Jan 18, 2022 at 07:54:38AM +0000, cgel.zte@gmail.com wrote:
> > From: Minghao Chi <chi.minghao@zte.com.cn>
> > 
> > Return value from phy_read() directly instead
> > of taking this in another redundant variable.  
> 
> NAK this is purely cosmetic and not clearly better WRT CodingStyle.
>  
> > Reported-by: Zeal Robot <zealci@zte.com.cn>  
> 
> Please make your robot less zealous or filter its results before
> posting.

Plus what does it mean that the bot has signed this off?

> > Signed-off-by: CGEL ZTE <cgel.zte@gmail.com>

> This is the second time I told you.  It isn't wise to ignore feedback,
> and it is also rude.

Same, you don't reply to emails and keep making the same mistakes.

I asked you to realign the continuation lines in:
https://lore.kernel.org/all/20220112083942.391fd0d7@kicinski-fedora-PC1C0HJN.hsd1.ca.comcast.net/
And without replying you just posted:
https://lore.kernel.org/all/20220118075159.925542-1-chi.minghao@zte.com.cn/