Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18;
Date:   Tue, 18 Jan 2022 17:12:48 +0000
From:   Mark Brown <broonie@kernel.org>
To:     Prasad Kumpatla <quic_pkumpatl@quicinc.com>
Cc:     Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
        "Rafael J. Wysocki" <rafael@kernel.org>,
        linux-kernel@vger.kernel.org
Subject: Re: [PATCH 1/1] regmap-irq: Use regmap_irq_update_bits instead of
 regmap_write
Message-ID: <Yeb1EOtZKnO4sr+E@sirena.org.uk>
References: <20220117091621.30330-1-quic_pkumpatl@quicinc.com>
MIME-Version: 1.0
Content-Type: multipart/signed; micalg=pgp-sha512;
        protocol="application/pgp-signature"; boundary="lBpfOBQ0w1Ud6m8V"
Content-Disposition: inline
In-Reply-To: <20220117091621.30330-1-quic_pkumpatl@quicinc.com>
Precedence: bulk


--lBpfOBQ0w1Ud6m8V
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline

On Mon, Jan 17, 2022 at 02:46:21PM +0530, Prasad Kumpatla wrote:
> With the existing interrupt ack and clear ack logic, only the first
> interrupt gets processed properly and further interrupts will not as
> the ack register is not reset as expected. Use regmap_irq_update_bits

In what way is only the first interrupt processed properly?  How is the
ack register not reset as expected?  Please write a clearer changelog -
I can't tell what problem you're trying to fix here or how the change is
intended to fix it.

--lBpfOBQ0w1Ud6m8V
Content-Type: application/pgp-signature; name="signature.asc"

-----BEGIN PGP SIGNATURE-----

iQEzBAABCgAdFiEEreZoqmdXGLWf4p/qJNaLcl1Uh9AFAmHm9Q8ACgkQJNaLcl1U
h9As6wf+OBgFwjYf4CDokNLeGf/AxVEgB6lDNIld2KCOF0bQG45NWmDU7NvHTDWR
eiBGE4Ch5LX7XRAFZFEFjLy27hRNPrdu5uV7Wtn9l10iiGrDGENJuowXlWv0vS6J
cf7SvzGQA2JAKm3nuhFyUw0L/LmR46bTTFCUC3winEqcIFTBq/2vCqyOHLkTeA2o
0SGIwdDotHlKs/WfbV6KLPi1ccSMlsklbb1zVcG8zJC9IaqFZcZpooDJ8kkgA2Zd
ucXS4L/NgSr8Y1fEGyl+/1UcNcM9L/wmJHJkLqeZ2YuIiMepanWWPHWxVUP0NyI8
aRpvojWBT+j8Rw5HLgCGhkLBaVYGJQ==
=2zcQ
-----END PGP SIGNATURE-----

--lBpfOBQ0w1Ud6m8V--