Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18;
Message-ID: <68ba89ae-108e-c14a-02a0-db72b169c9b1@oracle.com>
Date:   Tue, 18 Jan 2022 12:51:27 -0600
User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:91.0) Gecko/20100101
 Thunderbird/91.5.0
Subject: Re: [PATCH V6 01/10] Use copy_process in vhost layer
Content-Language: en-US
To:     "Eric W. Biederman" <ebiederm@xmission.com>
Cc:     geert@linux-m68k.org, vverma@digitalocean.com, hdanton@sina.com,
        hch@infradead.org, stefanha@redhat.com, jasowang@redhat.com,
        mst@redhat.com, sgarzare@redhat.com,
        virtualization@lists.linux-foundation.org,
        christian.brauner@ubuntu.com, axboe@kernel.dk,
        linux-kernel@vger.kernel.org
References: <20211129194707.5863-1-michael.christie@oracle.com>
 <87tuf79gni.fsf@email.froward.int.ebiederm.org>
 <a171238e-d731-1c22-af72-0f7faf7f4bea@oracle.com>
 <87tuf11oe6.fsf@email.froward.int.ebiederm.org>
 <a3bd6fe7-1775-6fdd-3a02-e779c4d4e498@oracle.com>
 <87pmpoxzuf.fsf@email.froward.int.ebiederm.org>
 <783145b7-243b-b85e-e274-44ef6c0696b9@oracle.com>
 <874k62b76d.fsf@email.froward.int.ebiederm.org>
From:   Mike Christie <michael.christie@oracle.com>
In-Reply-To: <874k62b76d.fsf@email.froward.int.ebiederm.org>
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: 7bit
MIME-Version: 1.0
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?NU0zMHNueXNXZlRybElkbnJ2eS9Jb1ZOUnBnb3NGaFhMTTd1a2hYQjRZZkVJ?=
 =?utf-8?B?MitpRVBuNDdqTnU0V2Q1cGU0V3lZYllVdHNDdXdva1kvdW81aW5pK3lueWNB?=
 =?utf-8?B?ZjBTZkdKdm5Yb2UzcHBpSVk2cmc0T1RKTzc2clVkSlRnL3EwOVAwbXZnd1hm?=
 =?utf-8?B?bVBmU0M4S0J0cEhiVnpBRnBILzB3VnhzOHEzNEtTaURSYjY1SUJ4akYrOWtK?=
 =?utf-8?B?cXVIQnR4eDBFUTYvWVdMb3hkUmZHaml5R2ZESXJDS2RNZ2dMRnBvZTRnUDkw?=
 =?utf-8?B?NDdmYVJ1YVREVkJSN1lLZlVlY0FEV1UyNThCNi9aVDN4VWsybjFFblpWd2I5?=
 =?utf-8?B?cmh1K1FISElrdHJYM1F6Y3RRaUJJT09GZjJQV3pwY1RPbDZ0Y05LSnZaeHhq?=
 =?utf-8?B?QUUwM2ZSdTNRRS8yM2lwMW9jbFZuNmQyc3ZLN0pkMlB1T2Y4Q0VPellXZ2Jy?=
 =?utf-8?B?ZWZIdWJPNUtROSsrVis3eUc3QkdsdUM4UkdwYVRYUWZHRkFtcUoza1RzSXkw?=
 =?utf-8?B?Nm9zL0R2bkE0ZXd6NGZTcHdYV0x5bWdPOXlVa0Y0WXdNZTBRSXRYUE1aTjlu?=
 =?utf-8?B?cXREZ2ZZWENEYUVoWSt2eUo0UnJhM1dTbysydmE2S2ptQWlQenpXbi9OTEJt?=
 =?utf-8?B?UEFFMFRjRmJNK1owNGNiQ2s4b0pEejVQcUVmNUtiTnRISDl4M0g0SWFFb0k2?=
 =?utf-8?B?bEJibFE4MXFCMUtneC9EWU9mV1BRdmZnQ2s0S3p4VTdOT0N1VXJPMjJES0w3?=
 =?utf-8?B?Q1Z4amFCakhFWjVpNWVLSlY3Ulo0N2lZRWMyOVhqTmRUWmdWb1dPZ2FQUnlW?=
 =?utf-8?B?S0wreXRZZDhwZFJhU3pKU0VnMmtBV09PRWNsVnRHUnFSVnozbjZ2SnRLYWlC?=
 =?utf-8?B?VzNHSUxONUpFMHU4ckNhN09kN2NydkwwUmY2bEJ1Vy8vMkFsMUxRVmowU1JO?=
 =?utf-8?B?RHpnYzlyT3J1WGtBcW1XTjRja05yN3dWaEJkOVk0M25hd21pS2sxb2k2cU9Z?=
 =?utf-8?B?SHoyKzlVa3FkTmJucGZaaEJtL0hxMzVPQnQwcHdUdm5mYThMdU1CenBjcFIx?=
 =?utf-8?B?SGhFSldOOHRUQXNDbzBDMmF6Tk1QZ3V4UzV0QVpRLzJIbFVmUEtCQkFBaDJ2?=
 =?utf-8?B?YWp6WDBaQkJXY2UzMnVUK0lVWEE4WXFkNmdwU21WUlBCK2xWRFVqRTB5dDBp?=
 =?utf-8?B?YmtsYVRQMmJoL0QwWjhWdkhybnBzbjRrRVhZbGZPWWxsb29NOE51Sy9NRUhR?=
 =?utf-8?B?Y3BGN1NhZGVKb0N3RTZBN0h0UVVObUV5VDFqTldNWUtqdVdjZWdMMUg5Vlg0?=
 =?utf-8?B?Y21welFxM1lGN2tROUxvakwyYTlLcUpINHdIQy9uNmJodFh4cXB1NUpRNFpK?=
 =?utf-8?B?YjhObXFHNWMrR2EyTnJpK01RekI1VGhwcGVBYlpWaThjTTlZVE1CVmZDQWxZ?=
 =?utf-8?B?bHBZR1NFOVFhQmFsVGpsZzZ3cHprQmNySVlsbUV2djdsZitXTEFYd05XRDJP?=
 =?utf-8?B?azJlbWRPaXZENlRkQUxaUmUvVFlZNVg0VjR2QUtNTzJqNG1RclFJNFRYU3V2?=
 =?utf-8?B?dGVxdDFJWDZjMG84VURiblFFSnpJU3ArZ1BVSzlOVStnYUhDYW41OURJR0lo?=
 =?utf-8?B?VnlWd3NOOThIUzE3VFhUejZNQkVUa1pwREVnQkcyQUo1TEVGWXZwUXR5aTB0?=
 =?utf-8?B?VHRIdXpZbHNoM0JRNlRRZDVVRGVQVGc4cVdMdm90eE5IcXZiNXh2ZTZobHY2?=
 =?utf-8?B?TzVMeWwvZ3dFcmZ6R0t5QXdta3FJQ0NWTjUwdGVzZXZWTXAzeEhWZXR2d095?=
 =?utf-8?B?RjNkdDdvZmt0c3Z4V28wbnVvWU9HRHN0ZFczRTBTSDVVV3NselZBK3d6enY2?=
 =?utf-8?B?UGxsbWl4M1dUSUZlby8rUmNEN3FoMmE1NDM1NXJ6Z3FBbUxna2YwTlcvMSti?=
 =?utf-8?B?aDUyTElWSWsvVnN2cEtvcjlmOUhYeDMyaUpXWFg3aE5TRENzMHlpUHVzYk9i?=
 =?utf-8?B?RzIxNTcrMEx2WUtCam9QSmJxNExpdUJycHE2OE9lTkd3NmdGcGtJQmt4YlVr?=
 =?utf-8?B?Y2dhMGRVQ1pXTVVGRXZaTENLV2d1bXhYam01ZGZ1eDBlY1lRVEdDOEsxdVpl?=
 =?utf-8?B?dDJWVnZpNWxmZEY5NzljbEhlb1VmV2lMVWRmdW9jcnBSMWpiRWRHQTh3WFZo?=
 =?utf-8?B?cU1rbjd6VW5Ib3NrbFZheERNUFJ1YnpnemZoa2QvS0xJeVpUeitYOWxic1ha?=
 =?utf-8?B?bVBpOG9nbnMwblpKa2hkcVJSaWl3PT0=?=
X-OriginatorOrg: oracle.com
X-MS-Exchange-CrossTenant-Network-Message-Id: 6c462a9f-d317-446a-b2d6-08d9dab38971
X-MS-Exchange-CrossTenant-AuthSource: DM5PR10MB1466.namprd10.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 18 Jan 2022 18:51:29.1598
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: 4e2c6054-71cb-48f1-bd6c-3a9705aca71b
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: nnJVvfE/bg1ibn76hTDPFMp58LRFVSWNU1S/iw38w/RvTyx27bFudz4NfLRITDQ98ZEfD2mJzh3oN/lOnKjNjZPFkF+vEYimihdkZZRqdfw=
X-MS-Exchange-Transport-CrossTenantHeadersStamped: DS7PR10MB5360
X-Proofpoint-Virus-Version: vendor=nai engine=6300 definitions=10231 signatures=668683
X-Proofpoint-Spam-Details: rule=notspam policy=default score=0 suspectscore=0 bulkscore=0
 malwarescore=0 adultscore=0 phishscore=0 mlxscore=0 spamscore=0
 mlxlogscore=999 classifier=spam adjust=0 reason=mlx scancount=1
 engine=8.12.0-2110150000 definitions=main-2201180112
X-Proofpoint-GUID: OIEzz4g3TcUtwZUJ481ckcCk9HrJsP0C
X-Proofpoint-ORIG-GUID: OIEzz4g3TcUtwZUJ481ckcCk9HrJsP0C
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

On 1/17/22 11:31 AM, Eric W. Biederman wrote:
> Mike Christie <michael.christie@oracle.com> writes:
> 
>> On 12/22/21 12:24 PM, Eric W. Biederman wrote:
>>> All I am certain of is that you need to set
>>> "args->exit_signal = -1;".  This prevents having to play games with
>>> do_notify_parent.
>>
>> Hi Eric,
>>
>> I have all your review comments handled except this one. It's looking like it's
>> more difficult than just setting the exit_signal=-1, so I wanted to check that
>> I understood you.
> 
> [snip problems with exit_signal = -1]
> 
>>
>> What do you think?
> 
> I was wrong.  I appear to have confused the thread and the non-thread
> cases.
> 
> Perhaps I meant "args->exit_signal = 0".  That looks like
> do_notify_parent won't send it, and thread_group_leader continues to do
> the right thing.

That doesn't work too. exit_notify will call do_notify_parent but 
our parent, qemu, does not ignore SIGCHILD so we will not drop
down in into this chunk:

        psig = tsk->parent->sighand;
        spin_lock_irqsave(&psig->siglock, flags);
        if (!tsk->ptrace && sig == SIGCHLD &&
            (psig->action[SIGCHLD-1].sa.sa_handler == SIG_IGN ||
             (psig->action[SIGCHLD-1].sa.sa_flags & SA_NOCLDWAIT))) {

do_notify_parent will return false and so autoreap in exit_notify will
be false.


> 
> Baring any additional confusion on my part that cleanly solves the
> problem of how not to send a signal from a child process cleanly.
> 
> My apologies for sending you on a wild goose chase.
> 

It's no problem. I learned a lot about signal handling :)