Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18;
Message-ID: <b0055d0c-a745-4f48-4c4a-373d47651b3f@linux.ibm.com>
Date:   Tue, 18 Jan 2022 13:52:55 -0500
MIME-Version: 1.0
User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:91.0) Gecko/20100101
 Thunderbird/91.4.0
Subject: Re: [PATCH v2 06/30] s390/airq: allow for airq structure that uses an
 input vector
Content-Language: en-US
To:     Claudio Imbrenda <imbrenda@linux.ibm.com>
Cc:     linux-s390@vger.kernel.org, alex.williamson@redhat.com,
        cohuck@redhat.com, schnelle@linux.ibm.com, farman@linux.ibm.com,
        pmorel@linux.ibm.com, borntraeger@linux.ibm.com, hca@linux.ibm.com,
        gor@linux.ibm.com, gerald.schaefer@linux.ibm.com,
        agordeev@linux.ibm.com, frankja@linux.ibm.com, david@redhat.com,
        vneethv@linux.ibm.com, oberpar@linux.ibm.com, freude@linux.ibm.com,
        thuth@redhat.com, pasic@linux.ibm.com, kvm@vger.kernel.org,
        linux-kernel@vger.kernel.org
References: <20220114203145.242984-1-mjrosato@linux.ibm.com>
 <20220114203145.242984-7-mjrosato@linux.ibm.com>
 <20220117132920.213bf0bd@p-imbrenda>
From:   Matthew Rosato <mjrosato@linux.ibm.com>
In-Reply-To: <20220117132920.213bf0bd@p-imbrenda>
Content-Type: text/plain; charset=UTF-8; format=flowed
Content-Transfer-Encoding: 7bit
Precedence: bulk

On 1/17/22 7:29 AM, Claudio Imbrenda wrote:
> On Fri, 14 Jan 2022 15:31:21 -0500
> Matthew Rosato <mjrosato@linux.ibm.com> wrote:
> 
>> When doing device passthrough where interrupts are being forwarded
>> from host to guest, we wish to use a pinned section of guest memory
>> as the vector (the same memory used by the guest as the vector).
> 
> maybe expand the description of the patch to explain what exactly is
> being done in this patch. Namely: you add a parameter to a function
> (and some logic in the function to use the new parameter), but the
> function is not being used yet. And pinning is also done somewhere else.
> 
> maybe you can add something like
> 
> 	This patch adds a new parameter for airq_iv_create to pass the
> 	existing vector pinned in guest memory and to use it when
> 	needed instead of allocating a new one.
> 
> Apart from that, the patch looks good.
> 

Thanks, will re-work to:

When doing device passthrough where interrupts are being forwarded from 
host to guest, we wish to use a pinned section of guest memory as the 
vector (the same memory used by the guest as the vector).
To accomplish this, add a new parameter for airq_iv_create which allows 
passing an existing vector to be used instead of allocating a new one. 
The caller is responsible for ensuring the vector is pinned in memory as 
well as for unpinning the memory when the vector is no longer needed.
A subsequent patch will use this new parameter for zPCI interpretation.