Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18;
From:   Sean Anderson <sean.anderson@seco.com>
Subject: Re: [PATCH 0/6] usb: dwc3: Calculate REFCLKPER et. al. from reference
 clock
To:     Thinh Nguyen <Thinh.Nguyen@synopsys.com>,
        Baruch Siach <baruch@tkos.co.il>
Cc:     Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
        "linux-usb@vger.kernel.org" <linux-usb@vger.kernel.org>,
        "linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
        Robert Hancock <robert.hancock@calian.com>,
        Felipe Balbi <balbi@kernel.org>,
        Balaji Prakash J <bjagadee@codeaurora.org>,
        Andy Gross <agross@kernel.org>,
        Bjorn Andersson <bjorn.andersson@linaro.org>,
        Michal Simek <michal.simek@xilinx.com>,
        Rob Herring <robh+dt@kernel.org>,
        "devicetree@vger.kernel.org" <devicetree@vger.kernel.org>,
        "linux-arm-kernel@lists.infradead.org" 
        <linux-arm-kernel@lists.infradead.org>,
        "linux-arm-msm@vger.kernel.org" <linux-arm-msm@vger.kernel.org>
References: <20220114233904.907918-1-sean.anderson@seco.com>
 <87iluifxy1.fsf@tarshish> <7831a4f7-7c3f-4a2a-be73-38f2c40a123c@synopsys.com>
Message-ID: <f28052d9-5dea-a05b-8745-09e4d237b539@seco.com>
Date:   Tue, 18 Jan 2022 14:53:34 -0500
User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:68.0) Gecko/20100101
 Thunderbird/68.10.0
In-Reply-To: <7831a4f7-7c3f-4a2a-be73-38f2c40a123c@synopsys.com>
Content-Type: text/plain; charset=utf-8; format=flowed
Content-Language: en-US
Content-Transfer-Encoding: 7bit
MIME-Version: 1.0
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?eENtNzJOb1NQcUlxWUsxdm9OQ2ZveU9sK3dTV1IyVTNGMWlBVzUrcE14WUdD?=
 =?utf-8?B?V2JlTEhObnNLOGU4RGwwVGVxZ2hqK2MzRE8xWjF2bFBSclU0ZjFsdGdKU08x?=
 =?utf-8?B?Z2Vsak1QSFZQRHJqeHJvb2wvRXM3N3RLclV3UTZIaWJDM2E0ZzJ0eVNmVXJF?=
 =?utf-8?B?c2lPRFdBZTd1RzBLWXBrZjI2YzRZNVNZK08vWks4V1ZzM2p2UG82Mnh1RC9Y?=
 =?utf-8?B?ME9yR3pQbE84eEtFeFVqZkhVNWYxUEtRWjhRUDhBTmVQazhoUUlEZmRwUS9k?=
 =?utf-8?B?RjNkeDA3d0lURk5WR0k1ZUhocWxrTFU0eU5CcC9XMTFnYkhuRW42ek1Tb0d3?=
 =?utf-8?B?dFEzRkl5bVdqZ0gxWFQ5NjNNaHZzTlFlWmE5THVWcVFpMWFkem5DdVVIdlhi?=
 =?utf-8?B?SlExK0ZadzIvcmtnd1M3cWNUenpzK2oxOG9wQWE0bWxiYVV1SHNzVEVQMzU5?=
 =?utf-8?B?eXJjUlVTRUZ6Z0tJWmJWU0llRDd5dXlXTURQcEM2VjRtWURoUEhEbVUzV0Y0?=
 =?utf-8?B?ajF1eWI4TDVMcFg5eUs5VmJURzUrZWJpckUrSzNuQ0pZMUhpcDNMeVZiTTFy?=
 =?utf-8?B?Z2VwRGltOWRTOVY1RzVuQlpKU0d4NFNEVEQ3ZmV2UVQ4WmkyV1B6bFdYeGFF?=
 =?utf-8?B?eXZPSGt4bVNsMTJHakNQcGlQU2tRK3BpZHJ1NG5ob2NSVGZwMUVhanBQbkxs?=
 =?utf-8?B?aTkxSGU3cDN4RHBORk5RbmxjVXlWZEtCdTQ4UUZ4NGhyZ2RlUHB2QW5FNlV1?=
 =?utf-8?B?akNnOTcrSERLTDNVd083VFlxV2RjZjFNWmFTV2RWZVkyQVRuUlREaXlsWVVH?=
 =?utf-8?B?cDh5eDBseGh5Z21xZ1Z2RDU2SHZHSHFVUUF5cmI2QVRJTU5EN0t2cGJTSzlv?=
 =?utf-8?B?ZXl5aXFqU2xjb012S3JmYjBJTWRjbjVlK3V4OWNjdnNVWnoxNEJtTDNXQklL?=
 =?utf-8?B?S0Q5Z3VtNE96eUxrbTJ6eHRrYS9LNWhOVDZTaURxUlFGMW9xYUtHNEN3OGZS?=
 =?utf-8?B?MnhKV3BHWm5kMmFnbmx0YnhIanJZWkdKS3Qyb0hsemp1Y200V01ZeFdtY0pZ?=
 =?utf-8?B?d3NCVGNpZnoreW9KZnlIODlBSW93K3BwVjIrWUJmbDNyTHRLUmZuTjJZRUwr?=
 =?utf-8?B?eFpDUDhRS1MyWXUwQzY0ak8xOUpvQm96cXBiT1p3djFCZmNVTDNnSDhFNUYz?=
 =?utf-8?B?Zmhma2Z5RHpqVFJYMjR6RzZ5QjBWUklnQXdpZ3lWOUlONm5lNkNNU01SdVJ6?=
 =?utf-8?B?OEdybkh3Q2haT09FdTFJcEJIMEwwaGJ1d2ZMY0F4dGxKTWZBSjllWHBwUXNT?=
 =?utf-8?B?RXlzSHNKOS8vL2tYSXNxcG00MGZEd29xZThFT01zZjNMZXVzY24xb3NQeG5s?=
 =?utf-8?B?ZUhjV1VzUitpeHFVRUUrSzhwWG9WTjZqcU1yUjRYMFU1OFNXRjdBaXM5TzZG?=
 =?utf-8?B?TXVPS2ZjTFJoeElJTEdzSDlmelpEZGxmMnNRV3pwOXNNb2Z4and5dXh4VlFh?=
 =?utf-8?B?bW1MZDJKYXhTd3dSNmV6VjY0R2pqc3hrc09lcktOOFFmcHNzVWFnVGg0Zmph?=
 =?utf-8?B?QkFlTElMbWFPZ1BwbmVMQ09yRnVpK0sySmQzN3lFSWhyVUNBVTlnMkkxTGFr?=
 =?utf-8?B?a1JFQTk1RmhWaGNpWmozUU9keVJwVWp1aWRHSithaXc5UE9iWjJxZG9FcFJq?=
 =?utf-8?B?aTBqRmpldFVaS2xhdFBrTFhVeGVJM3BPNEtmS2p5bkxhdzNtbDRDNVlIditS?=
 =?utf-8?B?aUlRckFXVjdaSWpuYXBReFZFLzhmNDdiODNKRThoc2U1aFlDU1NkNnlrNWpq?=
 =?utf-8?B?SmlNalNjOEg0NjZUVFNzRlFaYlozM3NGYXhIaTY0WVBZbk5Mcm1Va2VCdUpp?=
 =?utf-8?B?RXJ3SDNBQ2hFdGp5TFRjQVJLMVRZZWdtUlRNc1AvT0R4VlQxSkgydU8yMDl5?=
 =?utf-8?B?Ym1aUURxTXhwNGlESDZCaW5EcmorWnlVR0R2NFVtN2ZuM0haSnJFN3ZkODRP?=
 =?utf-8?B?L2tOYng2a3JuY2x5cGxwd01teTVjZk43ZlhhaTRJdjNzcW9LNjBxcVZCRDlJ?=
 =?utf-8?B?eHVYRDBoWEtmUVB0NnZzOGZRL0FYamsweDF3V3kwbUhMVnVlQ3A2N0xRRmZV?=
 =?utf-8?B?cWs1NnlSenNSRjF0ajJUNDg3UTlTSnVWN1BJQW1FbGdDd1JOdHhxK2JIV2Vu?=
 =?utf-8?Q?emEM0iqWWCEzqf79ibTcYZQ=3D?=
X-OriginatorOrg: seco.com
X-MS-Exchange-CrossTenant-Network-Message-Id: 6fb5d056-cd93-4c59-382a-08d9dabc38f6
X-MS-Exchange-CrossTenant-AuthSource: DB7PR03MB4523.eurprd03.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 18 Jan 2022 19:53:39.5409
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: bebe97c3-6438-442e-ade3-ff17aa50e733
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: 2oYUrVPWo8gq7U6clJcCP3b72t4LGXSlnAIRxtLhj82ov+exB39ndYqg2PysYUaiM6Qf/FtYDRm9NCm/EUrSXQ==
X-MS-Exchange-Transport-CrossTenantHeadersStamped: VI1PR0301MB2414
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

Hi Thinh,

On 1/18/22 2:46 PM, Thinh Nguyen wrote:
> Hi Sean,
>
> Baruch Siach wrote:
>> Hi Sean, Thinh,
>>
>> On Fri, Jan 14 2022, Sean Anderson wrote:
>>> This is a rework of patches 3-5 of [1]. It attempts to correctly program
>>> REFCLKPER and REFCLK_FLADJ based on the reference clock frequency. Since
>>> we no longer need a special property duplicating this configuration,
>>> snps,ref-clock-period-ns is deprecated.
>>>
>>> Please test this! Patches 3/4 in this series have the effect of
>>> programming REFCLKPER and REFCLK_FLADJ on boards which already configure
>>> the "ref" clock. I have build tested, but not much else.
>>>
>>> [1] https://urldefense.com/v3/__https://lore.kernel.org/linux-usb/20220114044230.2677283-1-robert.hancock@calian.com/__;!!A4F2R9G_pg!M3zKxDZC9a_etqzXo7GSEMTHRWfc1wR_84wwM4-fShiA35CsGcxcTEffHPbprbdC4d2R$
>>
>> Thinh, you suggested the dedicated DT property for the reference clock:
>>
>>   https://urldefense.com/v3/__https://lore.kernel.org/all/d5acb192-80b9-36f7-43f5-81f21c4e6ba0@synopsys.com/__;!!A4F2R9G_pg!M3zKxDZC9a_etqzXo7GSEMTHRWfc1wR_84wwM4-fShiA35CsGcxcTEffHPbprbpOFmvX$
>>
>> Can you comment on this series?
>>
>
> Unless there's a good way to pass this information for PCI devices, my
> opinion hasn't changed. (Btw, I don't think creating a dummy clock
> provider and its dummy ops is a good solution as seems to complicate and
> bloat the PCI glue drivers).

Can you explain your situation a bit more? I'm not sure how you can
access a device tree property but not add a fixed-rate clock.

--Sean