Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18;
Message-ID: <6920ea3c-5833-952c-5530-b02560e307aa@oracle.com>
Date:   Tue, 18 Jan 2022 15:47:13 -0700
User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:91.0) Gecko/20100101
 Thunderbird/91.3.1
Subject: Re: [RFC PATCH 0/6] Add support for shared PTEs across processes
Content-Language: en-US
To:     Matthew Wilcox <willy@infradead.org>,
        Dave Hansen <dave.hansen@intel.com>
Cc:     akpm@linux-foundation.org, longpeng2@huawei.com, arnd@arndb.de,
        dave.hansen@linux.intel.com, david@redhat.com, rppt@kernel.org,
        surenb@google.com, linux-kernel@vger.kernel.org, linux-mm@kvack.org
References: <cover.1642526745.git.khalid.aziz@oracle.com>
 <eb696699-0138-33c5-ad47-bfca7f6e9079@intel.com>
 <Yec1OZ0reX2EMXL7@casper.infradead.org>
From:   Khalid Aziz <khalid.aziz@oracle.com>
In-Reply-To: <Yec1OZ0reX2EMXL7@casper.infradead.org>
Content-Type: text/plain; charset=UTF-8; format=flowed
Content-Transfer-Encoding: 7bit
MIME-Version: 1.0
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?LzNxdmh3OUJLbHpOQlRDWkJHNWRNM0ZMcjhXd2VhU2V0MjAwRDdtVmRCWFpW?=
 =?utf-8?B?bC9aRE9mMDB1Vm9oVDBBNXpKcXlKTFQzbEdPYWd6MW1pVFhDd2Q2cUc1YW41?=
 =?utf-8?B?akNKZk9nS0IydVl4bmpQcmt2bEtMS3pxMW4vMW50QXVEWmEwU1AzMlUwQ0xv?=
 =?utf-8?B?NWdYMW1BWGliVUFKeFUrbVl0aHR6ajgwZ1NnM2NsNWJrSk1SZDlDMnR3UlEx?=
 =?utf-8?B?ZitrbjdRYTM4U3lNVkl1RUs5eWFHTDkzWHA2RVFBRGJQdnp0UjREMHJTUHg4?=
 =?utf-8?B?ZVRYc2F1bDV5NGVZUjFmUlh5TGE0R0xGc1FhdUNGOUJCQUtjVHA2eUFMcXc2?=
 =?utf-8?B?cTJqcXUrcUlWOWNxUnhIaittK2lKVUtrUVdNclVLanpCTkkya040QU9mYnJv?=
 =?utf-8?B?SkkvcC83ODdQOGFIc1dGeGtaQ3l5RHhsKys1bFRaNkQvRGkxb2wrc0ZXQVhl?=
 =?utf-8?B?UUhnRTNJV042bjE2NXVZWHZURWRvWVpLYW1SNVcvUW9Bek01NWdnd3U5MHdi?=
 =?utf-8?B?cncwSkUzcWNFV0pYcHZyNUdvT0tlRTZHaTV1UVg1UHBGeVg3TnQ4Q0IzQVF3?=
 =?utf-8?B?R001SVFYQzQrRDJ0OWRTaVhKYmFLNmMxa0VQS2piaWNhaHRPa3NsT0dxVW85?=
 =?utf-8?B?Q3hSQ3EvazdMdjQ1enpvenQ3Z04rbzlGUytNQTkrOE5MSmZBRWRKQnR4d0JS?=
 =?utf-8?B?ZnFWZU5EdVBoUFZpNngrdGM4a2NWRDI0SWI1LzlaMk1nS3JsclVvUXVoL3Fp?=
 =?utf-8?B?dUpHV2ZpN0ZTWGJUbXg0dVhsYUtBakVYb0xxRjNHRHFPbmF2ZzA1L1BDaStM?=
 =?utf-8?B?b0J3N01IL21aSjRLbnUrdlFOL3ZDanpReTZOekJLRkV4NUtwU3RnQ2JwZ25D?=
 =?utf-8?B?MXo3eEhxQWVqY2dqbGJEYUNlTmxjb3o0Z1JyVkVubEI3Vzg3ZXcwbks0SEJK?=
 =?utf-8?B?bW96Zm1naFFNY2dxV0pLTStIejIxMTlJSjZYNmRINEg3UmtXOWV4Uzd4ci94?=
 =?utf-8?B?K1A5V2djci9kemNBYXptV1YwU2ZvT3FVblZYVk9wejJmOGxybXB6SE1ZNldm?=
 =?utf-8?B?WkVGc0xmWG9SZ0VEcU1RSlBsZ0txTzBjWWZ6ZDcvYVZYdzNYZUQrYUtmbXhD?=
 =?utf-8?B?TEZMUnVrVXNMZERTZ1Q4YVFJVUN1YnE2ZUFLendvTG9OZWNNNjdIK1IyL0dq?=
 =?utf-8?B?TnFEUDlMcW9pK29vbFZRMEV5M3RTL1htSUNEYmU0SkRjN2JPaFNqMkZnMlBE?=
 =?utf-8?B?UllwQllQWFVjM0hpNWZvUC9vUkc0T0d3MG0wSTc1UW8vTVZQamlPdjhnN3RB?=
 =?utf-8?B?S1JoRmZWNXRZVnNqNktERit3NDNGQ3djM2N2c3hXY0xXUmw1R2ZyZTlTNFg2?=
 =?utf-8?B?TUxCWWo5ZExIa3J6MFVqZDYvZExENUxWU010NnJTTUZuMENwemJtbGd3Z1Ns?=
 =?utf-8?B?bU0wQitRektWZk8rWDNsSHRTV3FWTXVISk81M0REYmFOVzU3MldSMHRxVjZK?=
 =?utf-8?B?LzdKZTg0N2xRdFpXQmlMZG42OVhwRDlDNXhjM3p3cjZSYlZhaVVEcHIvSHBO?=
 =?utf-8?B?VUR4bGJYbWc0QVpyQy8ycGNwN2dqdXZhcTdZZmxiYWp2aUhadlpmRW9kemp0?=
 =?utf-8?B?ZmxiM2VQU1NhSkpxZTgxT3lQTnA0OEFaeU9weXlBY2JqUGF4WVpEYlo0V21h?=
 =?utf-8?B?WGI0QTRaNlFuR1JVaW9VMWtuNFNRYUNuODBseW1yVjlhalh0bXV4OWdaUjY1?=
 =?utf-8?B?OWpPTHR5dGxhb3dWMWZQNmdtZFc3eGFSQzBzc2FHYlRCbldzS0RuQWV4TUl6?=
 =?utf-8?B?STlTR0ZXT29VVFUwbDhTQlE2ZXVFMWQzYnZJVVFHdjFLYmV0ZkdsRXpGVlAx?=
 =?utf-8?B?MDhvQ2lRRHhycW9GOUNqQmR3alk0VnYvaHBOU2NSMVhEZC9UZHNXdC94YXRE?=
 =?utf-8?B?bkxSMnVoMDk1bFRxTVZpQzBieHJpcWJJb25wYWJmeno5Mysybkx4dzN4Q2Fr?=
 =?utf-8?B?bjhCS3RWK0g3cWhoZ3lSOEhnR3EzUHFFSm92eXJ3NTUycHZTT3UvZ1RERGQw?=
 =?utf-8?B?dUEyTUw5SGt6S0Y3cGc2N0JacVlXbGNKVEl0ZWhhMmtCaXFhUnZwbVBhMnpP?=
 =?utf-8?B?dXpUMGFYVTV4SFlmTGExcDFaQmowZUZscktzYXZzY1ZySjBxMG1Iekk4ZTI3?=
 =?utf-8?B?REZhbElGNVcvamdZM3pxc29DRGFzM09BUkxZZ0RpQUpNbTBLci91RFdhODNQ?=
 =?utf-8?B?VjlCdW5mSEd1OUVGWW9hRDNDYndRPT0=?=
X-OriginatorOrg: oracle.com
X-MS-Exchange-CrossTenant-Network-Message-Id: 4e40a4ba-9cde-4eb5-6f38-08d9dad47b50
X-MS-Exchange-CrossTenant-AuthSource: BN8PR10MB3220.namprd10.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 18 Jan 2022 22:47:18.8457
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: 4e2c6054-71cb-48f1-bd6c-3a9705aca71b
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: cJKY3gE8/14KgSd2DMZJ19eZ0+4HZ9JkHRGZlzxKCgI2Qkbagmo09KNXGOcRveAcxDjFqRq9H25TkoapUNApZw==
X-MS-Exchange-Transport-CrossTenantHeadersStamped: BLAPR10MB5219
X-Proofpoint-Virus-Version: vendor=nai engine=6300 definitions=10231 signatures=668683
X-Proofpoint-Spam-Details: rule=notspam policy=default score=0 suspectscore=0 bulkscore=0
 malwarescore=0 adultscore=0 phishscore=0 mlxscore=0 spamscore=0
 mlxlogscore=999 classifier=spam adjust=0 reason=mlx scancount=1
 engine=8.12.0-2110150000 definitions=main-2201180127
X-Proofpoint-GUID: x7hAvTtT60Cfa5HbrdAubTNTFVPXQEjO
X-Proofpoint-ORIG-GUID: x7hAvTtT60Cfa5HbrdAubTNTFVPXQEjO
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

On 1/18/22 14:46, Matthew Wilcox wrote:
> On Tue, Jan 18, 2022 at 01:41:40PM -0800, Dave Hansen wrote:
>> On 1/18/22 1:19 PM, Khalid Aziz wrote:
>>> - Starting address must be aligned to pgdir size (512GB on x86_64)
>>
>> How does this work on systems with 5-level paging where a top-level page
>> table entry covers 256TB?  Is the alignment requirement 512GB or 256TB?
>>   How does userspace figure out which alignment requirement it is subject to?
> 
> The original idea was any power of two, naturally aligned, >= PAGE_SIZE,
> but I suspect Khalid has simplified it for this first implementation.
> 

Hi Dave,

Yes, this is mostly to keep code somewhat simpler. Large regions make it easier to manage the separate set of shared 
VMAs. Part of the exploration here is to see what size regions work for other people. This initial prototype is x86 only 
and for now I am using PGDIR_SIZE. I see your point about how would userspace figure out alignment since this should 
across all architectures and PGDIR_SIZE/PMD_SIZE/PUD_SIZE are not the same across architectures. We can choose a fixed 
size and alignment. I would like to keep the region size at 2^20 pages or larger to minimize having to manage large 
number of small shared regions if those regions are not contiguous. Do you have any suggestion?

Thanks for your feedback.

--
Khalid