Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18;
From:   Peng Fan <peng.fan@nxp.com>
To:     Mathieu Poirier <mathieu.poirier@linaro.org>,
        "Peng Fan (OSS)" <peng.fan@oss.nxp.com>
CC:     "bjorn.andersson@linaro.org" <bjorn.andersson@linaro.org>,
        "shawnguo@kernel.org" <shawnguo@kernel.org>,
        "s.hauer@pengutronix.de" <s.hauer@pengutronix.de>,
        "kernel@pengutronix.de" <kernel@pengutronix.de>,
        "festevam@gmail.com" <festevam@gmail.com>,
        dl-linux-imx <linux-imx@nxp.com>,
        "linux-remoteproc@vger.kernel.org" <linux-remoteproc@vger.kernel.org>,
        "linux-arm-kernel@lists.infradead.org" 
        <linux-arm-kernel@lists.infradead.org>,
        "linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>
Subject: RE: [PATCH 1/9] dt-bindings: remoteproc: imx_rproc: support i.MX8QXP
Thread-Topic: [PATCH 1/9] dt-bindings: remoteproc: imx_rproc: support i.MX8QXP
Thread-Index: AQHYBpwqPpFjre1FRE2CDzo8h2g4iKxpKMOAgAB//MA=
Date:   Wed, 19 Jan 2022 02:20:30 +0000
Message-ID: <DU0PR04MB9417338F4E1E7F6866AFF16888599@DU0PR04MB9417.eurprd04.prod.outlook.com>
References: <20220111033333.403448-1-peng.fan@oss.nxp.com>
 <20220111033333.403448-4-peng.fan@oss.nxp.com>
 <20220118184123.GD1119324@p14s>
In-Reply-To: <20220118184123.GD1119324@p14s>
Accept-Language: en-US
Content-Language: en-US
x-ms-exchange-antispam-messagedata-chunkcount: 1
x-ms-exchange-antispam-messagedata-0: =?us-ascii?Q?4PL/ygnOonDrsvuj/5JJSc7cvCvqrEIXAVuXzZUDToHh7quVSk8HdMqJhhbK?=
 =?us-ascii?Q?mP0wDbl60Qg4KbeVhUj/+9fBrToZmVfVcsCLmxSfAdJNp9f2rZ3PyVCV5BIo?=
 =?us-ascii?Q?p8yCi7C1hRrgrUQChN/TXUCjpk1lEvzgMtfAHqMVx3o40Y5J3jLkLJgsjI2W?=
 =?us-ascii?Q?A6eS/YrqxCjsniuemBEBLLwQmT7P8nB6QSyLKWOllxP55/jAtUw8vC0FUboA?=
 =?us-ascii?Q?UGaepItFRmp46dp9mciSm1irBXlRIXqUmbMque8gms4UE2ph/B6OoPJRIgu2?=
 =?us-ascii?Q?muoSytcFTUlQmhKl/S88KRiBpAckDcQfq9Hk9FZ1GiaAkoE2rJtidls0qMAv?=
 =?us-ascii?Q?A7PP3+QVzeWIUqIMoJifAjqthAM0FPHWMIl9EZzK6EzrHSenZW7I3eiGWFPx?=
 =?us-ascii?Q?dS++7Y5qcqFdwrdoEMchNQXXaN+9bb+iitTwCoQRwrg2SLALNY8DifVidDXh?=
 =?us-ascii?Q?/XUWBxV6EZwjpxwIn/iK5ED+JKldhP5xmaR5Jo6bsWTTyzD/K5NHhNr0aCoD?=
 =?us-ascii?Q?YgLkqbJKY9UNM78HoqV3B8dI7BciATdaFWapuCv645aCvVWo3GeZnmunNcKv?=
 =?us-ascii?Q?5pXRwTWMN0fAE4Wy1cbtUOp+H+v1VlSG7taAfxdbxN+rf+FDlA/TFLVEJKes?=
 =?us-ascii?Q?IzOt4TEnrWtReKBbn8pUIgzZfW2GOfPcCc3FUQjZ2SgAo9xPDY5K/gPnvrms?=
 =?us-ascii?Q?8GuRMm5uZg6ehKGyYJOTitBjGQqK4Bq/d3ma8SlUxWRukhLY6yMeaZQL0wHa?=
 =?us-ascii?Q?w6CNWNnBKnh28Fx15cYVTP4in90kKJ5FWLTa2H8Vp9jFCvUIEunOhlZYDIZe?=
 =?us-ascii?Q?Y8jybGsSNhUV9Egq13zf6oZWFqrm9EQeN21aV2iSQOHXWpkNchFjd3omm4Yf?=
 =?us-ascii?Q?aChQma99AW/io58xWeqFHdDtNGheDvhSqmhkp3kGgcTvo1avgksY2OTYuHLp?=
 =?us-ascii?Q?m93bEhnUXoxEeD0DzVLqWEfo3bSDH5CwAEjiV/xQXqwUDD4F0lOAOETEGgoB?=
 =?us-ascii?Q?/zqzLprN0AQhMLj2fSYJg3kSQuqQCDAEB21/wE4EQ4HrfA9y32wjODxNRDji?=
 =?us-ascii?Q?/z94ztj0bstzGpJ6nyaUWA9IctyZXKKAm5i1N3wQT+PGmU98ZgJmnkKtlGe0?=
 =?us-ascii?Q?6gkvx2/X8wfuHsQV+7s+uFFd3M3AM4rVseqM3UWWOszjAVJmeRGGQ7r6f+Bw?=
 =?us-ascii?Q?gktFzhLPtdbQ3FAJlR6o8Teqfgi2XHgDabT19hweJcOoJn/fvbTjor7KscB9?=
 =?us-ascii?Q?fewFRzWDng4N+qctsrcy1tkGowrF/orbyMq2EY65nJhOwMmYsjSSyvRyn+oK?=
 =?us-ascii?Q?NW06EbdNrHLxdB5ahUIbLSeEa/whVr8sBgGZFNsnstpuUy9cfmcU1SPiGWRv?=
 =?us-ascii?Q?7lHwaJk4xtW6PsAQEkrs5fbaEm+iG/DKPSSP+e4MTZ2FaCyXySmUeyVvXa7F?=
 =?us-ascii?Q?WwQOWMRWu3Ek9l9vjFeveqlfBcsTNHp+v7ZCj1fM0aNAL2X/cOFuW4xSHwnI?=
 =?us-ascii?Q?7/vHJxX38lypUHc7wTw1bRhF3a0glgbN2GvQnJxiRfMQts7GVjjGdEAMLPsf?=
 =?us-ascii?Q?JIlVZhyDTKiqV9vb4OgIf1mhg4QWwNG28LLIyL5MDqiFQheK8J5hnVPmrLZ+?=
 =?us-ascii?Q?LWUxBjaEiLZtXdJVyTpNsZU=3D?=
Content-Type: text/plain; charset="us-ascii"
Content-Transfer-Encoding: quoted-printable
MIME-Version: 1.0
X-OriginatorOrg: nxp.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-AuthSource: DU0PR04MB9417.eurprd04.prod.outlook.com
X-MS-Exchange-CrossTenant-Network-Message-Id: 6acdd887-9078-4523-5b0d-08d9daf24428
X-MS-Exchange-CrossTenant-originalarrivaltime: 19 Jan 2022 02:20:30.8809
 (UTC)
X-MS-Exchange-CrossTenant-fromentityheader: Hosted
X-MS-Exchange-CrossTenant-id: 686ea1d3-bc2b-4c6f-a92c-d99c5c301635
X-MS-Exchange-CrossTenant-mailboxtype: HOSTED
X-MS-Exchange-CrossTenant-userprincipalname: dZ35ZHCgmGkLSZkNjetE/LUuPSH0JR2nfVOO9ej84UIVNDbLsybj/JMEILPjlbAC+9+UsrfDCcQ9yBmMb8fIiA==
X-MS-Exchange-Transport-CrossTenantHeadersStamped: DB7PR04MB4763
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

> Subject: Re: [PATCH 1/9] dt-bindings: remoteproc: imx_rproc: support
> i.MX8QXP
>=20
> On Tue, Jan 11, 2022 at 11:33:25AM +0800, Peng Fan (OSS) wrote:
> > From: Peng Fan <peng.fan@nxp.com>
> >
> > Add i.MX8QXP compatible
> >
> > Add a new property rsrc-id for SoC which supports SCFW. This rsrc-id
>=20
> You are introducing an acronym that doesn't have a definition - I have to=
 grep
> the kernel tree to have an idea of what SCFW is.  That consumes time that=
 I
> don't have to review your code or someone else's.

Sorry. SCFW(System controller Unit Firmware).

>=20
> > is used to check whether remote process is under control of Linux or
>=20
> s/process/processor

Fix in v2.

Thanks,
Peng.

>=20
> > not.
> >
> > To i.MX8QM/QXP, when M4 is in the same hardware partition with
> > Cortex-A cores, need power up M4 through SCFW, then M4 could start. So
> > introduce power-domains property
> >
> > Signed-off-by: Peng Fan <peng.fan@nxp.com>
> > ---
> >  .../devicetree/bindings/remoteproc/fsl,imx-rproc.yaml  | 10
> > ++++++++++
> >  1 file changed, 10 insertions(+)
> >
> > diff --git
> > a/Documentation/devicetree/bindings/remoteproc/fsl,imx-rproc.yaml
> > b/Documentation/devicetree/bindings/remoteproc/fsl,imx-rproc.yaml
> > index fc16d903353e..ed1bcb3046a9 100644
> > --- a/Documentation/devicetree/bindings/remoteproc/fsl,imx-rproc.yaml
> > +++ b/Documentation/devicetree/bindings/remoteproc/fsl,imx-rproc.yaml
> > @@ -19,6 +19,7 @@ properties:
> >        - fsl,imx8mm-cm4
> >        - fsl,imx8mn-cm7
> >        - fsl,imx8mp-cm7
> > +      - fsl,imx8qxp-cm4
> >        - fsl,imx8ulp-cm33
> >        - fsl,imx7d-cm4
> >        - fsl,imx7ulp-cm4
> > @@ -59,6 +60,15 @@ properties:
> >        Indicate whether need to load the default firmware and start the
> remote
> >        processor automatically.
> >
> > +  power-domains:
> > +    maxItems: 8
> > +
> > +  rsrc-id:
> > +    description:
> > +      This property is to specify the resource id of the remote proces=
sor
> in SoC
> > +      which supports SCFW
> > +    maxItems: 1
> > +
> >  required:
> >    - compatible
> >
> > --
> > 2.25.1
> >