Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18;
From:   Peng Fan <peng.fan@nxp.com>
To:     Mathieu Poirier <mathieu.poirier@linaro.org>,
        "Peng Fan (OSS)" <peng.fan@oss.nxp.com>
CC:     "bjorn.andersson@linaro.org" <bjorn.andersson@linaro.org>,
        "shawnguo@kernel.org" <shawnguo@kernel.org>,
        "s.hauer@pengutronix.de" <s.hauer@pengutronix.de>,
        "kernel@pengutronix.de" <kernel@pengutronix.de>,
        "festevam@gmail.com" <festevam@gmail.com>,
        dl-linux-imx <linux-imx@nxp.com>,
        "linux-remoteproc@vger.kernel.org" <linux-remoteproc@vger.kernel.org>,
        "linux-arm-kernel@lists.infradead.org" 
        <linux-arm-kernel@lists.infradead.org>,
        "linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>
Subject: RE: [PATCH 4/9] remoteproc: imx_rproc: ignore create mem entry for
 resource table
Thread-Topic: [PATCH 4/9] remoteproc: imx_rproc: ignore create mem entry for
 resource table
Thread-Index: AQHYBpwxAGEEQF/QB0+CG0e70/T7QqxpKmAAgAB/JCA=
Date:   Wed, 19 Jan 2022 02:23:48 +0000
Message-ID: <DU0PR04MB94170EA5A17F44FC7F9F124588599@DU0PR04MB9417.eurprd04.prod.outlook.com>
References: <20220111033333.403448-1-peng.fan@oss.nxp.com>
 <20220111033333.403448-7-peng.fan@oss.nxp.com>
 <20220118184710.GF1119324@p14s>
In-Reply-To: <20220118184710.GF1119324@p14s>
Accept-Language: en-US
Content-Language: en-US
x-ms-exchange-antispam-messagedata-chunkcount: 1
x-ms-exchange-antispam-messagedata-0: =?us-ascii?Q?VjE8W09sw/N6cN4aoCT887qOHIcx+Rftq8v3XV0wCnNJrRmbChxVbAUGKlj6?=
 =?us-ascii?Q?wAGAT30CdS9jfrZgKOR8ZpHL6gX9m+y0312dBi6OWj6X/lCWCBcvtwabt6Bl?=
 =?us-ascii?Q?Z8N961zYqtM+XQvLP+61Sl54Ez+2YcclzmFXjCZbE0DnMpR2Jc9VjFrU9hSU?=
 =?us-ascii?Q?jhK32J8Yy2RuOKDj4l49KpNOyUkRbbGQk6q2X6moUvUOoVrY+QnRVWECL0wS?=
 =?us-ascii?Q?scYOgj8J6egaERDzpz8MImYtAht6XgGHjBngipuwtzWabEEFdJlfCLfcxQGK?=
 =?us-ascii?Q?XiuBgIlZpeSXIAsjooW4zLBT95e2lf/mrrqwxOJk9Ycjis32wVoNuaRbvwMf?=
 =?us-ascii?Q?0LWR3JDRYJhrdDMbQWa4rOLBgi6pdZoEoAoRRBeodB6qYLOedlOJjHar7C2D?=
 =?us-ascii?Q?Dj4/sxbHdlimYNLT0jun/8Wd+u0HetZLxvSsqlNmEZgJJvtGxFb7oIDADmII?=
 =?us-ascii?Q?4B3pF4I2cmMszXvJYiMcw+lcersS3JV5IFzCn5DSmg3fi+E64uRUiRLSP+gu?=
 =?us-ascii?Q?wFKJ5yzISBH7f8dhThFCmy0pvrlnmdF1DS9gMoEbVCDeaYRm9bBpomTgEG+v?=
 =?us-ascii?Q?8loFLf6N/gov7GRUpU/xOTypvhsZgwTZhi/Ht9TIcKFsq7KIKICiGx5u3r5n?=
 =?us-ascii?Q?5w93I6rsle1E9cSB85KGMD/RrrIIUItT3Wr2Bi6TIxZYN+L3noBs4WOWVIZD?=
 =?us-ascii?Q?rpIjKRQSgod+Fa/0Q+aKpHXYt0m8sXZNs1MupUgftCaP5F2porHrQKuIZ6ht?=
 =?us-ascii?Q?9yI+IQUjPm8exuYe2gyLKlcmbR18oi2kdxSYd6xqg0SsUApCmaW8Yjgoia24?=
 =?us-ascii?Q?6/KlFwoytWKd4yiw7f0ef+dQc/2cWuLY27ccev8rK61ZapW8OyTNSuphmfFD?=
 =?us-ascii?Q?3DEdMK9c/2T8kitRuTjHBr0FZqrrFMfn4G+doRkOLllZE9nTxHArbWqjiFbJ?=
 =?us-ascii?Q?K7GYfWWp3JndlW4JWljPgvZrN0AYpoxJHepSnXhHAkky+tT8yk6BAYyVRPtf?=
 =?us-ascii?Q?4ZCdbdc3ab7nJnbtnSUsMiuBicsbzZRiUMQGao3KbIfn2MKiIOTRjfWJYOOt?=
 =?us-ascii?Q?+iPywHxhh+D/fF4q9N0Ljlrp65QVg3BtL0G/ETYOlOCTdYBNIcjZlmbz1diY?=
 =?us-ascii?Q?bteAGXkZskCVZvGr3BuO3eQm4+XsK0KDxFqoZrjgPRPaXjFducXuw3/V+/qc?=
 =?us-ascii?Q?uXBiQCNzDzViGXFNJKzLMWUpHobwREnu/oV/tdt0mH15Q4sYTLajUSBE2zN4?=
 =?us-ascii?Q?0Gyo/b0LcbDXhEy0/8FJHszcMaRP6pcbV540if3Jckch0SZyGhiq0G4InIUM?=
 =?us-ascii?Q?DN7D/sqBR4/IZ51x78h74isxZQwv7YjsCAF4VsEQk9TxGavmSBADey5oQoba?=
 =?us-ascii?Q?gnsUjKS1E1ga1E6PNR2RX7/ed93xGagKLX+gXWHB9Scg9fC+N4wDw13nXFhN?=
 =?us-ascii?Q?xaPTUwyymZ0xnG0qX4pEJGLM1GxSb4Ahl9lL3wu4GpaP7Qaj0UFWWRlec2vC?=
 =?us-ascii?Q?S2AqEgWUX9ptLFymoDwc2pmbpKy+T5kL2UfzWFqmXkaBWmDqWgolw3QULhCW?=
 =?us-ascii?Q?gkAyJ9ZSqOOoLDuDp8U6ru/fz0O8JybUwW88Ikr1HrLH8srlECdXoATfXy2o?=
 =?us-ascii?Q?H+YVp/2YPqQ6SQjvxzfTMcI=3D?=
Content-Type: text/plain; charset="us-ascii"
Content-Transfer-Encoding: quoted-printable
MIME-Version: 1.0
X-OriginatorOrg: nxp.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-AuthSource: DU0PR04MB9417.eurprd04.prod.outlook.com
X-MS-Exchange-CrossTenant-Network-Message-Id: 47c30104-315a-4719-5bf3-08d9daf2ba21
X-MS-Exchange-CrossTenant-originalarrivaltime: 19 Jan 2022 02:23:48.8699
 (UTC)
X-MS-Exchange-CrossTenant-fromentityheader: Hosted
X-MS-Exchange-CrossTenant-id: 686ea1d3-bc2b-4c6f-a92c-d99c5c301635
X-MS-Exchange-CrossTenant-mailboxtype: HOSTED
X-MS-Exchange-CrossTenant-userprincipalname: 1h3n5PM15IZyNO2WltPYk0oFtJkX3KCumTv98hl25XkKdvuTUA/OmM+njSI8LnRIMeLnbVcEVfpMLXHJ3rPgFw==
X-MS-Exchange-Transport-CrossTenantHeadersStamped: AM6PR04MB5045
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

> Subject: Re: [PATCH 4/9] remoteproc: imx_rproc: ignore create mem entry f=
or
> resource table
>=20
> On Tue, Jan 11, 2022 at 11:33:28AM +0800, Peng Fan (OSS) wrote:
> > From: Peng Fan <peng.fan@nxp.com>
> >
>=20
> The "ignore" in the title should have a capital 'I'.

Fix in V2

>=20
> > resource table will not be used for memory allocation, no need to
> > create
>=20
> s/resource/Resource

Fix in V2.

>=20
> > rproc mem entry.
> >
> > Signed-off-by: Peng Fan <peng.fan@nxp.com>
> > ---
> >  drivers/remoteproc/imx_rproc.c | 3 +++
> >  1 file changed, 3 insertions(+)
> >
> > diff --git a/drivers/remoteproc/imx_rproc.c
> > b/drivers/remoteproc/imx_rproc.c index 75fde16f80a4..7b2578177ea8
> > 100644
> > --- a/drivers/remoteproc/imx_rproc.c
> > +++ b/drivers/remoteproc/imx_rproc.c
> > @@ -423,6 +423,9 @@ static int imx_rproc_prepare(struct rproc *rproc)
> >  		if (!strcmp(it.node->name, "vdev0buffer"))
> >  			continue;
> >
> > +		if (!strncmp(it.node->name, "rsc-table", strlen("rsc-table")))
> > +			continue;
> > +
>=20
> This is a bug fix that should be in a separate patch with a "Fixes:" tag.

ok.

Thanks,
Peng.

>=20
> >  		rmem =3D of_reserved_mem_lookup(it.node);
> >  		if (!rmem) {
> >  			dev_err(priv->dev, "unable to acquire memory-region\n");
> > --
> > 2.25.1
> >