Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18;
To:     John Meneghini <jmeneghi@redhat.com>
Cc:     linux-scsi@vger.kernel.org, linux-kernel@vger.kernel.org,
        GR-QLogic-Storage-Upstream@marvell.com, mlombard@redhat.com,
        skashyap@marvell.com, guazhang@redhat.com
Subject: Re: [PATCH v3] scsi: bnx2fc: flush destroy_work queue before
 calling bnx2fc_interface_put
From:   "Martin K. Petersen" <martin.petersen@oracle.com>
Organization: Oracle Corporation
Message-ID: <yq1pmool6y1.fsf@ca-mkp.ca.oracle.com>
References: <20220115040044.1013475-1-jmeneghi@redhat.com>
Date:   Tue, 18 Jan 2022 22:51:03 -0500
In-Reply-To: <20220115040044.1013475-1-jmeneghi@redhat.com> (John Meneghini's
        message of "Fri, 14 Jan 2022 23:00:44 -0500")
Content-Type: text/plain
MIME-Version: 1.0
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0: =?us-ascii?Q?E7Lv2oDCa3SdiIPN8MaS50a44QVP+uJrwJSVvcHYVekrCnzzY38VB2limFKq?=
 =?us-ascii?Q?2Z/eHIRZspw1xg7EzecHMvDj9mwJgQNhcC5LAJFNglIvjricSHXUNrMOclJJ?=
 =?us-ascii?Q?/mVQV4AKNit7eJ8FZQGfKesHTdRBHx7yMOJuqQFCX/qQwBo5tbGbRpTNvCn1?=
 =?us-ascii?Q?T19IasGU0/SuOZZ1OCxJGneslqI9rINh8dZR7NN5JB39/yvttYy3AXuxWVNX?=
 =?us-ascii?Q?j9Pm4m9LkYfxllbV094ASTO9Qr4XTWPEVVrQrKi7L61uoEqM02sC3m5C8Da3?=
 =?us-ascii?Q?2GKoG7qPiFeTjJWjTSVwIFq7st0zMSC6AJjVad2mIn4kesjLcEOx6BfaE1q6?=
 =?us-ascii?Q?ipwyg6f/92eGYhwodDaso09+RPAb9K0izI+UBukpWx0PP+NvwnDz1pkhsB+F?=
 =?us-ascii?Q?mlIf2cIYf1l6wxrgn4t8s23mx0s3CwaqqKHD0G6Z8Y7xANXdGoLT4zoZJPgj?=
 =?us-ascii?Q?pnCIqq1pCMgBdgPAFvbXVkTUA8dJjDCOOqsbbZ5Wetooov2o2XVu28YRyj2g?=
 =?us-ascii?Q?52g70zNIQYGJYBz71rtJZuydxq+YLIQSgZ0jqGeLDPqb/NJwSIV0ZyPhfP8R?=
 =?us-ascii?Q?BQSjjFtxPhMA/qBWfghYNhBKWMxUMP56NsE7G5k1B3kk/9tOz8vI1MhXhNQ3?=
 =?us-ascii?Q?52GmEyqQ9gjs4tvUiglTYvBOPZ5TY8h3NVWfVENfak9T6gwq3bPBVxHApjgW?=
 =?us-ascii?Q?CNZdAlyBU0gkuFaRoDn5CKBt9uo6zhBX1hYTfN1oXNMSKkobS4Q5qK4j5lQj?=
 =?us-ascii?Q?ZXJDUUv1KoD2Chhtl//lzKk6wNkIHxtl57Nt4BQlnqNdn96DQoocuOa5/yeN?=
 =?us-ascii?Q?FZdd/gZWor1KkERUQT4nr1OUytiyxvURQKTsqkpc1Nfs4I3Iu5zM+fM/pMCd?=
 =?us-ascii?Q?ewOaDttlFiPUEm60iSEj7E0aHgapbCVSv3QImIYxQJ/Nj3U/+HmCOiq93nyN?=
 =?us-ascii?Q?hOgA6RGvyCgLKEpSvcexVTdaAb6+3FEaedcGAhBxs/mnAHku5idkaEyBO4T7?=
 =?us-ascii?Q?if61fEjcpFz7Ka8LxxWErxnbCOCfdo4fNIiiujxBqzp//yZ9NtdTpUG9wYtc?=
 =?us-ascii?Q?8S+E0n1z9V9RVqujvxLjGxzOAqL/IewZbpRl/58w4InISzXiZRdz74LIlEqL?=
 =?us-ascii?Q?cwhnEumamIelK18t6ETGI+3ID87VNB6AXKW71IrYqG8bU6WF0nDxKhjwJXAw?=
 =?us-ascii?Q?LsfazG9DtpYYBq0cn5R+V0e4eVThoSP3d9VNOZ/awKdT1HhhdPhFvm+Hog53?=
 =?us-ascii?Q?lKarhmqSahz55OjDay+5HraVRjTpUM8Sfq0ArTMpbEZ1zsknJkMPgJAaRBj6?=
 =?us-ascii?Q?rc3rVtlbN4pyvI2fz41AEnowNzkV6spbYad5haTFJqcgVEqMTd+DqX7VwCPD?=
 =?us-ascii?Q?kdnZLa+RsfN3mG8byIjwTCenskz2phnhI35OUkhyzYWU3os9voCbydLjqtuX?=
 =?us-ascii?Q?oc0ouBxTO5OHXKY0vket0ec4n77EKKyQLkWMwWOsoQujXJCNPl0G9/N2N1Y0?=
 =?us-ascii?Q?/o+Onx4sHY7nRO1LOODGPfwreX8SqDRuNrzqy7lyvXY5AdHNMAinBgv4R+Am?=
 =?us-ascii?Q?YN5bsKCb96TqhAAsTMlP3E8kCzteb6isAxWM20cUGEXszI+OVBFExXISZGLN?=
 =?us-ascii?Q?2QUk9zkJVmmmBtJdU3S/F8XawdcKQt/rzzW4EDxx+bmHMo9S4jHSpAk8Akfc?=
 =?us-ascii?Q?INwyzw=3D=3D?=
X-OriginatorOrg: oracle.com
X-MS-Exchange-CrossTenant-Network-Message-Id: ac735131-3603-43c1-a197-08d9dafeeb71
X-MS-Exchange-CrossTenant-AuthSource: PH0PR10MB4759.namprd10.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 19 Jan 2022 03:51:05.7526
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: 4e2c6054-71cb-48f1-bd6c-3a9705aca71b
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: xSOvOCBQDfUJ4FOePEw4v5Rerm7TJtxlx1kT8hgLPZOvMtXyXlpAnGaNQqJ0fwDe/ueoOGOum1zeh6UmdET8UzYFVwC+hPqzfhzaWJIujus=
X-MS-Exchange-Transport-CrossTenantHeadersStamped: BN6PR10MB1410
X-Proofpoint-Virus-Version: vendor=nai engine=6300 definitions=10231 signatures=668683
X-Proofpoint-Spam-Details: rule=notspam policy=default score=0 adultscore=0 mlxscore=0 suspectscore=0
 phishscore=0 malwarescore=0 mlxlogscore=783 spamscore=0 bulkscore=0
 classifier=spam adjust=0 reason=mlx scancount=1 engine=8.12.0-2110150000
 definitions=main-2201190017
X-Proofpoint-GUID: KYnfsgk3eU-DqYQ3jPBPljJRT3NjI_SJ
X-Proofpoint-ORIG-GUID: KYnfsgk3eU-DqYQ3jPBPljJRT3NjI_SJ
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org


John,

> The bnx2fc_destroy functions are removing the interface before calling
> destroy_work. This results multiple WARNings from sysfs_remove_group
> as the controller rport device attributes are removed to early.
>
> Replace the fcoe_port's destroy_work queue.  It's not needed.

Applied to 5.17/scsi-staging, thanks!

-- 
Martin K. Petersen	Oracle Linux Engineering