Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18;
Date:   Wed, 19 Jan 2022 08:34:11 +0300
From:   Dan Carpenter <dan.carpenter@oracle.com>
To:     Paulo Miguel Almeida <paulo.miguel.almeida.rodenas@gmail.com>
Cc:     gregkh@linuxfoundation.org, realwakka@gmail.com,
        linux-staging@lists.linux.dev, linux-kernel@vger.kernel.org
Subject: Re: [PATCH v2 3/3] staging: pi433: validate max bit_rate based on
 modulation used
Message-ID: <20220119053410.GW1978@kadam>
References: <20220117055849.GA10644@mail.google.com>
 <20220117060220.GA11202@mail.google.com>
 <20220118135902.GH1951@kadam>
 <20220118193422.GA3155@mail.google.com>
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <20220118193422.GA3155@mail.google.com>
User-Agent: Mutt/1.9.4 (2018-02-28)
MIME-Version: 1.0
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0: =?us-ascii?Q?sMKLC278/bkXdUtnOyJjHTf5/Cl3qLxYF3W03Iz7QtPalKrpNtMt0x4uEdKg?=
 =?us-ascii?Q?VKUFmmWzDFe87Hji1YUcMC0k56NuNxMdsAkiNHSmILPmAx49Q9I8gzdWfTbH?=
 =?us-ascii?Q?33BRGfiAPUctdJFPt2cgcHWUEYLRqLj+zXU4QMDbsVq3nfBI+SZ8LjEwUB3z?=
 =?us-ascii?Q?zVNjDDcluKLYX4EjwYP9ffQmIgbkcGIBYVHKPtvsUUEIB7AcQjNTokR6GnKo?=
 =?us-ascii?Q?qU5scqObYOWg7lw+GBw9AXKnhLQNG9VYZ/LlmR/2LvG17PZAQRcS6ET+Js3X?=
 =?us-ascii?Q?8RmyOwAc6EWeXTuupeXRy8j4H6OhOCp5ybJ7WoZcJBKHt74hw8vjVfWvEqwQ?=
 =?us-ascii?Q?UcF2XuVAa/1jjkpH7mKaU9tj/09eLUnu81KidCIE+VTxo3mlgTlPMFuwFW6y?=
 =?us-ascii?Q?ZrJVVqD8GqF0VgqBGhsTE+C0xbQjlFdOw/mxMPaPUtSYdLV6XNvkfjAnUI62?=
 =?us-ascii?Q?7KQ6RigRGcxMWPEj96Frkwq1idvyfDgLFBewHjfEGI4a2yejs/dPTSLc13k6?=
 =?us-ascii?Q?pjP8B6FUfk1qzn/TMOIxUaZxIGd8LIQbL34EfCWsyhWuLc+C1GXEMzvB/f6V?=
 =?us-ascii?Q?lQm8kD/HAdfIdqPj+qFkwRPL/gsF79Dz9JHklh+DYlutmNPw6blwhWZIobmr?=
 =?us-ascii?Q?wn/+OPI4f0xKBKaale8i2eKyymwUU92FRmDqimsuKXVn/79ppRpWkyg6fXZH?=
 =?us-ascii?Q?MhblW4FfDdGRRBw52CkP05lGi7RWczPkE4OKNJ4iklVegPgKOCTrK/wycyZy?=
 =?us-ascii?Q?F4H1llli24S4LjmqCxawn4Fmnw8EZwhO+1pdi7br2KqTmcV1EHoTDLj8WJLe?=
 =?us-ascii?Q?99/5100vqpCn3Ltvs4QbK/x5q91Ocbwa7nK6K9e275o4k1ix2p8Ab/j86leG?=
 =?us-ascii?Q?kwJ6pJCb1U3OjKapaPRjqgileYntd4R7fkA6/+o3k+7ydQfrvBl+wyMlsaVN?=
 =?us-ascii?Q?Px6sIAjgbRPFdN2NcGo02bTLQ+J0e15v/yaciyY8XRb5E1GgObLL+1O8vyeQ?=
 =?us-ascii?Q?FL3QMBjbRaHDO4rDUsEJkPGbjYrBJT7kOx1DAWA0Mjw8KyKRNLOgO+lt6UOD?=
 =?us-ascii?Q?x1ak6a7cdfRz9OH+biAJTOQ4WurtPABVSGTBIh05vaxVmWzl6fhT9ZhfbAAj?=
 =?us-ascii?Q?RRChaZ0+9El8pQk4rhUUJxKAHPq9BiRQAUUr2qB+cAhiuRaM4YBGPSNpuHmE?=
 =?us-ascii?Q?KtZjsrns0dfPNiA9rotdhDDexOhACN5DJQbav0YJTZFklujRPBRCH9ULs9d+?=
 =?us-ascii?Q?2pJLOomo6ChT740Jj3avxej/6fh2TCWy+zHKbZ7YlbW0G901qWTqafXTYcU/?=
 =?us-ascii?Q?NmeydMYCay8/fPrlmCNTIKL0q0nNe0dUt+w02+Yh0O8aRbnbuW/T9k3NLrs+?=
 =?us-ascii?Q?6QtCH/I3d9TTd0T+P3q9kFZ5nXv93Ooxl9b0zIDZHdHh7XhXI5j1I17V627Y?=
 =?us-ascii?Q?sTXs4rzQl3p8jsHPcGbzDl2/mSiozKIi0NzBbl/eqxd78DZnZ5TBBbloMA+d?=
 =?us-ascii?Q?9zrN8ETPDDpHuuYyPgwAB7bDynsab3eAf+3Qd3mhEIusRTyz5YZe0pyTHBpj?=
 =?us-ascii?Q?TIpYnn6jG6aSwVMiXvM2ouu63ZAMqUiCDZ40sb/N3lbsBT9rPWMUFYXFtapY?=
 =?us-ascii?Q?GHfxfcw9OJDhdAXdq4bNQLtp8anL7dQ4auIytKB5OxvdE8ziayWm/j9dM6HS?=
 =?us-ascii?Q?dQEB3UhRL701VZk6EiJS0dVKlEk=3D?=
X-OriginatorOrg: oracle.com
X-MS-Exchange-CrossTenant-Network-Message-Id: f2a0488c-c73c-45e2-3865-08d9db0d5d85
X-MS-Exchange-CrossTenant-AuthSource: MWHPR1001MB2365.namprd10.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 19 Jan 2022 05:34:30.4236
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: 4e2c6054-71cb-48f1-bd6c-3a9705aca71b
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: +WgbAS7MfeF8ccAggi6yb8PhDznQIv8s3VpYhGYsPzUQZjtAAe/Hz2nxW9jYnv2C/YFAZFFixIvdx/OnE8Xiki+jSZ6muJJjsXmrNqlG14U=
X-MS-Exchange-Transport-CrossTenantHeadersStamped: BN0PR10MB5253
X-Proofpoint-Virus-Version: vendor=nai engine=6300 definitions=10231 signatures=668683
X-Proofpoint-Spam-Details: rule=notspam policy=default score=0 suspectscore=0 bulkscore=0
 malwarescore=0 adultscore=0 phishscore=0 mlxscore=0 spamscore=0
 mlxlogscore=999 classifier=spam adjust=0 reason=mlx scancount=1
 engine=8.12.0-2110150000 definitions=main-2201190028
X-Proofpoint-GUID: v3HAgcLvFdq_hqG3NprAHH0pejedSA6r
X-Proofpoint-ORIG-GUID: v3HAgcLvFdq_hqG3NprAHH0pejedSA6r
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

On Wed, Jan 19, 2022 at 08:34:22AM +1300, Paulo Miguel Almeida wrote:
> On Tue, Jan 18, 2022 at 04:59:02PM +0300, Dan Carpenter wrote:
> > At the same time, this is a GCC warning so it will break the build.
> > 
> > Instead of applying this patch, I wish you would just make a note of it
> > in the drivers/staging/pi433/TODO file.  
> > 
> >     "Change (struct pi433_tx_cfg)->bit_rate to be a u32 so that we can
> >      support bit rates up to 300kbps per the spec."
> 
> thanks for taking the time to review this patchset.
> 
> It makes sense to me. So essentially for this version of the patchset I
> would only validate OOK max bit rate as it fits within the u16 boundary
> of the current implementation, right?
> 
> Something akin to this:
> 
> // check input value
> if (bit_rate < 1200 || (mod == OOK && bit_rate > 32768)) {
> 	dev_dbg(&spi->dev, "setBitRate: illegal input param");
> 	return -EINVAL;
> }

Actually, on further reflection, your patch is fine.  But please put a
note in the TODO that ->bit_rate needs to be changed to a u32.  Just
resend this patch series with that additional note in the TODO.

> 
> > 
> > But you're right that it's complicated to fix this because it's part of
> > the UAPI.  I think that the UAPI for pi433 is kind of garbage.  No one
> > like custom ioctls.  It would be better to use sysfs.  
> > ...
> > So my idea is that instead of modifying the custom ioctl then we can
> > just add a new sysfs file to set the bit_rate and all the other stuff.
> > Eventually we will delete the ioctl after all the users have updated to
> > the new userspace.
> > 
> 
> Using sysfs or even possibly configfs was one of the things I had in
> mind too. 
> 
> I started a similar discussion on how to change/remove ioctl:
> https://lore.kernel.org/kernelnewbies/YeVoAlv0ubKrmckV@kroah.com/T/#t 
> 
> The tldr;:
> 
> If there is a userspace tool that interfaces with char
> device and we can change it at the same time as the kernel code then we 
> can have a bit more flexibility on how to send/retrieve values to/from 
> the driver. If not then we would be required to keep the original ioctl
> compatibility even if we move to a different approach due to the
> impossibility of knowing whether or not someone is relying on that. :(
> 
> Everything leads me to believe that there isn't such userspace tool /
> lib so I emailed the original author just to be 100% sure that this is
> the case.

I don't know which is more appropriate sysfs or configfs.  I haven't
used configfs much and also I don't know much about pi433.

But I would encourage you to leave the ioctl as is.  There is no
advantage to the ioctl except backwards compatability.  This stuff can
all be done with sysfs.  It would be easier and more flexible going
forward.

regards,
dan carpenter