Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18;
Date:   Wed, 19 Jan 2022 08:35:37 +0100
From:   Petr Vorel <pvorel@suse.cz>
To:     Mimi Zohar <zohar@linux.ibm.com>
Cc:     linux-integrity@vger.kernel.org,
        linux-security-module@vger.kernel.org,
        Paul Moore <paul@paul-moore.com>,
        James Morris <jmorris@namei.org>, linux-kernel@vger.kernel.org
Subject: Re: [PATCH] MAINTAINERS: add missing "security/integrity" directory
Message-ID: <Yee/SaBeQMQBuIge@pevik>
Reply-To: Petr Vorel <pvorel@suse.cz>
References: <20220117230229.16475-1-zohar@linux.ibm.com>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <20220117230229.16475-1-zohar@linux.ibm.com>
Precedence: bulk

Hi Mimi,

LGTM.
Reviewed-by: Petr Vorel <pvorel@suse.cz>

Few comments below.

> Update the IMA and EVM records to include the "security/integrity"
> directory.

> Signed-off-by: Mimi Zohar <zohar@linux.ibm.com>
> ---
>  MAINTAINERS | 2 ++
>  1 file changed, 2 insertions(+)

> diff --git a/MAINTAINERS b/MAINTAINERS
> index 5250298d2817..a9973d0991e3 100644
> --- a/MAINTAINERS
> +++ b/MAINTAINERS
> @@ -7181,6 +7181,7 @@ M:	Mimi Zohar <zohar@linux.ibm.com>
>  L:	linux-integrity@vger.kernel.org
>  S:	Supported
Aren't you a maintainer? How about
S:  Maintained

>  F:	security/integrity/evm/
> +F:	security/integrity
I'd add trailing slash (i.e. security/integrity/)

How about adding git tree to EVM?

>  EXTENSIBLE FIRMWARE INTERFACE (EFI)
>  M:	Ard Biesheuvel <ardb@kernel.org>
> @@ -9419,6 +9420,7 @@ L:	linux-integrity@vger.kernel.org
>  S:	Supported
and here

>  T:	git git://git.kernel.org/pub/scm/linux/kernel/git/zohar/linux-integrity.git
>  F:	security/integrity/ima/
> +F:	security/integrity
and here

>  INTEL 810/815 FRAMEBUFFER DRIVER
>  M:	Antonino Daplas <adaplas@gmail.com>

Kind regards,
Petr