Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18;
Message-ID: <8fecb51a-e3e8-b3ca-247b-6825e8ce433f@amd.com>
Date:   Wed, 19 Jan 2022 17:05:52 +0530
User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:91.0) Gecko/20100101
 Thunderbird/91.3.2
Cc:     Sean Christopherson <seanjc@google.com>,
        Vitaly Kuznetsov <vkuznets@redhat.com>,
        Wanpeng Li <wanpengli@tencent.com>,
        Jim Mattson <jmattson@google.com>,
        Joerg Roedel <joro@8bytes.org>,
        Brijesh Singh <brijesh.singh@amd.com>,
        Tom Lendacky <thomas.lendacky@amd.com>,
        Peter Gonda <pgonda@google.com>, kvm@vger.kernel.org,
        linux-kernel@vger.kernel.org, Paolo Bonzini <pbonzini@redhat.com>,
        Bharata B Rao <bharata@amd.com>
Subject: Re: [RFC PATCH 6/6] KVM: SVM: Pin SEV pages in MMU during
 sev_launch_update_data()
Content-Language: en-US
To:     "Maciej S. Szmigiero" <mail@maciej.szmigiero.name>
References: <20220118110621.62462-1-nikunj@amd.com>
 <20220118110621.62462-7-nikunj@amd.com>
 <010ef70c-31a2-2831-a2a7-950db14baf23@maciej.szmigiero.name>
 <28a005b7-9ae3-fe0d-b003-9aedba27dc85@maciej.szmigiero.name>
From:   "Nikunj A. Dadhania" <nikunj@amd.com>
In-Reply-To: <28a005b7-9ae3-fe0d-b003-9aedba27dc85@maciej.szmigiero.name>
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: 8bit
MIME-Version: 1.0
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?ajFqQlc1VmdjWDhSSTM1d2x2UHBnZmgxYkJwSzU4dkNRMXV2bFREM0k5aWRz?=
 =?utf-8?B?VVd3MWNaZ2sveStYRFVvaWVGS0Q4bUo5M2hUcXVZWVhBUVAwVU5KTk90NFRo?=
 =?utf-8?B?cW5MWVFWb1hNbkZVcm4yZzJVZ21iZzdmRU8xdTZ4RXNuUnJycHhCUlNXdG1j?=
 =?utf-8?B?SEZXZHRrS0FBZHZVOGdyd2l1Y3lxdkttUEk2aVVCellJSjNmZWVLR0RyU3hY?=
 =?utf-8?B?SlozQ2lJcGxWYm9yTkJNaXJWWkdoeDA5MWxVZ0dmbjRXSEJjRStRMkNQNHRM?=
 =?utf-8?B?OXNCSFpiUlNYRGJ1RWtnWnBGbDQxLzI3a2hGNytTYVc4bXRqZUZQV3BRcUds?=
 =?utf-8?B?WFNTVlJ0MHRPMTF4OVU0UDdnWHpMZUxOa0NxM0R0YUQyZ3BldUZTMENaTU9D?=
 =?utf-8?B?aWRFZGZ5OTZMdXo5TTJMSDRNQjNRaXNIQm9wWWIzc05PWHdrSFVPWXRQMWlw?=
 =?utf-8?B?b1dhdXoybDc2MDh4V0VUd1lad2JxYThON01Ua2RWaFlxaXZEUTZNVUR3REhQ?=
 =?utf-8?B?WDJIMTlkTU5ycWZlV1M0TndmUWRuKy8xU3UyUktGQXhjNmt2K3NtZk12MXQz?=
 =?utf-8?B?bytjckNQQ0g0VHhrQ0VPM21UUGNBeXgrSUFwbFhNUFIwanp5cFQ5V3ZERzcz?=
 =?utf-8?B?OTRaMGNSM2d2WEVuTXZiRGR5TlVhRHQ2cHNlQ1d0TTZqSFVydzlrR1NnUzZV?=
 =?utf-8?B?NGMzKzIyUitqVUxUM1c5eHREdzMxVHJlZlUwRVozSWROcy90NWIzRDMvT05O?=
 =?utf-8?B?M2J2NHdXMzAyVFQ4b0VVUWNHbWpXbkp4RnFrSndzODdsRWpTV0Y1ZDJpWHJN?=
 =?utf-8?B?azEybTN3R1MvMWtKR0lwNTBvV2grQ3BKblZVQkRHNFJxdmhwZTJHSjJZekxZ?=
 =?utf-8?B?WUJyL2kxbWpUOTA2aUtsUjdseGJFeWZuWGlyZGdDdlg4dE9JUzhiOGsxQXlC?=
 =?utf-8?B?cUVSRDlQWURHQWFIQkxTRythaENpc2tZODhUMlpkN1gwNWVpYXBBVVh3V1lC?=
 =?utf-8?B?SHNQNklCSGZORU9NLy9uaFh4UXhaQlVrcE9KRWhlNTk4TnF4OVpZY3h3S3Ri?=
 =?utf-8?B?NjFVcEF2NEczaUIzczA4ZVZkZ2UxZ0F2NmNCY0RjVnduWnRUSnJ5VUJ1Sk9U?=
 =?utf-8?B?TERUNTFLRUhBVFNHZEV6Q1EyVUdVNWIydEwyN3oxRkJwY2d0SWVtYmN1TkF2?=
 =?utf-8?B?MVlEWHFhcmtrNmFQOWFlc2l4REF2UEM5WUJ0RVVZN1ArZ1o5UExMYkJGd1U4?=
 =?utf-8?B?a2s0S0FPT2VvYXJKQkRIc2sra1FLd2tMNSs1ZkV6SnM3ZkFSaExoWVpsbHhI?=
 =?utf-8?B?Wm9SdldCQW91eUd5VXd4KzIzR1pEY2F4MmllNmhiZkVQN0Y0SW05UUFSaFBn?=
 =?utf-8?B?SEI1Z1NZeFJJZmpuQUltMTZ0SWgrQ1R2R0NtdXM1UVlxZTFoNDg3aGE5aVBq?=
 =?utf-8?B?cHNNdHBhQ3VLZ0Z3TXpodytyVnV3WHhidjV6MHkrRjRRMmZ2ay8ySTNOak5Q?=
 =?utf-8?B?N0RxdWpOV3Jxdno5QkZGMmFZNWhoMTZZN2xtQnNHejFlTXZhRDFVRlc3OGxY?=
 =?utf-8?B?cXBJc2ovZWNEbUtjZG1LZkVtYmdwa3d6Tkl5eUFWQ3VEUGt4M1ZMYkJEVllh?=
 =?utf-8?B?TDA3a0QzMEdUTDU0RHUveFoxcjdQYmNJelpaSnJvSWd1eDc4MTQwd1ppZWhB?=
 =?utf-8?B?OGFpcUswc0RMSFM2dzMzRlcwR0tmK3p2dThXbnJSMEQ2RWhETHNBMjhRaTFI?=
 =?utf-8?B?WDZoS1o0Q3UrYVVoaVk1ZENRTDhkUk43VVFXMmoxNzAvRWFpeisvOXdlMWNG?=
 =?utf-8?B?N25kRGppRE5GeklHb04yS21ZdjE1ci9sUnFINW1wdThuVXdvaXk3akY5Z0pt?=
 =?utf-8?B?c2NvS1h2WFJ5UWZ5Q0JXKyt5MG9FSVV5Z2pvQjFvN3ZodmhYRVpYRFk5bCtQ?=
 =?utf-8?B?dEcyYS9qbEdUYlNsakRhb0NndVE3VCszVTV5NDBWY3FnY1NmWCtObnZLbHR1?=
 =?utf-8?B?TkN5RG0xUnF0emhzZTQ0THJCTmRJMFFMNHRjTXJSWStscW9WNUlROHRhblVW?=
 =?utf-8?B?ckRWK3pQZjRFMWowWUJXMVpYTzNtZmlqY0gwc3ZyLzkwcUsrRHRQd1F6S1J5?=
 =?utf-8?B?UFk5b3dIRkRwQVVNSTRXQnF6UW9mWE41M29YYTR5WXBFdFQ3OFN2ZVJnU0JL?=
 =?utf-8?Q?d3WVXW1DRlixRBuCFvaa35Q=3D?=
X-OriginatorOrg: amd.com
X-MS-Exchange-CrossTenant-Network-Message-Id: 1eb35ba7-c5cf-41f7-3f53-08d9db3fe398
X-MS-Exchange-CrossTenant-AuthSource: DM5PR12MB2470.namprd12.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 19 Jan 2022 11:36:10.2463
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: 3dd8961f-e488-4e60-8e11-a82d994e183d
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: 4z0lpd6WfuydvZYV64ramPw6GiJOqdISj8MVhScNZqaA2R+OiYG3HkGFqsvEK2SZb0Y5MzN85rVIqGrBWFNkuw==
X-MS-Exchange-Transport-CrossTenantHeadersStamped: BN6PR1201MB0163
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

On 1/18/2022 10:59 PM, Maciej S. Szmigiero wrote:
> On 18.01.2022 16:00, Maciej S. Szmigiero wrote:
>> Hi Nikunj,
>>
>> On 18.01.2022 12:06, Nikunj A Dadhania wrote:
>>> From: Sean Christopherson <sean.j.christopherson@intel.com>
>>>
>>> Pin the memory for the data being passed to launch_update_data()
>>> because it gets encrypted before the guest is first run and must
>>> not be moved which would corrupt it.
>>>
>>> Signed-off-by: Sean Christopherson <sean.j.christopherson@intel.com>
>>> [ * Changed hva_to_gva() to take an extra argument and return gpa_t.
>>>    * Updated sev_pin_memory_in_mmu() error handling.
>>>    * As pinning/unpining pages is handled within MMU, removed
>>>      {get,put}_user(). ]
>>> Signed-off-by: Nikunj A Dadhania <nikunj@amd.com>
>>> ---
>>>   arch/x86/kvm/svm/sev.c | 122 ++++++++++++++++++++++++++++++++++++++++-
>>>   1 file changed, 119 insertions(+), 3 deletions(-)
>>>
>>> diff --git a/arch/x86/kvm/svm/sev.c b/arch/x86/kvm/svm/sev.c
>>> index 14aeccfc500b..1ae714e83a3c 100644
>>> --- a/arch/x86/kvm/svm/sev.c
>>> +++ b/arch/x86/kvm/svm/sev.c
>>> @@ -22,6 +22,7 @@
>>>   #include <asm/trapnr.h>
>>>   #include <asm/fpu/xcr.h>
>>> +#include "mmu.h"
>>>   #include "x86.h"
>>>   #include "svm.h"
>>>   #include "svm_ops.h"
>>> @@ -490,6 +491,110 @@ static unsigned long get_num_contig_pages(unsigned long idx,
>>>       return pages;
>>>   }
>>> +#define SEV_PFERR_RO (PFERR_USER_MASK)
>>> +#define SEV_PFERR_RW (PFERR_WRITE_MASK | PFERR_USER_MASK)
>>> +
>>> +static struct kvm_memory_slot *hva_to_memslot(struct kvm *kvm,
>>> +                          unsigned long hva)
>>> +{
>>> +    struct kvm_memslots *slots = kvm_memslots(kvm);
>>> +    struct kvm_memory_slot *memslot;
>>> +    int bkt;
>>> +
>>> +    kvm_for_each_memslot(memslot, bkt, slots) {
>>> +        if (hva >= memslot->userspace_addr &&
>>> +            hva < memslot->userspace_addr +
>>> +            (memslot->npages << PAGE_SHIFT))
>>> +            return memslot;
>>> +    }
>>> +
>>> +    return NULL;
>>> +}
>>
>> We have kvm_for_each_memslot_in_hva_range() now, please don't do a linear
>> search through memslots.
>> You might need to move the aforementioned macro from kvm_main.c to some
>> header file, though.
> 
> Besides performance considerations I can't see the code here taking into
> account the fact that a hva can map to multiple memslots (they an overlap
> in the host address space).

You are right I was returning at the first match, looks like if I switch to using 
kvm_for_each_memslot_in_hva_range() it should take care of overlapping hva, 
is this understanding correct ?

Regards
Nikunj